Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send spec #13143

Merged
merged 20 commits into from
Aug 27, 2020
Merged

Send spec #13143

merged 20 commits into from
Aug 27, 2020

Conversation

rakshith91
Copy link
Contributor

@rakshith91 rakshith91 commented Aug 17, 2020 •
edited
Loading

Fixes #12958

@rakshith91 rakshith91 changed the base branch from master to event_grid_v2 August 17, 2020 07:56
@rakshith91 rakshith91 self-assigned this Aug 17, 2020
@rakshith91 rakshith91 marked this pull request as ready for review August 19, 2020 03:38
@rakshith91 rakshith91 requested review from KieranBrantnerMagee and removed request for kalyanaj August 19, 2020 03:39
rakshith91
rakshith91 commented Aug 19, 2020
View reviewed changes
sdk/eventgrid/azure-eventgrid/azure/eventgrid/_publisher_client.py
self._client.publish_cloud_event_events(self._topic_hostname, events, **kwargs)
elif all(isinstance(e, EventGridEvent) for e in events):
elif all(isinstance(e, EventGridEvent) for e in events) or all(isinstance(e, dict) for e in events):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentionally not doing a client side validation for dicts that are not cloud event

@rakshith91 rakshith91 changed the base branch from event_grid_v2 to feature/event_gridv2 August 19, 2020 05:32
@rakshith91 rakshith91 changed the base branch from feature/event_gridv2 to master August 20, 2020 00:07
t-swpill and others added 9 commits August 19, 2020 23:02
@t-swpill @rakshith91
Event grid track 2 (Azure#12768)
3cd4cbe 
* genereated python client for event grid

* updated readme to use track2 generator

* added sas key auth sample

* added consume sample, not final

* removing old eg

* added track 2 changes needed for api view

* add consumer operations

* cleanup client versions for api view

* remove _initialize_mapping() in BaseEventType class in models

* track 2 design manual changes

* added publisher wrapper in azure/eventgrid for demo

* modified naming for publish sample for demo

* final sample fix for demo

* added response to publish_events(), still need to fix

* added decoder for apiview

* renamed consumer, added Deserialized/CustomEvent

* final for Board Review

* testing changes

* added EventGridSharedAccessSignatureCredential,Policy and modified samples

* added eg_client test

* moving generated code out from event_grid_publisher_client nested folder

* added consumption function samples

* removed eg required package and removed service bus dependency in consumer

* removed unnecessary functions

* changed consumer deserialize_event() to take,return single event of one type of (string, bytes string, dict). changed DeserializedEvent to have to_json() method, instead of extending DictMixin

* added publish tests

* fixed PR, added CustomEvent, added tests/samples

* updated swagger, removed unnecessary imports

* removed unnecessary reqs in dev_requirements

* changed async publisher import path, added type hints

* modified typehints for publishers, based on apiview

* added newlines

* added shared_reqs file

* moved shared_requirement

* fixed non live test

* added changelog, test fix

* changed topic preparer

* added samples to exclude to setup.py
@AutorestCI @rakshith91
Packaging update of azure-eventgrid
69ce1f1
@AutorestCI @rakshith91
Packaging update of azure-eventgrid
da433c1
@rakshith91
tests fix (Azure#13026)
88bd601 
* other fixes

* p2 compat
@AutorestCI @rakshith91
Packaging update of azure-eventgrid
5303288
@rakshith91
Event grid v2 (Azure#13051)
04a61c4 
* other fixes

* auto update
@rakshith91
Send spec initial
7d35094
@rakshith91
recordings
977e140
@rakshith91
tests fix
5fe6516
Update sdk/eventgrid/azure-eventgrid/tests/recordings/test_eg_publish…
7b014cc 
…er_client.test_eg_publisher_client_publish_event_grid_event_data_dict.yaml
@KieranBrantnerMagee
Apply suggestions from code review
e191136 
Co-authored-by: KieranBrantnerMagee <kibrantn@microsoft.com>
@KieranBrantnerMagee KieranBrantnerMagee added Client This issue points to a problem in the data-plane of the library. Event Grid labels Aug 21, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] September milestone Aug 21, 2020
@rakshith91
Copy link
Contributor Author

/azp run python - eventgrid - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Rakshith Bhyravabhotla and others added 3 commits August 27, 2020 09:49
@KieranBrantnerMagee
Apply suggestions from code review
de9a50e 
Co-authored-by: KieranBrantnerMagee <kibrantn@microsoft.com>
@KieranBrantnerMagee
Apply suggestions from code review
081cf65 
Co-authored-by: KieranBrantnerMagee <kibrantn@microsoft.com>
@KieranBrantnerMagee
Apply suggestions from code review
3f88670 
Co-authored-by: KieranBrantnerMagee <kibrantn@microsoft.com>
@rakshith91 rakshith91 merged commit 9f4bbb0 into Azure:master Aug 27, 2020
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Aug 28, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
d08baa6 
…into return_none_for_offset_length_v3

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [text analytics] add string-index-type support (Azure#13378)
  [text analytics] fix error response if pii entities is called from v3.0 client (Azure#13383)
  Send spec (Azure#13143)
  Anomaly Detector 3.0.0b2 release (Azure#13351)
  azure-keyvault-administration generated code (Azure#12098)
  fixed bug in querying by page using continuation token (Azure#13298)
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Sep 1, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
05be0b7 
…into expose_parse_vault_id

* 'master' of https://github.com/Azure/azure-sdk-for-python: (37 commits)
  [text analytics] add versionadded sphinx documentation (Azure#13450)
  [text analytics] add bing_id property to LinkedEntity class (Azure#13446)
  fix typing for paging methods (Azure#13410)
  [text analytics] add domain_filter param (Azure#13451)
  fix issue Azure#11658 for is_valid_resource_id (Azure#11709)
  added create_table_if_not_exists method to table service client (Azure#13385)
  [ServiceBus] Test and failure improvements (Azure#13345)
  Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275)
  Switch retry (Azure#13264)
  [ServiceBus] ServiceBusClient close spawned children (Azure#13077)
  fixing version issue by not overwriting the version with the semantic… (Azure#13411)
  clean up reference and tests (Azure#13412)
  Consistent returns (Azure#13245)
  [text analytics] return None for offset and length for v3.0 (Azure#13382)
  edit all authentication files and add a test (Azure#13355)
  Add managed_identity_client_id argument to DefaultAzureCredential (Azure#13218)
  [text analytics] add string-index-type support (Azure#13378)
  [text analytics] fix error response if pii entities is called from v3.0 client (Azure#13383)
  Send spec (Azure#13143)
  Anomaly Detector 3.0.0b2 release (Azure#13351)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KieranBrantnerMagee KieranBrantnerMagee KieranBrantnerMagee approved these changes

Assignees

@rakshith91 rakshith91

Labels
Client This issue points to a problem in the data-plane of the library. Event Grid
Projects
None yet
Milestone
[2020] September
Development

Successfully merging this pull request may close these issues.

Send EventGrid spec
4 participants
@rakshith91 @KieranBrantnerMagee @t-swpill @AutorestCI