-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create HttpClientTransportOptions and utilize it in Confidential Ledger #23420
Merged
christothes
merged 56 commits into
Azure:main
from
christothes:chriss/HttpHandlerCustomization
Nov 12, 2021
Merged
Create HttpClientTransportOptions and utilize it in Confidential Ledger #23420
christothes
merged 56 commits into
Azure:main
from
christothes:chriss/HttpHandlerCustomization
Nov 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christothes
requested review from
KrzysztofCwalina,
pakrym and
tg-msft
as code owners
August 19, 2021 23:05
ghost
added
the
Azure.Core
label
Aug 19, 2021
pakrym
reviewed
Aug 20, 2021
pakrym
reviewed
Aug 20, 2021
pakrym
reviewed
Aug 20, 2021
pakrym
reviewed
Aug 23, 2021
pakrym
reviewed
Aug 23, 2021
pakrym
reviewed
Aug 23, 2021
pakrym
reviewed
Aug 23, 2021
pakrym
reviewed
Aug 23, 2021
sdk/confidentialledger/Azure.Security.ConfidentialLedger/src/ConfidentialLedgerClient.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
Aug 24, 2021
pakrym
reviewed
Aug 24, 2021
pakrym
reviewed
Aug 24, 2021
pakrym
reviewed
Aug 24, 2021
pakrym
reviewed
Aug 24, 2021
pakrym
reviewed
Aug 24, 2021
pakrym
reviewed
Aug 24, 2021
pakrym
reviewed
Aug 24, 2021
sdk/confidentialledger/Azure.Security.ConfidentialLedger/src/ConfidentialLedgerClient.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
Oct 29, 2021
pakrym
reviewed
Oct 29, 2021
pakrym
reviewed
Oct 29, 2021
pakrym
reviewed
Oct 29, 2021
sdk/core/Azure.Core/tests/HttpWebRequestTransportFunctionalTest.cs
Outdated
Show resolved
Hide resolved
API changes have been detected in |
christothes
requested review from
archerzz,
ArcturusZhang,
ArthurMa1978,
fengzhou-msft and
Yao725
as code owners
November 1, 2021 15:00
API changes have been detected in |
pakrym
reviewed
Nov 8, 2021
pakrym
reviewed
Nov 9, 2021
pakrym
approved these changes
Nov 9, 2021
API changes have been detected in |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Apr 14, 2023
Release sentinel 2023 04 01 preview (Azure#23121) * Adds base for updating Microsoft.SecurityInsights from version preview/2023-03-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * Workspace Manager Members (Azure#23134) * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * Workspace Manager Members * udpate pattern * Workspace manager configurations (Azure#23133) * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * adding april configurations swagger * update pattern * prettier update * update readme * Workspace manager assignments (Azure#23130) * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * Workspace Manager Assignments/Jobs * update readme * updated from comments * update from lint diff errors * updated descriptions * Workspace manager groups (Azure#23135) * Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * april swagger for groups * update path name & pattern * [Hunts] Add hunts to Sentinel 2023-04-01-preview version (Azure#23139) * Add hunts files * Include update in 200 description and add defaults * Add back 201 * Update relation properties * Update example --------- Co-authored-by: Derrick Lee <derricklee@microsoft.com> * Add readonly flag to providerName property (Azure#23259) * sentinel content hub package and template API (Azure#23151) * commit for content template and content package API * fix issues reported by swagger lint * add 201 for put requests in template service * resolve the comments * resolve comments in packageId * resolve comments * update descriptions due to lint error (Azure#23392) * Fix policheck issue by updating the description. (Azure#23415) * Fix polich issue by updating the description. * update the description to fix a typo. * Release sentinel 2023 04 01 preview (Azure#23420) * Fix polich issue by updating the description. * update the description to fix a typo. * fix policheck by updating description * rename enum name to stable version to fix cross-version breaking change failure. * fix typo (Azure#23463) --------- Co-authored-by: rheabansal <93624991+rheabansal@users.noreply.github.com> Co-authored-by: Derrick Lee <derricklee91@gmail.com> Co-authored-by: Derrick Lee <derricklee@microsoft.com> Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com> Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com> Co-authored-by: Nan Zang <nazang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on the following changes:
HttpPipelineTransportOptions
ServerCertificateCustomValidationCallback
property allows configuration of aFunc<ServerCertificateCustomValidationArgs, bool>
delegate to be called when validating the server side TLS certificateHttpPipelineBuilder.Build
taking anHttpPipelineTransportOptions
to construct the transport with an http handler with all existing defaults and apply the options to the created http handler.The transport options are applied in the pipeline builder so that we can avoid mutating the provided ClientOptions, which avoids using options with client instance specific transport options on other clients.
In addition, internal to
HttpPipelineBuilder
, we check if the default Transport has been set after default construction before applying the new transport with transport options applied. In the case that transport options were provided but not applied, an event is logged(PipelineTransportOptionsNotApplied
).