Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create HttpClientTransportOptions and utilize it in Confidential Ledger #23420

Merged
merged 56 commits into from
Nov 12, 2021

Conversation

christothes
Copy link
Member

@christothes christothes commented Aug 19, 2021

This PR focuses on the following changes:

  • Create HttpPipelineTransportOptions
    • ServerCertificateCustomValidationCallback property allows configuration of a Func<ServerCertificateCustomValidationArgs, bool> delegate to be called when validating the server side TLS certificate
  • Create new static overload for HttpPipelineBuilder.Build taking an HttpPipelineTransportOptions to construct the transport with an http handler with all existing defaults and apply the options to the created http handler.
  • Automate the setup of the Confidential Ledger client to trust the TLS cert root advertised by the Identity endpoint using the new options

The transport options are applied in the pipeline builder so that we can avoid mutating the provided ClientOptions, which avoids using options with client instance specific transport options on other clients.

In addition, internal to HttpPipelineBuilder, we check if the default Transport has been set after default construction before applying the new transport with transport options applied. In the case that transport options were provided but not applied, an event is logged (PipelineTransportOptionsNotApplied).

@christothes christothes self-assigned this Aug 24, 2021
@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Core. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Core. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Core. You can review API changes here

@christothes christothes merged commit 512c444 into Azure:main Nov 12, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Apr 14, 2023
Release sentinel 2023 04 01 preview (Azure#23121)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-03-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Workspace Manager Members (Azure#23134)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Workspace Manager Members

* udpate pattern

* Workspace manager configurations (Azure#23133)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* adding april configurations swagger

* update pattern

* prettier update

* update readme

* Workspace manager assignments (Azure#23130)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Workspace Manager Assignments/Jobs

* update readme

* updated from comments

* update from lint diff errors

* updated descriptions

* Workspace manager groups (Azure#23135)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* april swagger for groups

* update path name & pattern

* [Hunts] Add hunts to Sentinel 2023-04-01-preview version (Azure#23139)

* Add hunts files

* Include update in 200 description and add defaults

* Add back 201

* Update relation properties

* Update example

---------

Co-authored-by: Derrick Lee <derricklee@microsoft.com>

* Add readonly flag to providerName property (Azure#23259)

* sentinel content hub package and template API (Azure#23151)

* commit for content template and content package API

* fix issues reported by swagger lint

* add 201 for put requests in template service

* resolve the comments

* resolve comments in packageId

* resolve comments

* update descriptions due to lint error (Azure#23392)

* Fix policheck issue by updating the description. (Azure#23415)

* Fix polich issue by updating the description.

* update the description to fix a typo.

* Release sentinel 2023 04 01 preview (Azure#23420)

* Fix polich issue by updating the description.

* update the description to fix a typo.

* fix policheck by updating description

* rename enum name to stable version to fix cross-version breaking change failure.

* fix typo (Azure#23463)

---------

Co-authored-by: rheabansal <93624991+rheabansal@users.noreply.github.com>
Co-authored-by: Derrick Lee <derricklee91@gmail.com>
Co-authored-by: Derrick Lee <derricklee@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com>
Co-authored-by: Nan Zang <nazang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants