Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for resources in core #23151

Conversation

Yao725
Copy link
Member

@Yao725 Yao725 commented Aug 6, 2021

Add test cases for the following resources:

  • DataPolicyManifest
  • ManagementLockObject
  • PolicyAssignment
  • PolicyDefinition
  • PolicyExemption
  • PolicySetDefinition
  • ResourceLink

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 6, 2021
@ghost
Copy link

ghost commented Aug 6, 2021

Thank you for your contribution @Yao725! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Aug 6, 2021
@ghost
Copy link

ghost commented Aug 6, 2021

CLA assistant check
All CLA requirements met.

@yungezz yungezz added the Mgmt This issue is related to a management-plane library. label Aug 20, 2021
@Yao725 Yao725 removed customer-reported Issues that are reported by GitHub users external to the Azure organization. Community Contribution Community members are working on the issue labels Aug 23, 2021
@fengzhou-msft fengzhou-msft merged commit 8da6289 into Azure:feature/mgmt-track2-resources-for-core Aug 23, 2021
@Yao725 Yao725 deleted the feature/mgmt-track2-resources-for-core-tests branch November 9, 2021 05:20
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Apr 14, 2023
Release sentinel 2023 04 01 preview (Azure#23121)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-03-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Workspace Manager Members (Azure#23134)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Workspace Manager Members

* udpate pattern

* Workspace manager configurations (Azure#23133)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* adding april configurations swagger

* update pattern

* prettier update

* update readme

* Workspace manager assignments (Azure#23130)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Workspace Manager Assignments/Jobs

* update readme

* updated from comments

* update from lint diff errors

* updated descriptions

* Workspace manager groups (Azure#23135)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* april swagger for groups

* update path name & pattern

* [Hunts] Add hunts to Sentinel 2023-04-01-preview version (Azure#23139)

* Add hunts files

* Include update in 200 description and add defaults

* Add back 201

* Update relation properties

* Update example

---------

Co-authored-by: Derrick Lee <derricklee@microsoft.com>

* Add readonly flag to providerName property (Azure#23259)

* sentinel content hub package and template API (Azure#23151)

* commit for content template and content package API

* fix issues reported by swagger lint

* add 201 for put requests in template service

* resolve the comments

* resolve comments in packageId

* resolve comments

* update descriptions due to lint error (Azure#23392)

* Fix policheck issue by updating the description. (Azure#23415)

* Fix polich issue by updating the description.

* update the description to fix a typo.

* Release sentinel 2023 04 01 preview (Azure#23420)

* Fix polich issue by updating the description.

* update the description to fix a typo.

* fix policheck by updating description

* rename enum name to stable version to fix cross-version breaking change failure.

* fix typo (Azure#23463)

---------

Co-authored-by: rheabansal <93624991+rheabansal@users.noreply.github.com>
Co-authored-by: Derrick Lee <derricklee91@gmail.com>
Co-authored-by: Derrick Lee <derricklee@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com>
Co-authored-by: Nan Zang <nazang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants