Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log certain exceptions so we don't lose their stacktraces #23139

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

lchew7
Copy link
Member

@lchew7 lchew7 commented Aug 5, 2021

No description provided.

…ses. In those cases where it doesn't and the caller throws the exception, the stacktrace gets truncated at the throw-site. This change is to make sure the input exceptions are always wrapped, so that we preserve the original stacktrace.
@ghost ghost added the Service Bus label Aug 5, 2021
Copy link

@shankarsama shankarsama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lchew7 lchew7 merged commit ce07ea5 into main Sep 8, 2021
@lchew7 lchew7 deleted the PreventTruncationOfClientExceptionStacktrace branch September 8, 2021 22:15
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Apr 14, 2023
Release sentinel 2023 04 01 preview (Azure#23121)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-03-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Workspace Manager Members (Azure#23134)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Workspace Manager Members

* udpate pattern

* Workspace manager configurations (Azure#23133)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* adding april configurations swagger

* update pattern

* prettier update

* update readme

* Workspace manager assignments (Azure#23130)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Workspace Manager Assignments/Jobs

* update readme

* updated from comments

* update from lint diff errors

* updated descriptions

* Workspace manager groups (Azure#23135)

* Adds base for updating Microsoft.SecurityInsights from version preview/2023-02-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* april swagger for groups

* update path name & pattern

* [Hunts] Add hunts to Sentinel 2023-04-01-preview version (Azure#23139)

* Add hunts files

* Include update in 200 description and add defaults

* Add back 201

* Update relation properties

* Update example

---------

Co-authored-by: Derrick Lee <derricklee@microsoft.com>

* Add readonly flag to providerName property (Azure#23259)

* sentinel content hub package and template API (Azure#23151)

* commit for content template and content package API

* fix issues reported by swagger lint

* add 201 for put requests in template service

* resolve the comments

* resolve comments in packageId

* resolve comments

* update descriptions due to lint error (Azure#23392)

* Fix policheck issue by updating the description. (Azure#23415)

* Fix polich issue by updating the description.

* update the description to fix a typo.

* Release sentinel 2023 04 01 preview (Azure#23420)

* Fix polich issue by updating the description.

* update the description to fix a typo.

* fix policheck by updating description

* rename enum name to stable version to fix cross-version breaking change failure.

* fix typo (Azure#23463)

---------

Co-authored-by: rheabansal <93624991+rheabansal@users.noreply.github.com>
Co-authored-by: Derrick Lee <derricklee91@gmail.com>
Co-authored-by: Derrick Lee <derricklee@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com>
Co-authored-by: Nan Zang <nazang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants