[identity] Skip expired cert tests #29930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorleger
requested review from
pvaneck,
billwert,
ahsonkhan,
chlowell and
xiangyan99
|
API change check API changes are not detected in this pull request. |
|
/azp run js - identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
min tests are failing with @KarishmaGhiya I recommend checking with Jeremy and/or Minh-Anh who recently bumped the min-version of core-client to address this in another package |
KarishmaGhiya
approved these changes
Jun 6, 2024
|
/check-enforcer override |
3 tasks
minhanh-phan
added a commit
that referenced
this pull request
Jun 6, 2024
### Packages impacted by this PR @azure/identity @azure/test-utils ### Issues associated with this PR #29930 ### Describe the problem that is addressed by this PR Bump the version of @azure/core-client for min/ max test in live pipeline in Identity & Test recorder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/identity
Issues associated with this PR
#29929
Describe the problem that is addressed by this PR
Identity relies on a set of static resources for some of its tests. The
cert/secret for one of these resources expired and we cannot renew the
credentials until we use test / ephemeral tenants.
This PR skips those tests in live mode as per our discussion with the Identity
feature crew