Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[identity] Skip expired cert tests #29930

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[identity] Skip expired cert tests #29930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/identity/identity/test/internal/node/msalClient.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ describe("MsalClient", function () {
});

it("supports getTokenByClientSecret", async function () {
if (isLiveMode()) {
// https://github.com/Azure/azure-sdk-for-js/issues/29929
this.skip();
}
const scopes = ["https://vault.azure.net/.default"];
const clientSecret = env.IDENTITY_SP_CLIENT_SECRET || env.AZURE_CLIENT_SECRET!;
const clientId = env.IDENTITY_SP_CLIENT_ID || env.AZURE_CLIENT_ID!;
Expand Down
6 changes: 5 additions & 1 deletion sdk/identity/identity/test/public/node/clientCertificateCredential.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import * as path from "path";

import { MsalTestCleanup, msalNodeTestSetup } from "../../node/msalNodeTestSetup";
import { Recorder, delay, env, isPlaybackMode } from "@azure-tools/test-recorder";
import { Recorder, delay, env, isLiveMode, isPlaybackMode } from "@azure-tools/test-recorder";

import { AbortController } from "@azure/abort-controller";
import { ClientCertificateCredential } from "../../../src";
Expand All @@ -26,6 +26,10 @@ describe("ClientCertificateCredential", function () {
cleanup = setup.cleanup;
recorder = setup.recorder;
await recorder.setMatcher("BodilessMatcher");
if (isLiveMode()) {
// https://github.com/Azure/azure-sdk-for-js/issues/29929
this.skip();
}
});
afterEach(async function () {
await cleanup();
Expand Down
Loading