Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[identity] re-enable cert tests #29929

Open
maorleger opened this issue Jun 6, 2024 · 0 comments
Open

[identity] re-enable cert tests #29929

maorleger opened this issue Jun 6, 2024 · 0 comments
Assignees
@maorleger
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
Backlog

Comments

@maorleger
Copy link
Member

maorleger commented Jun 6, 2024 •
edited
Loading

Some of our tests rely on a now-expired SP secret that can not be renewed per policies.

Longer term, we will be using test-tenants for these tests. Until those are in-place and the static resource updated
we will pend the live tests, resuming them when the updated resources are in place
@maorleger maorleger added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Jun 6, 2024
@maorleger maorleger added this to the Backlog milestone Jun 6, 2024
@maorleger maorleger self-assigned this Jun 6, 2024
@maorleger maorleger mentioned this issue Jun 6, 2024
Merged
maorleger added a commit that referenced this issue Jun 6, 2024
@maorleger
[identity] Skip expired cert tests (#29930)
2f7e7a4 
### Packages impacted by this PR

@azure/identity

### Issues associated with this PR

#29929

### Describe the problem that is addressed by this PR

Identity relies on a set of static resources for some of its tests. The
cert/secret for one of these resources expired and we cannot renew the
credentials until we use test / ephemeral tenants.

This PR skips those tests in live mode as per our discussion with the
Identity feature crew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maorleger maorleger

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
Azure Identity SDK Improvements
Status: Backlog
Milestone
Backlog
Development

No branches or pull requests
1 participant
@maorleger