Monitor query readme #16791

KarishmaGhiya · 2021-08-06T00:45:07Z

scottaddie

Let's also include a tree that depicts the metrics response object graph. For example, here's how Python did it: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/monitor/azure-monitor-query/README.md#handle-metrics-response.

sdk/monitor/monitor-query/README.md

sdk/monitor/monitor-query/samples-dev/logsQueryBatch.ts

sdk/monitor/monitor-query/samples/v1/javascript/logsQueryBatch.js

sdk/monitor/monitor-query/samples/v1/typescript/src/logsQueryBatch.ts

sdk/monitor/monitor-query/README.md

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

…atch.ts Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

KarishmaGhiya · 2021-08-06T06:46:50Z

Why don't the other languages like Python and Java not have these fields in the Metric object? These are there in the generated code -
cc: @srnagar @rakshith91 @scottaddie

/** Detailed description of this metric. */
  displayDescription?: string;
  /** 'Success' or the error details on query failures for this metric. */
  errorCode?: string;
  /** Error message encountered querying this specific metric. */
  errorMessage?: string;

KarishmaGhiya · 2021-08-06T06:49:48Z

In this issue - #15984 we need to add object hierarchy for LogsQuery Response object too, but I don't see that in Python or Java readme. Can you confirm if we need to add? cc: @scottaddie @srnagar @rakshith91

rakshith91 · 2021-08-06T17:33:19Z

Can you confirm if we need to add?

yes - we must :)

rakshith91 · 2021-08-06T17:34:50Z

/** Detailed description of this metric. */
  displayDescription?: string;
  /** 'Success' or the error details on query failures for this metric. */
  errorCode?: string;
  /** Error message encountered querying this specific metric. */
  errorMessage?: string;

interesting - what exactly does it do?

sdk/monitor/monitor-query/README.md

KarishmaGhiya · 2021-08-06T22:44:10Z

Added the Metrics response object - @scottaddie

Let's also include a tree that depicts the metrics response object graph. For example, here's how Python did it: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/monitor/azure-monitor-query/README.md#handle-metrics-response.

Addressed the changes requested. Dismissing right now, so this can be merged by EOD today.

joshfree · 2021-08-06T23:01:26Z

@srnagar @pakrym @rakshith91 ptal

scottaddie

This looks good after you incorporate my suggestions.

sdk/monitor/monitor-query/README.md

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

joshfree · 2021-08-06T23:29:46Z

The Set logs query timeout code block is missing language coloring

srnagar · 2021-08-07T00:56:02Z

sdk/monitor/monitor-query/README.md

+
+### Query metrics
+
+The following example gets metrics for an [Azure Metrics Advisor](https://docs.microsoft.com/azure/applied-ai-services/metrics-advisor/overview) subscription. The resource URI is that of a Metrics Advisor resource.


Fix link and link name to use Azure Monitor instead of Metrics Advisor

I think this is used as an example to get the resource URI. Python used eventgrid as the example.

…ya/azure-sdk-for-js into monitor-query-readme

KarishmaGhiya · 2021-08-09T08:07:56Z

will do a follow up PR to add the link to main branch for multi-workspace sample which is added as part of this PR

Web ant95 2021 03 01 (Azure#16506) * Adds base for updating Microsoft.Web from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917) * Introduce enterpriseGradeCdnStatus to StaticSites.json (Azure#16080) * Update StaticSites.json * Update StaticSites.json * Onedeploy API swapper spec (Azure#15985) * Onedeploy API swapper spec * Adding onedeploy custom keyword * Formatting onedeploy api indentation Formatting onedeploy api indentation * prettifier Co-authored-by: Calvin Chan <calvinch4n@gmail.com> * Fix status codes for syncfunctiontriggers (Azure#16413) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web (Azure#16427) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web * Fix duplicate operation ids * Swagger for ASD Transfer out (Azure#16000) * Add domain transfer out to swagger * Prettifier * Add 202 response for webapp restart * Add certificate listHostnameBindingsOfCertificate * Formatting * Swagger for listHostnameBindings endpoint (Azure#16516) * Swagger for listHostnameBindings endpoint * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917) * ops Co-authored-by: Naveed Aziz <naveeda@microsoft.com> * User/jennylaw/containerapp (Azure#16657) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Add custom hostname sites endpoint (Azure#16745) * Add custom hostname sites endpoint * Fix models * Swagger Fixes for Container App, KubeEnvironments spec (Azure#16793) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Fix Kube Environments 2021-03-01 contract + add list secrets api to Container Apps Swagger * Fix sercret read property * Prettier fix * Model fix * Prettier Fix #2 Co-authored-by: Jenny Lawrance <jennylaw@microsoft.com> * Add long running extension for restart (Azure#16791) * Remove unused API from ANT95 swagger (Azure#16901) * Address PR comments (Azure#17019) * Fixing PR comments (Azure#17127) * Remove Certificate Hostname bindings API (Azure#17204) * Remove Certificate Hostname bindings API * Remove examples file as well Co-authored-by: mkarmark <mikarmar@microsoft.com> Co-authored-by: SatishRanjan <SatishRanjan@users.noreply.github.com> Co-authored-by: Calvin Chan <calvinch4n@gmail.com> Co-authored-by: Connor McMahon <comcmaho@microsoft.com> Co-authored-by: JennyLawrance <jennylaw@microsoft.com> Co-authored-by: Sanchit Mehta <sanchit.mehta602@gmail.com>

KarishmaGhiya added 3 commits August 5, 2021 17:41

update samples for logsQueryBatch

7113672

update samples for logsQueryBatch

1809836

add samples on readme

740a227

KarishmaGhiya requested review from maorleger and richardpark-msft as code owners August 6, 2021 00:45

ghost added the Monitor Monitor, Monitor Ingestion, Monitor Query label Aug 6, 2021

KarishmaGhiya added 2 commits August 5, 2021 18:23

multiple workspaces

2eb826a

add samples

7fc5859

scottaddie previously requested changes Aug 6, 2021

View reviewed changes

KarishmaGhiya and others added 10 commits August 5, 2021 23:23

Update sdk/monitor/monitor-query/README.md

044c65c

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Update sdk/monitor/monitor-query/README.md

a60e250

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Update sdk/monitor/monitor-query/README.md

99d2d06

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Update sdk/monitor/monitor-query/README.md

d6d8491

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Update sdk/monitor/monitor-query/README.md

d7386d1

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Update sdk/monitor/monitor-query/README.md

6db03eb

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Update sdk/monitor/monitor-query/samples-dev/logsQueryBatch.ts

a118b45

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Update sdk/monitor/monitor-query/samples/v1/javascript/logsQueryBatch.js

bb19fbb

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Update sdk/monitor/monitor-query/samples/v1/typescript/src/logsQueryB…

2bdf330

…atch.ts Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Update sdk/monitor/monitor-query/README.md

e2fc823

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

update readme with Metrics Query Object hierarchy

d2c0d0f

KarishmaGhiya mentioned this pull request Aug 6, 2021

UX study feedback #16596

Closed

KarishmaGhiya commented Aug 6, 2021

View reviewed changes

sdk/monitor/monitor-query/README.md Outdated Show resolved Hide resolved

Update sdk/monitor/monitor-query/README.md

abb5e55

KarishmaGhiya requested a review from scottaddie August 6, 2021 22:45

joshfree requested review from srnagar, pakrym and rakshith91 August 6, 2021 23:01

scottaddie approved these changes Aug 6, 2021

View reviewed changes

sdk/monitor/monitor-query/README.md Outdated Show resolved Hide resolved

sdk/monitor/monitor-query/README.md Outdated Show resolved Hide resolved

sdk/monitor/monitor-query/README.md Outdated Show resolved Hide resolved

KarishmaGhiya and others added 3 commits August 6, 2021 16:05

Update sdk/monitor/monitor-query/README.md

a53eb11

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Update sdk/monitor/monitor-query/README.md

4f685b2

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

Update sdk/monitor/monitor-query/README.md

34fa769

Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>

joshfree approved these changes Aug 6, 2021

View reviewed changes

srnagar approved these changes Aug 7, 2021

View reviewed changes

KarishmaGhiya added 11 commits August 6, 2021 18:45

add correct language coloring

e142ae3

Merge branch 'monitor-query-readme' of https://github.com/KarishmaGhi…

0375d61

…ya/azure-sdk-for-js into monitor-query-readme

updated changelog

98d217b

update the logsBatch

2b2fb6b

regenerate samples

418f036

update the api

9544ebb

fix unit test

a63aa9b

update querylogsresult and querylogsbachresult

c8d9775

update querylogsresult and querylogsbachresult

d542ffe

update the readme with logs response

0ddeae5

update the readme with logs response

9252a43

KarishmaGhiya enabled auto-merge (squash) August 9, 2021 08:08

KarishmaGhiya merged commit 1c10ff3 into Azure:main Aug 9, 2021

This was referenced Aug 10, 2021

Add samples link for multiple workspaces #16825

Merged

Update Monitor Query Samples, Quickstarts, and Documentation based on Beta-2 consistency review #15983

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Monitor query readme #16791

Monitor query readme #16791

KarishmaGhiya commented Aug 6, 2021 •

edited

Loading

scottaddie left a comment

KarishmaGhiya commented Aug 6, 2021 •

edited

Loading

KarishmaGhiya commented Aug 6, 2021

rakshith91 commented Aug 6, 2021

rakshith91 commented Aug 6, 2021

KarishmaGhiya commented Aug 6, 2021

joshfree commented Aug 6, 2021

scottaddie left a comment

joshfree commented Aug 6, 2021

srnagar Aug 7, 2021

KarishmaGhiya Aug 7, 2021

KarishmaGhiya commented Aug 9, 2021


		### Query metrics

		The following example gets metrics for an [Azure Metrics Advisor](https://docs.microsoft.com/azure/applied-ai-services/metrics-advisor/overview) subscription. The resource URI is that of a Metrics Advisor resource.

Monitor query readme #16791

Monitor query readme #16791

Conversation

KarishmaGhiya commented Aug 6, 2021 • edited Loading

scottaddie left a comment

Choose a reason for hiding this comment

KarishmaGhiya commented Aug 6, 2021 • edited Loading

KarishmaGhiya commented Aug 6, 2021

rakshith91 commented Aug 6, 2021

rakshith91 commented Aug 6, 2021

KarishmaGhiya commented Aug 6, 2021

joshfree commented Aug 6, 2021

scottaddie left a comment

Choose a reason for hiding this comment

joshfree commented Aug 6, 2021

srnagar Aug 7, 2021

Choose a reason for hiding this comment

KarishmaGhiya Aug 7, 2021

Choose a reason for hiding this comment

KarishmaGhiya commented Aug 9, 2021

KarishmaGhiya commented Aug 6, 2021 •

edited

Loading

KarishmaGhiya commented Aug 6, 2021 •

edited

Loading