Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault Keys] ResourceType "Microsoft.KeyVault/managedHSMs" deploys failed on UsGov and China cloud #18414

Closed
zzhxiaofeng opened this issue Oct 28, 2021 · 4 comments · Fixed by #18431
Closed

[Key Vault Keys] ResourceType "Microsoft.KeyVault/managedHSMs" deploys failed on UsGov and China cloud #18414

zzhxiaofeng opened this issue Oct 28, 2021 · 4 comments · Fixed by #18431
Assignees
@maorleger
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-sovereign-cloud

Comments

@zzhxiaofeng
Copy link
Contributor

We are running live tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.

Error Description:
ResourceType Microsoft.KeyVault/managedHSMs deploys failed on UsGov and China cloud, it return an error InvalidResourceType. The error message is shown as following, for more details please check here.
image

Expected Behavior:
ResourceType Microsoft.KeyVault/managedHSMs deploys successfully on UsGov and China cloud.

@benbp, @ramya-rao-a, @AlexGhiondea, @maorleger for notification.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 28, 2021
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. KeyVault test-sovereign-cloud labels Oct 28, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 28, 2021
@maorleger
Copy link
Member

maorleger commented Oct 28, 2021 •
edited
Loading

Not every cloud supports HSMs - I would remove it from the matrix configuration in govt cloud environments. We define that additional entry here

@benbp 👋 is it possible to remove that entry from government cloud test matrices? Not sure how that is handled

@benbp
Copy link
Member

benbp commented Oct 28, 2021

@maorleger yes there's a cloud-specific exclusion that you can copy over from the net tests.yml.

@maorleger
Copy link
Member

Thanks @benbp !

@zzhxiaofeng is this something you can open a PR for?

@zzhxiaofeng zzhxiaofeng mentioned this issue Oct 29, 2021
Merged
@zzhxiaofeng
Copy link
Contributor Author

zzhxiaofeng commented Oct 29, 2021 •
edited
Loading

@maorleger I have opened a PR for this issue. Please have a look when you are free.

@v-xuto v-xuto mentioned this issue Nov 12, 2021
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Apr 14, 2022
@bcho @zqingqing1
@yizhang4321 @wenxuan0923 @ZeroMagic @alexeldeib
CodeGen from PR 18633 in Azure/azure-rest-api-specs
c16c82c 
Review request for Microsoft.ContainerService to add version 2022-03-02-preview (Azure#18633)

* Adds base for updating Microsoft.ContainerService from version preview/2022-02-02-preview to version 2022-03-02-preview

* Updates readme

* Updates API version in new specs and examples

* feat: add `/rotateServiceAccountSigningKeys` API (Azure#18359)

* feat: add `/rotateServiceAccountSigningKeys` API

* chore: remove duplicated description

* feat: add `workloadIdentity` settings to `SecurityProfile` (Azure#18360)

* fix: update example name (Azure#18382)

* add creationData to mc data (Azure#18414)

* add creationData to mc data

* fix test

* fix format

* Add API properties and example JSON for Web App Routing of IngressProfile (Azure#18564)

* Add API properties and example JSON for Web App Routing of IngressProfile.

* Add a ending period for description to match the style in all other "descriptions" in the same file.

* Update readmes for the 2022-03-02-preview dev branch of container service (Azure#18358)

* update readme

* update sdk readmes

* Agentpool alias minor version 2022-03-02-preview (Azure#18381)

* Add field currentOrchestratorVersion to support Agentpool alias minor version

* Add new exmaple for alias minor version

* Remove example for PrettierCheck

* Fix typo

* Latest patch version supported is 1.22.7 at the moment

* Address comments - refine descriptions for fields

* feat: add ManagedCluster StorageProfile in 0302preview (Azure#18590)

Signed-off-by: Ji An Liu <jiliu8@microsoft.com>

* Swagger change for ignore-pod-disruption-budget (Azure#18548)

* Swagger change for ignore-pod-disruption-budget

* Change ignorePodDisruptionBudget to string in example file.

* Change ignorePodDisruptionBudget to boolean type.

* add effectiveNoProxy for AKS (Azure#18544)

* add effectiveNoProxy for AKS

* add to correct api

* fix lowercase -> uppercase O

* spelling

* Replace common type definitions with references since 2022-03-02-preview for Microsoft.ContainerService  (Azure#18567)

* replace Resource

* replace SystemData

* replace parameters

* change track2 to python

Co-authored-by: hbc <bcxxxxxx@gmail.com>
Co-authored-by: Qingqing <qizhe@microsoft.com>
Co-authored-by: Yi Zhang <yizhang5@microsoft.com>
Co-authored-by: Thalia Wang <58485997+wenxuan0923@users.noreply.github.com>
Co-authored-by: Ji'an Liu <jiliu8@microsoft.com>
Co-authored-by: Tong Chen <45081443+tonche@users.noreply.github.com>
Co-authored-by: Ace Eldeib <aleldeib@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-sovereign-cloud
Projects
None yet
Milestone
No milestone
4 participants
@maorleger @benbp @ramya-rao-a @zzhxiaofeng