Make core rest client work with null and encoding #18381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
requested review from
bterlson,
deyaaeldeen,
jeremymeng,
joheredi,
ramya-rao-a and
xirzec
as code owners
ghost
added
the
joheredi
reviewed
Oct 27, 2021
joheredi
reviewed
Oct 28, 2021
joheredi
reviewed
Oct 28, 2021
qiaozha
requested review from
mikeharder,
praveenkuttappan and
witemple-msft
as code owners
|
API changes have been detected in API changes + skipUrlEncoding?: boolean; |
joheredi
reviewed
Nov 2, 2021
joheredi
reviewed
Nov 2, 2021
|
Given that all packages being affected here are auto generated ones, should we consider first releasing the core package being fixed, then fix the code generator and then update the packages? |
|
Also, please note that tomorrow is code complete date for all core packages |
If we don't update the packages now,, the |
@qiaozha which errors are you getting? |
|
okay let me change it back and see what's the errors in the CI. |
|
hmm, no ci errors now, not sure why I saw errors complaining about it previously, I think we are good to go now? |
deyaaeldeen
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Please revert changes in the pnpm-lock.yaml, I do not think there should be any changes. You can do so by running `git checkout main .
You could verify that no changes needed by running rush update afterwards with no other parameters. If you find changes, please feel free to commit and push and I will take another look.
https://dev.azure.com/azure-sdk/public/_build/results?buildId=1175151&view=logs&j=3dc8fd7e-4368-5a92-293e-d53cefc8c4b3&t=386f29c8-4681-50e7-ecbc-1b877753e479 That is the error I was talking about @joheredi @deyaaeldeen |
zihzhan-msft
added a commit
that referenced
this pull request
Nov 4, 2021
commit be431bcc1a60f85e2e310e343d3a09a200b94b46
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 3 19:28:00 2021 -0700
Add prompt before replasing latest release title on prepare release run (#18522)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit 74b93c7fb8078de1f309a00447ee617d9a1764ea
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Wed Nov 3 18:14:40 2021 -0700
[Tables] Expose continuation token on TableServiceClient.listTables (#18277)
* Expose continuation token on TableServiceClient.listTables
* Update changelog
commit 73f714dccc053ab1d0534018d27374786c10b571
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 3 17:10:49 2021 -0700
Post release automated changes for azure-core-http (#18519)
commit 848242cd9d84470ec7c4b53a3ad30e16f1f8668b
Author: Ben Broderick Phillips <bebroder@microsoft.com>
Date: Wed Nov 3 18:34:12 2021 -0400
Use working region/subscription for search deployments (#18512)
commit ed6cc1e22b039fa5fbb2bafa3d23e8db73f490ee
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 3 15:29:08 2021 -0700
Stress test usability feedback (#18513)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 2274b28287bc67bf8c0c26a7cdde6a3c7857af7c
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Nov 3 14:46:40 2021 -0700
[KeyVault] - A failed sample should fail the build (#18516)
## What
- Exit with a non-zero status code if any samples fail to run
## Why
A recent service change caused one of our samples to start failing but I was not
aware of it since we only print the exception and continue. Changing this to
ensure all samples exit unsuccessfully when there's an error ensures we are
notified and are aware of any issues.
Resolves #18101
commit 639f54a4103d2e2416c3a8e2319ef651dda7a564
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Wed Nov 3 14:24:25 2021 -0700
Update remaining beta dependencies on identity (#18472)
Related to #14581
A few cases of beta dependencies were missed in #18470 as they were not pinned as expected. This PR covers these cases and updates the Identity dependencies to use the GA versions
commit 28a91627d5e60e85747a6be8ca263afac8944351
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Nov 3 13:50:19 2021 -0700
[KeyVault] - Update changelog for release (#18510)
commit a097f10166c162dae4ca68638e642a9e3b11b9c7
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Wed Nov 3 12:49:55 2021 -0700
[core-client-rest] Addressing feedback from ArchBoard (#18478)
* Multiple media type handling
* Add Template for path
* update api-extractor
* Add comments to Resource interface
* Revert path type changes
* Add comment about path type
* Omit lint check for Function type
* rebase main
* Revert confidential-ledger dependency bump
commit d85d19a0a35104697ac13761d04aae498cd68652
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Wed Nov 3 12:49:30 2021 -0700
[core-rest-pipeline] Allow specifying any status response to get stream (#18492)
* Add responseAsStream to PipelineRequest
* Use Number.POSITIVE_INFINITY to indicate that any status code should get raw response
* Remove unneeded property in client request and address comments
* Update changelog
commit 416b79b87887d2ca0c268b0643437fc56c4052e5
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Nov 3 11:24:40 2021 -0700
[KeyVault] - Update duration sample and doc comments (#18508)
## What
- Use Day.js in the Key Rotation sample
- Update the doc comments for Key Rotation
## Why
We discussed adding updating the API of Key Rotation to take an object instead
of a raw string for ISO8601 durations; however, with Temporal adding support for
Durations we want to avoid duplicating the type for now. Instead, we decided to
demonstrate interop with an existing 3rd party library. I chose Day.js for this
sample as it has a nice clean API.
commit 5db226aafef1ef077d2b239836dfab09513fc45e
Author: Ziheng Zhou(MSFT) <v-zihz@microsoft.com>
Date: Thu Nov 4 02:00:26 2021 +0800
Update key vault keys to enable live testing in sovereign clouds for multiple services (#18431)
* update test.yml to manage HSM test in multiple clouds
* update tests.yml
* update tests.yml
* update tests.yml
* update tests.yml
commit aa7ada5ba8aaed695159a44c309ec8f1480c2561
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Nov 3 15:21:48 2021 +0800
update-identity-for-track2 (#18482)
commit 591adb420f83e9b24edb92e453b66ec1df405551
Author: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Date: Wed Nov 3 14:41:37 2021 +0800
Make core rest client work with null and encoding (#18381)
* make core rest client work with null and add encoding options
* adding test
* adding test
* use enableUrlEncoding instead
* change to skipUrlEncoding
* add change log
* update dependencies
* upate format
* update according comments
* update format
* change back dependencies
* update pnpm-lock
* resolve ci failure
commit 8d46ea0b169e3e8cfdf0c45f038d88f21c6ad0ea
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 2 23:05:29 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2053 (#18501)
* Changing inline bash for stress test resource deployment
* PR-mod
* pr-mod
* pr-mod
* pr-mod
Co-authored-by: Albert Cheng <albertcheng@microsoft.com>
commit 57cb538bedead0ce555ca7081a0079cb88d9ca57
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Tue Nov 2 16:26:05 2021 -0700
Fix broken links (#18497)
Resolves #18488
Fixes the broken links found in #18488
commit 06266dd4198f943f566c103983b8640f84cf511f
Author: Liangying.Wei <lianwei@microsoft.com>
Date: Wed Nov 3 07:15:00 2021 +0800
Fix issue that the preflight response should hide server detail (#18490)
commit 35820fe0a646ed32f3d3152520d0360d17c12511
Author: Liangying.Wei <lianwei@microsoft.com>
Date: Wed Nov 3 07:14:21 2021 +0800
Update readme to include more examples (#18459)
commit 5d15bfbec5a02e5fdc39bf57abe8f423b9e1f459
Author: Will Temple <witemple@microsoft.com>
Date: Tue Nov 2 16:43:37 2021 -0400
[ai-form-recognizer] Use pipeline to GET Operation-Location (#18495)
commit b81bf006fbf8e8c521bc3d22a9bb1767a06ca223
Author: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com>
Date: Tue Nov 2 13:39:28 2021 -0700
add ReplaceLatestEntryTitle parameter for updating changelog (#18427)
commit 6b1d8df366d5b1ef621e680938468a8443e92fee
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 2 12:54:27 2021 -0700
Post release automated changes for azure-ai-text-analytics (#18494)
commit c91dd8344cc440d21f061fa3f50799b4eea2eb90
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Tue Nov 2 11:59:20 2021 -0700
[core-http] prepare CHANGELOG for 2021 November release (#18491)
Update date and bug fix entries.
commit 446eed1f66330c4ced6c4bd5738d9e060a1ac14c
Author: Liangying.Wei <lianwei@microsoft.com>
Date: Wed Nov 3 00:59:07 2021 +0800
[Web Pubsub Express] Preparing for beta.4 release (#18417)
commit 60b814fdced36ba384ac2d5bad00d6457eac8bab
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Tue Nov 2 12:32:24 2021 -0400
[Text Analytics] Prepare v5.2.0-beta.2 release (#18489)
commit bb82821ae807bc0ed246e2909ad914a2527fe31d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 2 01:41:04 2021 -0700
Post release automated changes for network releases (#18485)
Post release automated changes for azure-arm-network
commit 9762ea3cc1ec0964c56d820dfdde2e1a78d7da82
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Nov 2 16:12:05 2021 +0800
streamanalytics-track2 (#18484)
commit 45d2a921a16887a20039b537fe794b2d3b531c9f
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Nov 2 15:07:43 2021 +0800
network-track2 (#18483)
commit 226578f577ec62d3dbc0211d31e2ff3b656715cc
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 23:04:19 2021 -0700
Use docker to do package validation. (#18479)
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
commit c29b7b1f0e13f0934614a6ed0dd48a3f1e54e27c
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Nov 2 11:16:52 2021 +0800
quota-track2 (#18453)
* quota-track2
* update
* update
commit 1fa2da5e2dfeec384772e79571544cc7b7930966
Author: Liangying.Wei <lianwei@microsoft.com>
Date: Tue Nov 2 11:12:49 2021 +0800
Fix group interface missing closeAllConnections issue (#18461)
Fix https://github.com/Azure/azure-webpubsub/issues/284
commit 2986154ca6fad9c5330f9895679adb77f904ed00
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 18:38:04 2021 -0700
Use https for sparse checkout command (#18475)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 727b2e00fc3a67e265b938caf369aa43e2c84ca5
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Mon Nov 1 16:41:57 2021 -0700
Remove dependency overrides for Identity (#18474)
Related to #14581
In https://github.com/Azure/azure-sdk-for-js/pull/18463, we updated all samples to use GA of Identity v2
In https://github.com/Azure/azure-sdk-for-js/pull/18470, we updated devDependencies of Identity v2 beta to use Identity v2 GA
This PR removes the dependency overrides put in place for the reason (am guessing) that we wanted tests to use the beta v2 Identity, but not samples
Now that the samples are using v2, we no longer need the dependency overrides
commit ae6b6e32852f35e3464d30a44fb616d74b84b76d
Author: Jonathan Cárdenas <JonathanCrd@users.noreply.github.com>
Date: Mon Nov 1 16:10:34 2021 -0700
Remove generate:client script (#18473)
commit d01c64db48b72e43a759dd6e6af71ca619350782
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 15:31:41 2021 -0700
Automatic rush update --full (#18458)
commit 8f40cf08d905c2a154f08baa13c3e2538ee18f66
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Mon Nov 1 15:31:25 2021 -0700
Move Identity dependency from v2 beta to v2 GA (#18470)
commit 290a6e4d6627083535d5fe2a7d429cc04e2d2293
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Mon Nov 1 15:15:54 2021 -0700
Update all samples to use Identity v2 (#18463)
commit 583150dca1ed7ae1ebd5e3f74b48047d489510cb
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Mon Nov 1 17:28:25 2021 -0400
[Batch] Export all types (#18469)
* [Batch] Export all types
* bump version
commit 980fe28689c3d90fea8c3f200acc6bb8d3d2b001
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 13:40:59 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2177 (#18464)
* Create an issue template
* rename the function
* Add description
* Update eng/common/scripts/Invoke-GitHubAPI.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
commit 0a2d9493db245f58cf6ea5e4013d58aa0af18003
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Mon Nov 1 16:40:08 2021 -0400
[Identity] OBO sample improvement (#18330)
Nikitha Udaykumar has been helping me test the OnBehalfOfCredential, and through her feedback, I am making this PR to improve our related samples.
Feedback appreciated 🙏
commit 5eb0b5c4aa20f13f5dbe9d10f11e4ee51303a5bd
Author: Jonathan Cárdenas <JonathanCrd@users.noreply.github.com>
Date: Mon Nov 1 13:25:24 2021 -0700
Standardize autorest command (#18398)
* Standardized command
* Re-adding formatting command
commit c884a809c2a274aff4a0ca3d2098574ffabe1748
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 10:33:21 2021 -0700
Post release automated changes for azure-video-analyzer-edge (#18450)
commit 94e2030864ab783db2b84b05a830dae9e29136ce
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Mon Nov 1 10:24:16 2021 -0700
Add entry for video-analyzer-edge in code owners file (#18446)
commit 1e92624e820229ee01c2443e7841027fc1c7bf6d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 02:27:20 2021 -0700
Post release automated changes for notificationhubs releases (#18457)
Post release automated changes for azure-arm-notificationhubs
commit 317c3ed9dea8d9fb34bef3e848c1e5d08606979a
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 01:53:32 2021 -0700
Post release automated changes for azure-arm-videoanalyzer (#18454)
commit ce1a9767820eaeb76dc70ba9e3cf913f36f2c2d2
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 01:52:51 2021 -0700
Post release automated changes for azure-arm-databricks (#18452)
commit 439754c657bd133d1fd9e7524a95504781c5e1db
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Nov 1 16:50:29 2021 +0800
notificationhubs-track2 (#18456)
commit 4967ac6c038bb2edf689415cd978b2df9796edd2
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Nov 1 11:16:34 2021 +0800
videoanalyzer-track2 (#18391)
* videoanalyzer-track2
* update
commit 429c7a027a0d191fc2e5adc3ff2d1b055257d075
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Nov 1 10:13:56 2021 +0800
databricks-track2 (#18441)
commit b02acd2c3e6f83892f525b97799f71baf8871b5a
Author: hivyas <61890270+hivyas@users.noreply.github.com>
Date: Fri Oct 29 15:48:25 2021 -0700
[AVA] Updated package to 1.1, moved to v2 samples flow, moved to core-rest-pipeline (#18425)
* updated package to 1.1
* updating table in readme
* fixing product slugs
* updating slugs and test
* updating slugs
* changing slugs
* fixing formatting
commit cc8130b6e8b86e8abe0d4e7fab3a8dd651b1a9f8
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Fri Oct 29 14:46:41 2021 -0700
Remove Node.js 10 from test matrix (#18403)
* Remove Node.js 10 from test matrix
* Fix text that has node version
commit ec1462c9daa90f375068d07f1c224670c3707dfd
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Fri Oct 29 15:42:56 2021 -0400
[Text Analytics] Add links to Custom Text service docs (#18424)
* [Text Analytics] Add links to Custom Text service docs
* address feedback
commit 8316621389116184a2ac8934e4c05ff57c397498
Author: Mike Harder <mharder@microsoft.com>
Date: Fri Oct 29 11:36:38 2021 -0700
Update rush and pnpm (#18422)
commit 1c9b3d53d1f782451544e7fc9205bd9462554e20
Author: Timo van Veenendaal <timov@microsoft.com>
Date: Fri Oct 29 10:29:57 2021 -0700
[Perf Framework] Add elapsed time column to snapshot log (#18353)
Resolves #12778
commit a528eb82e0d1dc005df5968e116da1d7d52d4572
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Fri Oct 29 10:33:50 2021 -0400
[core-client] authorizeRequestOnClaimChallenge (#17315)
Not so long ago, Python exposed an `ARMChallengeAuthenticationPolicy ` and integrated it to their management core: https://github.com/Azure/autorest.python/pull/992 — this policy adds support for the CAE challenges on the management plane clients. While we haven’t heard of an exact date when this is going to be scoped for JS, we’ve been preparing for this moment for a while, so for us to stay up to date, it should be pretty simple.
This new `ARMChallengeAuthenticationPolicy` policy on Python’s source code can be seen here: https://github.com/Azure/azure-sdk-for-python/blob/9502e669e59e172a9d3d20586ba9761a64e23266/sdk/core/azure-mgmt-core/azure/mgmt/core/policies/_authentication.py — It essentially is the test code that we had in the `bearerTokenAuthenticationPolicy` tests that helped us verify the behavior of the challenge callbacks.
To solve for the same scenario, and after feedback on my initial implementations, I’m adding a new public method on the @azure/core-client called `authorizeRequestOnClaimChallenge`, which can be used as the `authorizeRequestOnChallenge` challenge callback on the `bearerTokenAuthenticationPolicy`. Once this is merged, the code generator for the ARM clients will need to change with something similar to:
```ts
import { bearerTokenAuthenticationPolicy } from "@azure/core-rest-pipeline";
import { authorizeRequestOnClaimChallenge } from "@azure/core-client";
const bearerTokenAuthenticationPolicy = bearerTokenAuthenticationPolicy({
authorizeRequestOnChallenge: authorizeRequestOnClaimChallenge
});
```
If approved (eventually):
Fixes #17386
How does this look? Any feedback appreciated.
commit dcada467f1f50f832230d85177918b69b12ebd90
Author: Aigerim <aykobb@gmail.com>
Date: Fri Oct 29 14:20:13 2021 +0200
the release date of 1.1.0-beta.1 is changed (#18443)
Co-authored-by: Aigerim Beishenbekova <aigerimb@DESKTOP-PIOH0CF.corp.microsoft.com>
commit 40d6a207dd84b0bfc06652fbb4d4bfd1f4a7b5d3
Author: Aigerim <aykobb@gmail.com>
Date: Fri Oct 29 09:19:21 2021 +0200
release date for 1.1.0-beta.1 updated in changelog (#18439)
Co-authored-by: Aigerim Beishenbekova <aigerimb@DESKTOP-H8RSQNI.corp.microsoft.com>
commit b2905c4c165cd852a88ed437b6bdfc4482de923d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 28 23:09:21 2021 -0700
Post release automated changes for azure-arm-resources-subscriptions (#18284)
commit 400f2475fecbf0a1b05fac5bc32b288167066dc8
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 28 23:05:55 2021 -0700
Post release automated changes for mediaservices releases (#18435)
Post release automated changes for azure-arm-mediaservices
commit 1bcb938c7f52d46a88b02edbf2a655f54516c6b6
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Fri Oct 29 12:05:23 2021 +0800
mediaservices-release (#18430)
commit fe42f31724d6e296f672f66a195d972dba00c633
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 28 18:59:08 2021 -0700
Post release automated changes for azure-arm-operations (#18413)
commit 61adb7df2677ef49b636e83a0fbffab3a9beebf5
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 28 18:55:58 2021 -0700
Post release automated changes for appplatform releases (#18383)
Post release automated changes for azure-arm-appplatform
commit dc04bbeb549432eb30f47e11771f86fd473a8f82
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Fri Oct 29 09:42:58 2021 +0800
mediaservices-track2 (#18415)
* mediaservices-track2
* update
commit d5fe48454ff3d0b79181d94665991cf65a03704a
Author: Jonathan Cárdenas <JonathanCrd@users.noreply.github.com>
Date: Thu Oct 28 13:50:12 2021 -0700
Increase timeout from 15 to 30 minutes (#18107)
commit 14a8a4e2109c3eefcf8517d1fc06523e88ec2422
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Thu Oct 28 13:39:21 2021 -0700
[Event Hubs] Add changelog entries for beta release (#18407)
Our upcoming November release for Event Hubs will be a beta release. This PR
- updates the package version to use beta
- adds changelog entries that were missed before
commit 10f96dd79192e6f05acd2677552ae7f94f98243d
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Thu Oct 28 13:14:46 2021 -0400
[Text Analytics] Expose response's action name (#18410)
* [Text Analytics] Expose response's action name
* add changelog entry
commit b6fed8ba7fc73196727dd0a6c745b2a153347f31
Author: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com>
Date: Fri Oct 29 02:06:21 2021 +0900
Typo "Typescript"→"TypeScript" (#18416)
https://docs.microsoft.com/en-us/javascript/api/overview/azure/event-hubs-readme?view=azure-node-latest
#PingMSFTDocs
commit a00d576c976210ef4b32f9ab0c80fd144ec7d417
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 28 09:35:45 2021 -0700
Post release automated changes for identity releases (#18418)
Post release automated changes for azure-identity
commit b31eb5db38cd07a480096789d70f4da53fdd96ff
Author: Brian Terlson <brian.terlson@microsoft.com>
Date: Thu Oct 28 06:07:40 2021 -0700
[Web Pubsub] Renames per arch board (#18399)
commit 6cf53098c5d619c57b3396f8329c5ed57937b541
Author: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com>
Date: Thu Oct 28 13:39:01 2021 +0800
Fix Schema Registry Readme Issue (#18411)
commit e9c4cd4771d943045b4b8e9ab48ab7820c2ae7ee
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Thu Oct 28 13:18:33 2021 +0800
operations-track2 (#18394)
commit 6ebc5a2bec38487aab357d0299fb6243878861cf
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Wed Oct 27 20:15:02 2021 -0700
Prepare identity release 2.0.1 - update changelog date (#18408)
Prepare identity release 2.0.1 - update changelog date
commit bd0bca68374757b12453522e12ead0fbfc0fb977
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Wed Oct 27 22:20:57 2021 -0400
[Text Analytics] Allow multiple actions of the same type (#18382)
* [Text Analytics] Allow multiple actions of the same type
* address feedback
* remove onlys
commit 8fcdbfec40ce51cda3d79b03fcc6f70522b085f7
Author: marcodalessandro <madales@microsoft.com>
Date: Wed Oct 27 17:03:08 2021 -0700
[@azure/event-hubs] Adding `disableDeserialization` option when subscribing (#18173)
commit f8a3be788a877b316257766f1be391d2a7d5175e
Author: Timo van Veenendaal <timov@microsoft.com>
Date: Wed Oct 27 16:41:18 2021 -0700
[Perf Framework] Print dependencies on perf test start (#18366)
Resolves #13825.
commit 31e9c3a85aced397be3400f33dc4ba27416e029c
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Oct 27 14:21:26 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2152 (#18377)
* Remove the new sdk check and populate json for track 1 package
* Update Save-Package-Properties.ps1
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
commit 34ba5441dba817cccd115d7a10b6f05006ddb6c5
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Oct 27 10:53:06 2021 -0700
[KeyVault] - Fix sovereign cloud tests (#18350)
## What
- Suppress key rotation tests in sovereign clouds
- Ensure AZURE_AUTHORITY_HOST env var is passed to the credential in tests
- Suppress premium SKU tests when KV is not premium
## Why
These are added to support sovereign cloud testing.
The first is a must for us as key rotation is simply not available in all
clouds yet as a preview feature. We still want to test this feature in public cloud though so suppressing it in government
clouds is a reasonable approach.
The second is necessary to authenticate correctly in different authorities.
Finally, the third is a must as premium SKU is not available everywhere.
Fixes #18142
Partially Fixes #18267
Fixes #18189
commit 4386511b29a6327188c4013e3bfbe74bcea4aa98
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Oct 27 02:45:33 2021 -0700
Post release automated changes for containerservice releases (#18393)
Post release automated changes for azure-arm-containerservice
commit 005e39c1522e9de9e0e2a54d415f1163b1d2c35a
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Oct 27 16:31:38 2021 +0800
containerservice-tack2 (#18385)
* containerservice-tack2
* update
commit 518dc805cdaee4cfc1e6a0992841fbcc11f5d77c
Author: Liangying.Wei <lianwei@microsoft.com>
Date: Wed Oct 27 14:52:07 2021 +0800
Reuse azure logger and move endpoint setting into options (#18359)
commit f2a1e3802be3606571c6150f64a11ab799c2a2f7
Author: Petr Švihlík <rocky.intel@gmail.com>
Date: Wed Oct 27 08:26:19 2021 +0200
fixed method name as per the azure board review (#18378)
commit 65832ba81838f40a2c89347de19fd7811d369d12
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Oct 27 11:35:10 2021 +0800
appplatform-track2 (#18380)
* appplatform-track2
* update
* update
commit 625589cdbf2da3052e2ea84f6386829b16f6862d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Oct 26 19:18:02 2021 -0700
Post release automated changes for azure-arm-recoveryservices (#18361)
commit 90a62556e63878aaa2eff25b7f539035c8fe1c88
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Tue Oct 26 15:53:14 2021 -0700
[Samples] update communication and app-config samples (#18362)
commit 6e6fb6aedef5eac0eb646601bbaa3f428555827b
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Tue Oct 26 15:37:15 2021 -0700
[App Config] Better error message for AppConfigClient with invalid connection strings (#18356)
* better error message for AppConfigClient
* changelog
* (connectionStringOrEndpoint || "").match
* connectionStringOrEndpoint?.match
commit b4d48e45788af3ddcc04188a01d33a3ca00647d9
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Tue Oct 26 18:28:47 2021 -0400
[Text Analytics] Merging feature branch for v5.2-beta.2 to main (#18355)
* [Text Analytics] Regenerate using v3.2-preview.2 swagger (#17026)
* [Text Analytics] Regenerate using v3.2-preview.2 swagger
* regenerate with latest version
* [Text Analytics] Support Custom Text (#17128)
* [Text Analytics] Support Custom Text
* update readme and compile new actions
* export ClassificationResult
* edit
* edit
* edit
* [Text Analytics] Make project and deployment names required (#17402)
* [Text Analytics] Add tests for Custom Text (#17756)
* [Text Analytics] Add tests for Custom Text
* update
* remove only
* [Text Analytics] Refine proposed API View (#17794)
* [Text Analytics] Refine proposed API View
* update changelog
* [Text Analytics] address archboard feedback (#18131)
* address archboard feedback
* Update sdk/textanalytics/ai-text-analytics/src/multiCategoryClassifyResult.ts
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
* [Text Analytics] Add samples for Custom Text (#17822)
* [Text Analytics] Add samples for Custom Text
* edit summary
* Update sdk/textanalytics/ai-text-analytics/samples-dev/customText.ts
Co-authored-by: Will Temple <witemple@microsoft.com>
* revert samples
* unpublish
Co-authored-by: Will Temple <witemple@microsoft.com>
* [Text Analytics] Use persistent CI resource
* fix typo
* address feedback
* fix typo
* [Text Analytics] Fix Preview.2 samples (#18257)
* [Text Analytics] Re-record all tests (#18354)
* address feedback
* update swagger link
* edit
* fix recordings
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Will Temple <witemple@microsoft.com>
commit 93fa1009693546f984c2402be29a8f8a5e45ef47
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Oct 26 14:10:51 2021 -0700
Add latest released version to prepare prerelease (#18373)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit d60fc1fec39e288677deed776740a72db5312df1
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Tue Oct 26 10:56:10 2021 -0700
[core-http] HttpHeaders.clone() should keep raw header name casing (#18348)
Original header names are still available in the values of
`_headersMap` and in the result of `headersArray()`. However we
currently initialize the clone using `this.rawHeaders()` which returns
an object with lower-cased keys thus the original raw header names
are lost.
When cloning HttpHeaders, we should use the original header names in
the clone instead.
commit 4c16af6eb4ffeaadba734ae15beed771b17bed2b
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Tue Oct 26 13:13:21 2021 -0400
[Text Analytics] Delete unused URL parsing helper (#18357)
commit 730ee58d708261b224f070109c35e38355d05654
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Oct 26 12:09:10 2021 +0800
recoveryservices-track2 (#18342)
commit 6140e810bb0bde5338b285e3e772b8ef1c7ba608
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 25 17:05:57 2021 -0700
Post release automated changes for core releases (#18358)
Post release automated changes for azure-core-client
commit 79aa07f77706c8d669930837ca332fa317230f54
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Mon Oct 25 18:59:12 2021 -0400
[core-client] Prepare v1.3.2 release (#18352)
commit 79bbf95efef8f97fba54fca2e5ed617d94278fcf
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Mon Oct 25 14:51:17 2021 -0700
[KeyVault] - Use 7.3-preview for certificates and secrets (#18346)
commit e662d41605a5869a3e553c89b9e1d74fa2417f72
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 25 13:55:05 2021 -0700
Automatic rush update --full (#18343)
commit 739a68bfcea8723fb44ab4bb3079d532a3f58952
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 25 13:52:33 2021 -0700
Post release automated changes for azure-arm-containerregistry (#18303)
commit be355116959ffb72bedb5c62fb41f1cf85d0b765
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Mon Oct 25 13:01:48 2021 -0700
[KeyVault] - Add missing lib:dom reference (#18344)
## What
- Add lib: dom entry to keyvault-secrets tsconfig
- Add lib: dom entry to keyvault-admin tsconfig
- Remove dom.d.ts from keyvault-common
## Why
During min/max testing we found that the dom.d.ts file doesn't actually help
when keyvault-common is bundled in with the rest of the source files. The other
keyvault packages are already including lib: dom which is why things worked fine
for them.
The solution here is to just add lib: dom to kv-secrets to match the other kv
packages.
While not strictly necessary yet I did add it to keyvault-admin as well because
it'll surely come up once MHSM deployments resume correctly.
commit c2c723ddafca39dca375a7f8b36af16ed03e9fe3
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date: Mon Oct 25 14:23:58 2021 -0400
Identity alpha build is failing with missing test-utils dependency (#18345)
commit ce466e54362b95d9507412f0e943cf93ceb437fd
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Sun Oct 24 21:40:14 2021 -0700
Post release automated changes for azure-arm-logic (#18337)
commit f1068b17a6e16219b870e9eb661862ccbca6de42
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Oct 25 10:37:54 2021 +0800
logic-track2 (#18313)
commit 7a7d99d271f62aef320963d26bab76b4dea50afc
Author: Timo van Veenendaal <me@timo.nz>
Date: Fri Oct 22 23:05:56 2021 -0700
[Perf Framework] rename perfstress to perf and runAsync to run (#18290)
Reported in #18033.
Basically did a bulk find+replace everywhere. Things _seem_ to be working OK, but wouldn't be surprised if there's something somewhere I've missed, or somewhere where I've replaced something I shouldn't.
I've split the rename of PerfStress -> Perf and runAsync -> run into two commits for ease of review :)
commit 58beb3e7d18650c5d961c5099e2519f58a963d99
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 22 15:07:27 2021 -0700
Fully automate cluster buildout. Add azure file share mount to stress tests. (#18327)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 04c45d14c8a2b531a4f869c355b76b2fd260af22
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Fri Oct 22 17:42:56 2021 -0400
[Identity] Re-enabling the Service Fabric MSI (#17579)
* [Identity] Re-enabling the Service Fabric MSI
* Update managedIdentityCredential.spec.ts
* CHANGELOG entry
* Update fabricMsi.ts
* Update fabricMsi.ts
commit a00a662e3f50f4b4d45bee634d41932996c49459
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Fri Oct 22 16:18:12 2021 -0400
[core-client] Skip parameter overwriting if the path is absolute (#18310)
* Skip parameter overwriting if the path is absolute
* add a comment
* update changelog
* update TA recordings
* address feedback
commit f26bb90567e828fca5d01172ae6d020f141b2432
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Fri Oct 22 13:13:56 2021 -0700
[KeyVault] - Address archboard review feedback (#18319)
## What
- return bytes from getRandomBytes
- rename KeyReleasePolicy.data to KeyReleasePolicy.encodedPolicy
- rename target to targetAttestationToken
## Why
These address recent architecture board review comments and will improve the
overall experience when using these new APIs.
Resolves #18307
Resolves #18317
commit 66a7eb4544df757e803d487a1bc8be7a5e3314d4
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Fri Oct 22 15:44:26 2021 -0400
Revert "[Identity] Pointing to troubleshooting guide on more credentials (#18296)" (#18311)
This reverts commit d75512a573757a7cfa1a774b27d635f714d0e168.
commit d79c90f49312851d798de610d3c0eb481b66e25c
Author: Andrej Kyselica <andrej@kyselica.com>
Date: Fri Oct 22 14:55:03 2021 -0400
fix nested code quote (#18318)
commit 1c04b202f507af6297d00318aa06f9663f15108e
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Fri Oct 22 08:40:07 2021 -0700
Revert "[KeyVault] - Add key_ops to JWK and deprecate keyOps (#17914)" (#18314)
This reverts commit 0ad4ea3cd1128d908dae2ef0a902f4a7c1177a9f.
We decided not to take this change in - the reasons are:
1. Currently there's no _clean_ way to prevent modeler4 from normalizing a name. That is tracked in https://github.com/Azure/autorest.typescript/issues/1211 but the swagger transform is messy at this point
2. Originally I had applied the transformation in code when deserializing a JWK from the server; however, I forgot there's also the importKey operation
3. While a customer did ask for this in dotnet, nobody has asked for this in JS so there's a lot of risk for very little customer benefit
commit 0a3dd1580b444d88eb9d9fbaafb6ecf0882211aa
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Fri Oct 22 08:21:44 2021 -0700
[KeyVault] - Move dom reference to dts file (#18315)
In order to work around a known typing issue when using the global URL, we added
a reference comment in source code.
This PR just moves that declaration to a separate dts file in order to stay
consistent with how we're doing it in other packages.
commit c52e8a2d207c2197b28b56d1b13c07b754203b6b
Author: Petr Švihlík <rocky.intel@gmail.com>
Date: Fri Oct 22 09:12:35 2021 +0200
Renamed exchangeTeamsToken to exchangeTeamsUserAadToken (#18306)
* exchangeTeamsToken to exchangeTeamsUserAadToken
commit 4cc59c0b2f56f7a8e119b2f45d077d4e0c87a192
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Thu Oct 21 22:40:16 2021 -0700
[Service Bus] ATOM API - Make service version configurable (#18254)
* ServiceBusAtomAPIVersion
* older API Version is broken
* tests
* rename
* changelog
* getRandomServiceVersion
* remove .only
* address Jeremy's feedback
* serviceVersion comments
* docs
* test with both the api versions
* Donot expose ServiceBusAtomAPIVersion
* test
* doc update
commit 88791cd070e4e105ea5d1e82beac54e4a5acbf7c
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Thu Oct 21 17:54:32 2021 -0700
[Unified Recorder] AddSanitizer (#17379)
* connection string sanitizer
* removeHeaderSanitizer
* add server
* rename as unit tests
* update integration test commands
* lock file
* sanitizer tests
* lock file
* del;ete sanitizer test file
* build failures
* sanitizer starter tests
* export setEnvironmentVariables from recorder
* sanitizer and related changes
* pass client.start param
* recorder.start takes options
* update karma.conf
* core-v1 and core-v2 tests with sanitizer
* recordings
* remnove console.log
* getRealAndFakePairs rename
* session file not needed
* doc comment
* temp-commands
* sanitizer APIs
* add more routes to the server
* lock file
* tests with the local server
* node recordings
* browser counterparts
* echo skipped
* comment out
* UriRegexSanitizer
* UriSubscriptionIdSanitizer
* continuationSanitizer
* headerRegexSanitizers
* Codespaces
* UriRegexSanitizer
* simplify UriRegexSanitizer test
* UriSubscriptionIdSanitizer
* recordigns
* lock file
* unneeded commented code
* ResetSanitizer did not work as expected
* groupForReplace and transformsInfo
* adding sanitizer to start method
* recordings
* some docs and handleEnvSetupForPlayback
* lock file
* docs
* changelog
* changelog
* comments
* Daniel's feedback
* lock file
* ProxyToolSanitizers, sanitizerKeywordMapping
* refactor
* add comment
* more docs
* test-proxy starter code for starting
* Revert "test-proxy starter code for starting"
This reverts commit 49a2d6816a901b04fe3d9669923c8b9e58fe72a2.
* Jeremy's and Daniels's feedback
* part feedback from Will
* mistype
* exclude Exclude from Exclude<T, undefined> to not have Exclude
* Simplify getKeyValuePair method
* getConnStringAsJSON
Co-authored-by: Codespaces <codespaces@github.com>
commit f975db12027cafeb27c60d3db56409c219c81bec
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Thu Oct 21 15:46:45 2021 -0700
[ContainerRegistry] support passing service version via client options (#18067)
This PR adds an optional `serviceVersion` proeprty to `ContainerRegistryClientOptions`.
commit 27d81495f905a24a9f82ec3a152073e05729657d
Author: Dina Berry <41597107+diberry@users.noreply.github.com>
Date: Thu Oct 21 10:17:25 2021 -0700
Fix minor typo (#18293)
commit 49cebf06eb430cee3a6cc31fca75b629e02d4eda
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Thu Oct 21 09:55:01 2021 +0800
containerregistry-track2 (#18285)
commit d75512a573757a7cfa1a774b27d635f714d0e168
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Wed Oct 20 21:09:02 2021 -0400
[Identity] Pointing to troubleshooting guide on more credentials (#18296)
* added the troubleshooting guide to the credentials that use MSAL
* CHANGELOG
commit 0ca3320c72864919350d7af2a67c97843d78e150
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Wed Oct 20 16:57:42 2021 -0700
[ContainerRegistry] Remove browser related docs (#17717)
* [ContainerRegistry] Remove browser related docs
as the service doesn't support configuring CORS settings, which make it not
possible to use in a secure browser environment.
* Link to CORS consideration doc
commit ef42711ac167b15af2e0898183c7cba4b3b91b30
Author: Brian Terlson <brian.terlson@microsoft.com>
Date: Wed Oct 20 16:13:52 2021 -0700
[Web-Pubsub] Update to latest API version, support DAC, support APIM (#17134)
commit 72aff0fe90a9e976cf6057aa541a663b86f604f7
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Oct 20 12:08:01 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2093 (#18288)
* Consume Codeowners parser library, ceperate users from teams in codeownerse
* Update get-pr-owners and related logic
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit 08ce4b0eed073a122d803afcfbcdf0d551d9280f
Author: Petr Švihlík <rocky.intel@gmail.com>
Date: Wed Oct 20 09:57:02 2021 +0200
Added Public Preview API version for the Custom Teams Endpoint (#18271)
* Added Public Preview API version for Custom Teams Endpoint
* Updated readme, samples, changelog
* Added a test for expired token and empty token
* Fixed tests for exchangeTeamsToken
* Updated test recordings
commit 2177931d55fecce4e59e0a1d7f2dc67b4107f8dc
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Oct 20 15:19:56 2021 +0800
update (#18281)
commit 35161af18387dd7a6ac14b04254444e795ef488e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Oct 19 20:18:24 2021 -0700
Post release automated changes for postgresql releases (#18280)
Post release automated changes for azure-arm-postgresql
commit 6120a0a69fee75d0874ab5a37ba89120daa5a003
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Oct 20 11:08:14 2021 +0800
Update package.json for subscriptions (#18279)
* update-package.json-for-subscriptions
* update-package.json-for-subscriptions
commit 92e46cb57b17b24989bcf4d6d0fa96e0d171eb58
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Oct 20 10:26:55 2021 +0800
postgresql-track2 (#18263)
* postgresql-track2
* update
commit 6144868b30a5d9d4243fb7f9ba08707d25b5b55b
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Oct 19 19:19:59 2021 -0400
[Identity] Fix Azure CLI Credential on Windows (#18275)
Some time ago, a security change was made on the Azure CLI credential that changed the `exec` call to `execFile` for `az` calls, here: https://github.com/Azure/azure-sdk-for-js/pull/14408. This PR moved from Node.js’s `child_process.exec()` to `child_process.execFile()`. That change however didn’t take in consideration that `exec` would run commands in a shell and `execFile` would not. Turns out that, on Windows, the Azure CLI `az` is not a program Windows can find without a shell. For the longest time, whenever I saw this error, it seemed like an environment issue and not a real bug. Thanks to this customer issue: https://github.com/Azure/azure-sdk-for-js/issues/18268 things finally clicked.
This PR ensures that the AzureCLICredential calls to the `az` program within a shell.
Note: v1 doesn’t have this problem because it still uses `exec`: https://github.com/Azure/azure-sdk-for-js/blob/hotfix/identity_1.5.2/sdk/identity/identity/src/credentials/azureCliCredential.ts#L42
Feedback always appreciated 🙏
commit 48ebdfbf8a221969d9c2300aeb9e93fb0ad3074e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Oct 19 14:44:55 2021 -0700
update to latest test-proxy tag (#18276)
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
commit 0ac4aac6448ca6ed13f265c5cfb981d511942657
Author: Dina Berry <41597107+diberry@users.noreply.github.com>
Date: Tue Oct 19 11:10:30 2021 -0700
Expose API from App registration, not Enterprise app (#18255)
commit c027e05a7e6ba6539b03ba92e00c06f0a33d2aa1
Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
Date: Tue Oct 19 11:00:31 2021 -0700
Update CHANGELOG.md (#18273)
commit bc96130d1b730c2300ea3bc28419899e7c72c4af
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Oct 19 10:42:04 2021 -0700
Automatic rush update --full (#18247)
commit 0e85c8ea4befd5f7613d067815303ba9e49fed91
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Oct 19 13:41:38 2021 -0400
[Identity Plugins] Increased version to v1.0.1 (#18258)
commit 1e507db7050533e92f8bdf0b7a22310b9c8e3fe4
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 19:53:42 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2085 (#18259)
* Fix up identity resolver to make it more reliable, publish notification configuration as a tool
* Use both username and email to resolve queuing user
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit 6ebc0269c747555163300e7d3e1c63282a2776f6
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 16:11:03 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2100 (#18252)
* Add group id into metadata for java use
* Update Update-DocsMsPackages.ps1
* Update Update-DocsMsPackages.ps1
* Update eng/common/scripts/Update-DocsMsPackages.ps1
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
* Update eng/common/scripts/Update-DocsMsPackages.ps1
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
commit 2ce90510e7f7c580266f3f765d6b4f963767acc8
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 13:31:45 2021 -0700
adjust the docker-start-proxy to take advantage of the linux specific commands that allow contact of localhost (#18250)
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
commit 4e1e77af1586795ece96e16a3e3102ebeb067333
Author: govardhan <27.govardhan@gmail.com>
Date: Tue Oct 19 01:18:34 2021 +0530
updated the cosmosdb doc with correct syntax and return type (#18228)
commit 972059c315512d9d682681e214e68860e50e39ce
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 12:41:06 2021 -0700
Post release automated changes for purview releases (#18187)
* Post release automated changes for azure-rest-purview-scanning
* Fix readme
Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
commit 0163e3cb2873879004ec0ff54355445ee5fcc71d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 12:40:56 2021 -0700
Post release automated changes for purview releases (#18215)
* Post release automated changes for azure-rest-purview-administration
* Fix samples readme
Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
commit 201a7754dadec5babccd3982af6a9b6e6b156611
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Mon Oct 18 12:40:03 2021 -0700
Update Purview owner (#18249)
commit fb1f1a7835db1fc9bf2d6e9e200f3f87cf600165
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 12:39:32 2021 -0700
Post release automated changes for purview releases (#18192)
* Post release automated changes for azure-rest-purview-catalog
* Fix samples readme
Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
commit 0c47584b30fd6b8c9443ce610254dd26d4147ff4
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Mon Oct 18 07:57:05 2021 -0700
[Tables] Multiple small fixes to Tables SDK (#18211)
* Multiple small fixes to Tables SDK
* Remove un-needed changes
* Update sdk/tables/data-tables/README.md
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
* Update sdk/tables/data-tables/README.md
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
* Update sdk/tables/data-tables/src/serialization.ts
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
* Update sdk/tables/data-tables/src/utils/bufferSerializer.ts
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
* bring back base64 encoding
* update sample name
* Fix format and update changelog
* Update sample name
* Remove un-needed re-recordings
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
commit 5215a7d829e63302c0fe5f0b1c90b35ef7945541
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 02:24:37 2021 -0700
Post release automated changes for compute releases (#18244)
Post release automated changes for azure-arm-compute
commit baa70f87320b8fc8c323e147b4ad0f54966aca9e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 01:58:13 2021 -0700
Post release automated changes for policy releases (#18243)
Post release automated changes for azure-arm-policy
commit f4198b6a5517ce284d83704aac6f7250d151cc76
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Oct 18 16:40:24 2021 +0800
compute-track2 (#18239)
* compute-track2
* update
commit 29b628083f4936d068e1548da23b4608f944b007
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Oct 18 14:48:37 2021 +0800
policy-track2 (#18229)
* policy-track2
* update
* update
commit c3b75ee4e29d6cd2008fbd29101769d7012f3793
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 17:57:19 2021 -0700
Post release automated changes for identity releases (#18218)
Post release automated changes for azure-identity
commit 3e965811e6255ff474f5f2974db82ab4073358fc
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Fri Oct 15 14:42:08 2021 -0700
Support manually handling continuationTokens (#18179)
* Support manually handling continuationTokens
* Use PageSettings and update version
* Update samples and page type
* Address PR Comments
* Undo changes to generated samples
* Fix format
commit 6464b0efa4b250685eec5356477cb7d073d2af72
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 13:08:08 2021 -0700
Post release automated changes for synapse releases (#18056)
* Post release automated changes for azure-synapse-spark
* Post release automated changes for azure-synapse-artifacts
commit 850366a7117a76f5c9afa0a453a25d3925a968ae
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Fri Oct 15 12:44:52 2021 -0700
[Purview Administration] Prepare for 1.0.0-beta.1 release (#18212)
* Regenetate with latest api-version and update changelog
* Update changelog
commit 64936d6abd3b4c6160cfe63377ca2c34e5567868
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 11:49:04 2021 -0700
Post release automated changes for monitor releases (#18084)
Post release automated changes for azure-monitor-query
commit 55dc5736f404c5f08f544213eba1bfb2560ac650
Author: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com>
Date: Sat Oct 16 02:15:30 2021 +0800
update to latest (#18144)
commit cdbe548db571b39a7dccff41aa68db736910042f
Author: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com>
Date: Sat Oct 16 02:15:13 2021 +0800
Fix Synapse AccessControl Readme Issue (#18143)
* Fix Synapse AccessControl Readme Issue
* Update run_test.ts
Co-authored-by: Tong Xu (MSFT) <57166602+v-xuto@users.noreply.github.com>
commit 45723afcb83de53ac8e540b73df446e535468da2
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Fri Oct 15 14:15:02 2021 -0400
[Identity] changing the release date (#18213)
We couldn’t release yesterday, but we were able to test the bundles. Let’s get this out today.
commit edb6fb4d757fd7b0e70f837c5520fcb3cae7737a
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 11:04:20 2021 -0700
Post release automated changes for monitor releases (#18053)
Post release automated changes for azure-monitor-opentelemetry-exporter
commit dcc3156e6dedbf7f8627f4c5c12343092f11c6ca
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 11:01:13 2021 -0700
Post release automated changes for azure-arm-apimanagement (#18114)
commit 52f4889c9cfa4152cfdaafde647b9f50f41cd9e9
Author: govardhan <27.govardhan@gmail.com>
Date: Fri Oct 15 23:20:04 2021 +0530
[Cosmos] removing the upsert as a supported feature (#18193)
commit c1f7abf764911c4d5962df24b07c2fc425d0e5d1
Author: Kevin <skiimilk@gmail.com>
Date: Sat Oct 16 01:47:52 2021 +0800
Fix spelling error (#18186)
commit b2d9efe1f9716816c55117313144f059bde73360
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Fri Oct 15 10:43:25 2021 -0700
[KeyVault] - Support multitenant challenge authentication (#18082)
## What
- Parse tenantId from WWW-Authenticate authorization field and pass it to the getToken call when parsing challenges
## Why
Identity will soon add multi-tenant challenge authentication support. It's already supported in `main` today, and will supported
in production soon. On the KeyVault side we just need to pull out the tenant ID from the `authorization` field and pass it in
as part of the `GetTokenOptions` options bag when calling `getToken`. Older Identity clients will ignore this field, but newer
clients will use it as the tenantId.
Resolves #17619
commit 5075150408b4c4d44c97dac9ad5c37ffdd1ab989
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:32:27 2021 -0700
Post release automated changes for azure-arm-eventhub (#18198)
commit e197af8b8b23e7b875fc51d67fcdcf76eb3334a5
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:31:49 2021 -0700
Post release automated changes for azure-arm-compute (#18196)
commit 9da00cc3b186affeaeca0b1575d6e40d34050a86
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:31:40 2021 -0700
Post release automated changes for azure-arm-features (#18200)
commit 798aca894f73385dd678ee12eefcbdcd90db640b
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:31:34 2021 -0700
Post release automated changes for azure-arm-storage (#18207)
commit 5aeee52243b14828fcdb923ace2534d66b323751
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:31:28 2021 -0700
Post release automated changes for azure-arm-policy (#18209)
commit 15e48a44ce509212ea4bcb51fd3d60947a16516e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:07:06 2021 -0700
Post release automated changes for azure-data-tables (#17495)
commit 45c84009f60fc00c1db37211f02203807be22f84
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:18:04 2021 -0700
Post release automated changes for eventgrid releases (#18197)
Post release automated changes for azure-arm-eventgrid
commit 5cb453510c95928e1f7afdcfeb1b78c3b010d272
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:08:38 2021 -0700
Post release automated changes for security releases (#18184)
Post release automated changes for azure-arm-security
commit df175ca0121b32a9322895a52156082bfa63e6db
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:06:45 2021 -0700
Post release automated changes for appservice releases (#18194)
Post release automated changes for azure-arm-appservice
commit 208a20957b7186146fedfc20f54fb11d056ed142
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:05:35 2021 -0700
Post release automated changes for authorization releases (#18195)
Post release automated changes for azure-arm-authorization
commit 3ac3f7e1199c8d44c79c43e7a66fea6994ec8096
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:03:11 2021 -0700
Post release automated changes for keyvault releases (#18199)
Post release automated changes for azure-arm-keyvault
commit 32462c8f6bb00aa98ed7600743f3b5d5cac2a38e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:02:31 2021 -0700
Post release automated changes for locks releases (#18201)
Post release automated changes for azure-arm-locks
commit 843021c32486802eaae14caeb5e9e2c4dbfac90e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:01:44 2021 -0700
Post release automated changes for managedapplications releases (#18202)
Post release automated changes for azure-arm-managedapplications
commit 53275f74504dd11b6a3bdd98e3fc395f5b1f82f9
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:01:11 2021 -0700
Post release automated changes for redis releases (#18203)
Post release automated changes for azure-arm-rediscache
commit fc7cb118f34f8705c667911bf5df23a22f8dd59c
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:00:49 2021 -0700
Post release automated changes for network releases (#18204)
Post release automated changes for azure-arm-network
commit fc18040f18cbb599848c58f10563e4e1ac6f7733
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:00:21 2021 -0700
Post release automated changes for resources releases (#18205)
Post release automated changes for azure-arm-resources
commit b01fc24700710c7e90bff850139aefe247059c5e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 02:59:41 2021 -0700
Post release automated changes for servicebus releases (#18206)
Post release automated changes for azure-arm-servicebus
commit 48bb7d330fa82825e14c605f9f0f9f83e3dfc6af
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 02:59:19 2021 -0700
Post release automated changes for links releases (#18208)
Post release automated changes for azure-arm-links
commit 9baaaf6404bab19631914dcfbf8c47359710fd15
Author: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Date: Fri Oct 15 15:38:30 2021 +0800
update-purview-catalog-version-for-release (#18191)
commit f447a83ca994eaae54b019fc82ce7bfc65c1e197
Author: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Date: Fri Oct 15 14:30:45 2021 +0800
update purview catalog changelog (#18188)
commit 5f2a1c443d3ddfe802d5c25747946ec8890ea80c
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 14 22:56:53 2021 -0700
Post release automated changes for sql releases (#18182)
Post release automated changes for azure-arm-sql
commit 29b72e32940830050b091b25d135ce37951d4ab4
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 14 22:56:33 2021 -0700
Post release automated changes for operationalinsights releases (#18185)
Post release automated changes for azure-arm-operationalinsights
commit d560735e6ae124c83916c16fcdc5a42cd06ad8d0
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Fri Oct 15 10:44:11 2021 +0800
security & operationinsights update (#18180)
* update changelog
* update
commit 67a8c56507ad78067a03042cbf2b3cd7b4b7a166
Author: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Date: Fri Oct 15 10:27:16 2021 +0800
update purview scanning samples (#18154)
* update purview scanning samples
* Update README.md
* remove comment out line
* update samples
* to resolve comments
commit f5ea75af7ef24d663cfa9cc959a42f61fcb3ea53
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Thu Oct 14 17:53:25 2021 -0700
Updates to CodeOwners file for folks no longer with the team (#18178)
commit a89de3847738955633a65ebde9b46d61005f337a
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Thu Oct 14 20:27:35 2021 -0400
[Identity] Spotted a code issue in the OBO sample (#18177)
👷 Better late than never.
commit 8801bdb0cc59edabb6b403d26eace14ba6e6186a
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Thu Oct 14 19:02:19 2021 -0400
plugins to 1.0.0 and specified a release date in the CHANGELOGs (#18176)
commit afbcea7b063f1f5c0511790e9fa8e35b1c217644
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Thu Oct 14 17:54:47 2021 -0400
[Identity] 2.0.0 release date (#18175)
commit a4241d1273d8490e950b0839dd7628134d7c4aa2
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Thu Oct 14 14:11:26 2021 -0400
[Identity] Better names for the InteractiveBrowserCredential options (#18166)
commit 28e3f8058c5ef0423e1136a06fa01f14c8071b57
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date: Thu Oct 14 11:18:59 2021 -0400
Update npm tag setting script to generate new tags based on currently tagged versions (#18165)
commit 9cee4779fa51ab266c9f82c34a9fbb7d38124838
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Thu Oct 14 17:22:11 2021 +0800
operationalinsights-track2 (#18172)
commit 529fcd7b52be3dab1ba63c9cfe67782fbedd5834
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Thu Oct 14 10:56:53 2021 +0800
security-track1 (#18167)
commit ac86a56992d339ce7e337fbc4e282f0b02d30fe3
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Oct 13 10:43:51 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2095 (#18149)
* Mitigate relative path calculation error on multiple iterations
* Revert "Mitigate relative path calculation error on multiple iterations"
This reverts commit 45baedd990c6a3085742a38a4891d8706a93be77.
* GetRelativePath should check if path is already relative before calling [IO.Path]::GetRelativePath
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
commit 0afa58e9a8072a4f9a112b4feb37aabcd988e42f
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Tue Oct 12 19:12:09 2021 -0700
add troubleshooting guide for identity (#17734)
* add troubleshooting guide for identity
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
commit a319c90966f63eb57bd785db65f627c50b96f608
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Oct 12 22:01:34 2021 -0400
[Identity] On Behalf Of sample (#18109)
* [Identity] On Behalf Of sample
* once again, I forgot to remove en-us
* Apply suggestions from code review
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* extra line
* removed old section
* Apply suggestions from code review
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
commit 63be7d208da651c911e5c716cf602ad7081fe003
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Tue Oct 12 18:15:34 2021 -0700
Readme inconsistency (#18098)
commit 80662729cec289223c0e3a5bfa8bdc6bd3040f81
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Oct 12 15:51:28 2021 -0400
[Identity] What if we accepted the PEM certificate string contents? (#18017)
This PR serves to explore the idea of changing the public API of ClientCertificateCredential before we release v2, to allow users to either pass the path to a PEM certificate in the filesystem, or the string certificate contents directly.
.NET allows a similar set of alternatives (with more flexibility on the type of certificates than us): https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs#L96
This could help us provide a better experience for issues similar to #17715
Feedback appreciated 🙏
commit 68fbad61668f1423b76f22509c974e20af607e75
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Oct 12 14:57:34 2021 -0400
[Identity] Removed AzureApplicationCredential from our public API (#18129)
* [Identity] Removed AzureApplicationCredential from our public API
* Apply suggestions from code review
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
commit 1e706fc1369b0ac2b5a064a4a667af54f9f00ae9
Author: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com>
Date: Wed Oct 13 00:23:18 2021 +0900
Typo "Typescript"→"TypeScript" (#18141)
https://docs.microsoft.com/en-us/javascript/api/overview/azure/service-bus-readme?view=azure-node-latest
…
zihzhan-msft
added a commit
that referenced
this pull request
Nov 4, 2021
commit be431bcc1a60f85e2e310e343d3a09a200b94b46
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 3 19:28:00 2021 -0700
Add prompt before replasing latest release title on prepare release run (#18522)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit 74b93c7fb8078de1f309a00447ee617d9a1764ea
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Wed Nov 3 18:14:40 2021 -0700
[Tables] Expose continuation token on TableServiceClient.listTables (#18277)
* Expose continuation token on TableServiceClient.listTables
* Update changelog
commit 73f714dccc053ab1d0534018d27374786c10b571
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 3 17:10:49 2021 -0700
Post release automated changes for azure-core-http (#18519)
commit 848242cd9d84470ec7c4b53a3ad30e16f1f8668b
Author: Ben Broderick Phillips <bebroder@microsoft.com>
Date: Wed Nov 3 18:34:12 2021 -0400
Use working region/subscription for search deployments (#18512)
commit ed6cc1e22b039fa5fbb2bafa3d23e8db73f490ee
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Nov 3 15:29:08 2021 -0700
Stress test usability feedback (#18513)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 2274b28287bc67bf8c0c26a7cdde6a3c7857af7c
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Nov 3 14:46:40 2021 -0700
[KeyVault] - A failed sample should fail the build (#18516)
## What
- Exit with a non-zero status code if any samples fail to run
## Why
A recent service change caused one of our samples to start failing but I was not
aware of it since we only print the exception and continue. Changing this to
ensure all samples exit unsuccessfully when there's an error ensures we are
notified and are aware of any issues.
Resolves #18101
commit 639f54a4103d2e2416c3a8e2319ef651dda7a564
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Wed Nov 3 14:24:25 2021 -0700
Update remaining beta dependencies on identity (#18472)
Related to #14581
A few cases of beta dependencies were missed in #18470 as they were not pinned as expected. This PR covers these cases and updates the Identity dependencies to use the GA versions
commit 28a91627d5e60e85747a6be8ca263afac8944351
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Nov 3 13:50:19 2021 -0700
[KeyVault] - Update changelog for release (#18510)
commit a097f10166c162dae4ca68638e642a9e3b11b9c7
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Wed Nov 3 12:49:55 2021 -0700
[core-client-rest] Addressing feedback from ArchBoard (#18478)
* Multiple media type handling
* Add Template for path
* update api-extractor
* Add comments to Resource interface
* Revert path type changes
* Add comment about path type
* Omit lint check for Function type
* rebase main
* Revert confidential-ledger dependency bump
commit d85d19a0a35104697ac13761d04aae498cd68652
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Wed Nov 3 12:49:30 2021 -0700
[core-rest-pipeline] Allow specifying any status response to get stream (#18492)
* Add responseAsStream to PipelineRequest
* Use Number.POSITIVE_INFINITY to indicate that any status code should get raw response
* Remove unneeded property in client request and address comments
* Update changelog
commit 416b79b87887d2ca0c268b0643437fc56c4052e5
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Nov 3 11:24:40 2021 -0700
[KeyVault] - Update duration sample and doc comments (#18508)
## What
- Use Day.js in the Key Rotation sample
- Update the doc comments for Key Rotation
## Why
We discussed adding updating the API of Key Rotation to take an object instead
of a raw string for ISO8601 durations; however, with Temporal adding support for
Durations we want to avoid duplicating the type for now. Instead, we decided to
demonstrate interop with an existing 3rd party library. I chose Day.js for this
sample as it has a nice clean API.
commit 5db226aafef1ef077d2b239836dfab09513fc45e
Author: Ziheng Zhou(MSFT) <v-zihz@microsoft.com>
Date: Thu Nov 4 02:00:26 2021 +0800
Update key vault keys to enable live testing in sovereign clouds for multiple services (#18431)
* update test.yml to manage HSM test in multiple clouds
* update tests.yml
* update tests.yml
* update tests.yml
* update tests.yml
commit aa7ada5ba8aaed695159a44c309ec8f1480c2561
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Nov 3 15:21:48 2021 +0800
update-identity-for-track2 (#18482)
commit 591adb420f83e9b24edb92e453b66ec1df405551
Author: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Date: Wed Nov 3 14:41:37 2021 +0800
Make core rest client work with null and encoding (#18381)
* make core rest client work with null and add encoding options
* adding test
* adding test
* use enableUrlEncoding instead
* change to skipUrlEncoding
* add change log
* update dependencies
* upate format
* update according comments
* update format
* change back dependencies
* update pnpm-lock
* resolve ci failure
commit 8d46ea0b169e3e8cfdf0c45f038d88f21c6ad0ea
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 2 23:05:29 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2053 (#18501)
* Changing inline bash for stress test resource deployment
* PR-mod
* pr-mod
* pr-mod
* pr-mod
Co-authored-by: Albert Cheng <albertcheng@microsoft.com>
commit 57cb538bedead0ce555ca7081a0079cb88d9ca57
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Tue Nov 2 16:26:05 2021 -0700
Fix broken links (#18497)
Resolves #18488
Fixes the broken links found in #18488
commit 06266dd4198f943f566c103983b8640f84cf511f
Author: Liangying.Wei <lianwei@microsoft.com>
Date: Wed Nov 3 07:15:00 2021 +0800
Fix issue that the preflight response should hide server detail (#18490)
commit 35820fe0a646ed32f3d3152520d0360d17c12511
Author: Liangying.Wei <lianwei@microsoft.com>
Date: Wed Nov 3 07:14:21 2021 +0800
Update readme to include more examples (#18459)
commit 5d15bfbec5a02e5fdc39bf57abe8f423b9e1f459
Author: Will Temple <witemple@microsoft.com>
Date: Tue Nov 2 16:43:37 2021 -0400
[ai-form-recognizer] Use pipeline to GET Operation-Location (#18495)
commit b81bf006fbf8e8c521bc3d22a9bb1767a06ca223
Author: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com>
Date: Tue Nov 2 13:39:28 2021 -0700
add ReplaceLatestEntryTitle parameter for updating changelog (#18427)
commit 6b1d8df366d5b1ef621e680938468a8443e92fee
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 2 12:54:27 2021 -0700
Post release automated changes for azure-ai-text-analytics (#18494)
commit c91dd8344cc440d21f061fa3f50799b4eea2eb90
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Tue Nov 2 11:59:20 2021 -0700
[core-http] prepare CHANGELOG for 2021 November release (#18491)
Update date and bug fix entries.
commit 446eed1f66330c4ced6c4bd5738d9e060a1ac14c
Author: Liangying.Wei <lianwei@microsoft.com>
Date: Wed Nov 3 00:59:07 2021 +0800
[Web Pubsub Express] Preparing for beta.4 release (#18417)
commit 60b814fdced36ba384ac2d5bad00d6457eac8bab
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Tue Nov 2 12:32:24 2021 -0400
[Text Analytics] Prepare v5.2.0-beta.2 release (#18489)
commit bb82821ae807bc0ed246e2909ad914a2527fe31d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Nov 2 01:41:04 2021 -0700
Post release automated changes for network releases (#18485)
Post release automated changes for azure-arm-network
commit 9762ea3cc1ec0964c56d820dfdde2e1a78d7da82
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Nov 2 16:12:05 2021 +0800
streamanalytics-track2 (#18484)
commit 45d2a921a16887a20039b537fe794b2d3b531c9f
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Nov 2 15:07:43 2021 +0800
network-track2 (#18483)
commit 226578f577ec62d3dbc0211d31e2ff3b656715cc
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 23:04:19 2021 -0700
Use docker to do package validation. (#18479)
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
commit c29b7b1f0e13f0934614a6ed0dd48a3f1e54e27c
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Nov 2 11:16:52 2021 +0800
quota-track2 (#18453)
* quota-track2
* update
* update
commit 1fa2da5e2dfeec384772e79571544cc7b7930966
Author: Liangying.Wei <lianwei@microsoft.com>
Date: Tue Nov 2 11:12:49 2021 +0800
Fix group interface missing closeAllConnections issue (#18461)
Fix https://github.com/Azure/azure-webpubsub/issues/284
commit 2986154ca6fad9c5330f9895679adb77f904ed00
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 18:38:04 2021 -0700
Use https for sparse checkout command (#18475)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 727b2e00fc3a67e265b938caf369aa43e2c84ca5
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Mon Nov 1 16:41:57 2021 -0700
Remove dependency overrides for Identity (#18474)
Related to #14581
In https://github.com/Azure/azure-sdk-for-js/pull/18463, we updated all samples to use GA of Identity v2
In https://github.com/Azure/azure-sdk-for-js/pull/18470, we updated devDependencies of Identity v2 beta to use Identity v2 GA
This PR removes the dependency overrides put in place for the reason (am guessing) that we wanted tests to use the beta v2 Identity, but not samples
Now that the samples are using v2, we no longer need the dependency overrides
commit ae6b6e32852f35e3464d30a44fb616d74b84b76d
Author: Jonathan Cárdenas <JonathanCrd@users.noreply.github.com>
Date: Mon Nov 1 16:10:34 2021 -0700
Remove generate:client script (#18473)
commit d01c64db48b72e43a759dd6e6af71ca619350782
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 15:31:41 2021 -0700
Automatic rush update --full (#18458)
commit 8f40cf08d905c2a154f08baa13c3e2538ee18f66
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Mon Nov 1 15:31:25 2021 -0700
Move Identity dependency from v2 beta to v2 GA (#18470)
commit 290a6e4d6627083535d5fe2a7d429cc04e2d2293
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Mon Nov 1 15:15:54 2021 -0700
Update all samples to use Identity v2 (#18463)
commit 583150dca1ed7ae1ebd5e3f74b48047d489510cb
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Mon Nov 1 17:28:25 2021 -0400
[Batch] Export all types (#18469)
* [Batch] Export all types
* bump version
commit 980fe28689c3d90fea8c3f200acc6bb8d3d2b001
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 13:40:59 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2177 (#18464)
* Create an issue template
* rename the function
* Add description
* Update eng/common/scripts/Invoke-GitHubAPI.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
commit 0a2d9493db245f58cf6ea5e4013d58aa0af18003
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Mon Nov 1 16:40:08 2021 -0400
[Identity] OBO sample improvement (#18330)
Nikitha Udaykumar has been helping me test the OnBehalfOfCredential, and through her feedback, I am making this PR to improve our related samples.
Feedback appreciated 🙏
commit 5eb0b5c4aa20f13f5dbe9d10f11e4ee51303a5bd
Author: Jonathan Cárdenas <JonathanCrd@users.noreply.github.com>
Date: Mon Nov 1 13:25:24 2021 -0700
Standardize autorest command (#18398)
* Standardized command
* Re-adding formatting command
commit c884a809c2a274aff4a0ca3d2098574ffabe1748
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 10:33:21 2021 -0700
Post release automated changes for azure-video-analyzer-edge (#18450)
commit 94e2030864ab783db2b84b05a830dae9e29136ce
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Mon Nov 1 10:24:16 2021 -0700
Add entry for video-analyzer-edge in code owners file (#18446)
commit 1e92624e820229ee01c2443e7841027fc1c7bf6d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 02:27:20 2021 -0700
Post release automated changes for notificationhubs releases (#18457)
Post release automated changes for azure-arm-notificationhubs
commit 317c3ed9dea8d9fb34bef3e848c1e5d08606979a
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 01:53:32 2021 -0700
Post release automated changes for azure-arm-videoanalyzer (#18454)
commit ce1a9767820eaeb76dc70ba9e3cf913f36f2c2d2
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Nov 1 01:52:51 2021 -0700
Post release automated changes for azure-arm-databricks (#18452)
commit 439754c657bd133d1fd9e7524a95504781c5e1db
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Nov 1 16:50:29 2021 +0800
notificationhubs-track2 (#18456)
commit 4967ac6c038bb2edf689415cd978b2df9796edd2
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Nov 1 11:16:34 2021 +0800
videoanalyzer-track2 (#18391)
* videoanalyzer-track2
* update
commit 429c7a027a0d191fc2e5adc3ff2d1b055257d075
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Nov 1 10:13:56 2021 +0800
databricks-track2 (#18441)
commit b02acd2c3e6f83892f525b97799f71baf8871b5a
Author: hivyas <61890270+hivyas@users.noreply.github.com>
Date: Fri Oct 29 15:48:25 2021 -0700
[AVA] Updated package to 1.1, moved to v2 samples flow, moved to core-rest-pipeline (#18425)
* updated package to 1.1
* updating table in readme
* fixing product slugs
* updating slugs and test
* updating slugs
* changing slugs
* fixing formatting
commit cc8130b6e8b86e8abe0d4e7fab3a8dd651b1a9f8
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Fri Oct 29 14:46:41 2021 -0700
Remove Node.js 10 from test matrix (#18403)
* Remove Node.js 10 from test matrix
* Fix text that has node version
commit ec1462c9daa90f375068d07f1c224670c3707dfd
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Fri Oct 29 15:42:56 2021 -0400
[Text Analytics] Add links to Custom Text service docs (#18424)
* [Text Analytics] Add links to Custom Text service docs
* address feedback
commit 8316621389116184a2ac8934e4c05ff57c397498
Author: Mike Harder <mharder@microsoft.com>
Date: Fri Oct 29 11:36:38 2021 -0700
Update rush and pnpm (#18422)
commit 1c9b3d53d1f782451544e7fc9205bd9462554e20
Author: Timo van Veenendaal <timov@microsoft.com>
Date: Fri Oct 29 10:29:57 2021 -0700
[Perf Framework] Add elapsed time column to snapshot log (#18353)
Resolves #12778
commit a528eb82e0d1dc005df5968e116da1d7d52d4572
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Fri Oct 29 10:33:50 2021 -0400
[core-client] authorizeRequestOnClaimChallenge (#17315)
Not so long ago, Python exposed an `ARMChallengeAuthenticationPolicy ` and integrated it to their management core: https://github.com/Azure/autorest.python/pull/992 — this policy adds support for the CAE challenges on the management plane clients. While we haven’t heard of an exact date when this is going to be scoped for JS, we’ve been preparing for this moment for a while, so for us to stay up to date, it should be pretty simple.
This new `ARMChallengeAuthenticationPolicy` policy on Python’s source code can be seen here: https://github.com/Azure/azure-sdk-for-python/blob/9502e669e59e172a9d3d20586ba9761a64e23266/sdk/core/azure-mgmt-core/azure/mgmt/core/policies/_authentication.py — It essentially is the test code that we had in the `bearerTokenAuthenticationPolicy` tests that helped us verify the behavior of the challenge callbacks.
To solve for the same scenario, and after feedback on my initial implementations, I’m adding a new public method on the @azure/core-client called `authorizeRequestOnClaimChallenge`, which can be used as the `authorizeRequestOnChallenge` challenge callback on the `bearerTokenAuthenticationPolicy`. Once this is merged, the code generator for the ARM clients will need to change with something similar to:
```ts
import { bearerTokenAuthenticationPolicy } from "@azure/core-rest-pipeline";
import { authorizeRequestOnClaimChallenge } from "@azure/core-client";
const bearerTokenAuthenticationPolicy = bearerTokenAuthenticationPolicy({
authorizeRequestOnChallenge: authorizeRequestOnClaimChallenge
});
```
If approved (eventually):
Fixes #17386
How does this look? Any feedback appreciated.
commit dcada467f1f50f832230d85177918b69b12ebd90
Author: Aigerim <aykobb@gmail.com>
Date: Fri Oct 29 14:20:13 2021 +0200
the release date of 1.1.0-beta.1 is changed (#18443)
Co-authored-by: Aigerim Beishenbekova <aigerimb@DESKTOP-PIOH0CF.corp.microsoft.com>
commit 40d6a207dd84b0bfc06652fbb4d4bfd1f4a7b5d3
Author: Aigerim <aykobb@gmail.com>
Date: Fri Oct 29 09:19:21 2021 +0200
release date for 1.1.0-beta.1 updated in changelog (#18439)
Co-authored-by: Aigerim Beishenbekova <aigerimb@DESKTOP-H8RSQNI.corp.microsoft.com>
commit b2905c4c165cd852a88ed437b6bdfc4482de923d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 28 23:09:21 2021 -0700
Post release automated changes for azure-arm-resources-subscriptions (#18284)
commit 400f2475fecbf0a1b05fac5bc32b288167066dc8
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 28 23:05:55 2021 -0700
Post release automated changes for mediaservices releases (#18435)
Post release automated changes for azure-arm-mediaservices
commit 1bcb938c7f52d46a88b02edbf2a655f54516c6b6
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Fri Oct 29 12:05:23 2021 +0800
mediaservices-release (#18430)
commit fe42f31724d6e296f672f66a195d972dba00c633
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 28 18:59:08 2021 -0700
Post release automated changes for azure-arm-operations (#18413)
commit 61adb7df2677ef49b636e83a0fbffab3a9beebf5
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 28 18:55:58 2021 -0700
Post release automated changes for appplatform releases (#18383)
Post release automated changes for azure-arm-appplatform
commit dc04bbeb549432eb30f47e11771f86fd473a8f82
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Fri Oct 29 09:42:58 2021 +0800
mediaservices-track2 (#18415)
* mediaservices-track2
* update
commit d5fe48454ff3d0b79181d94665991cf65a03704a
Author: Jonathan Cárdenas <JonathanCrd@users.noreply.github.com>
Date: Thu Oct 28 13:50:12 2021 -0700
Increase timeout from 15 to 30 minutes (#18107)
commit 14a8a4e2109c3eefcf8517d1fc06523e88ec2422
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Thu Oct 28 13:39:21 2021 -0700
[Event Hubs] Add changelog entries for beta release (#18407)
Our upcoming November release for Event Hubs will be a beta release. This PR
- updates the package version to use beta
- adds changelog entries that were missed before
commit 10f96dd79192e6f05acd2677552ae7f94f98243d
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Thu Oct 28 13:14:46 2021 -0400
[Text Analytics] Expose response's action name (#18410)
* [Text Analytics] Expose response's action name
* add changelog entry
commit b6fed8ba7fc73196727dd0a6c745b2a153347f31
Author: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com>
Date: Fri Oct 29 02:06:21 2021 +0900
Typo "Typescript"→"TypeScript" (#18416)
https://docs.microsoft.com/en-us/javascript/api/overview/azure/event-hubs-readme?view=azure-node-latest
#PingMSFTDocs
commit a00d576c976210ef4b32f9ab0c80fd144ec7d417
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 28 09:35:45 2021 -0700
Post release automated changes for identity releases (#18418)
Post release automated changes for azure-identity
commit b31eb5db38cd07a480096789d70f4da53fdd96ff
Author: Brian Terlson <brian.terlson@microsoft.com>
Date: Thu Oct 28 06:07:40 2021 -0700
[Web Pubsub] Renames per arch board (#18399)
commit 6cf53098c5d619c57b3396f8329c5ed57937b541
Author: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com>
Date: Thu Oct 28 13:39:01 2021 +0800
Fix Schema Registry Readme Issue (#18411)
commit e9c4cd4771d943045b4b8e9ab48ab7820c2ae7ee
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Thu Oct 28 13:18:33 2021 +0800
operations-track2 (#18394)
commit 6ebc5a2bec38487aab357d0299fb6243878861cf
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Wed Oct 27 20:15:02 2021 -0700
Prepare identity release 2.0.1 - update changelog date (#18408)
Prepare identity release 2.0.1 - update changelog date
commit bd0bca68374757b12453522e12ead0fbfc0fb977
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Wed Oct 27 22:20:57 2021 -0400
[Text Analytics] Allow multiple actions of the same type (#18382)
* [Text Analytics] Allow multiple actions of the same type
* address feedback
* remove onlys
commit 8fcdbfec40ce51cda3d79b03fcc6f70522b085f7
Author: marcodalessandro <madales@microsoft.com>
Date: Wed Oct 27 17:03:08 2021 -0700
[@azure/event-hubs] Adding `disableDeserialization` option when subscribing (#18173)
commit f8a3be788a877b316257766f1be391d2a7d5175e
Author: Timo van Veenendaal <timov@microsoft.com>
Date: Wed Oct 27 16:41:18 2021 -0700
[Perf Framework] Print dependencies on perf test start (#18366)
Resolves #13825.
commit 31e9c3a85aced397be3400f33dc4ba27416e029c
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Oct 27 14:21:26 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2152 (#18377)
* Remove the new sdk check and populate json for track 1 package
* Update Save-Package-Properties.ps1
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
commit 34ba5441dba817cccd115d7a10b6f05006ddb6c5
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Wed Oct 27 10:53:06 2021 -0700
[KeyVault] - Fix sovereign cloud tests (#18350)
## What
- Suppress key rotation tests in sovereign clouds
- Ensure AZURE_AUTHORITY_HOST env var is passed to the credential in tests
- Suppress premium SKU tests when KV is not premium
## Why
These are added to support sovereign cloud testing.
The first is a must for us as key rotation is simply not available in all
clouds yet as a preview feature. We still want to test this feature in public cloud though so suppressing it in government
clouds is a reasonable approach.
The second is necessary to authenticate correctly in different authorities.
Finally, the third is a must as premium SKU is not available everywhere.
Fixes #18142
Partially Fixes #18267
Fixes #18189
commit 4386511b29a6327188c4013e3bfbe74bcea4aa98
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Oct 27 02:45:33 2021 -0700
Post release automated changes for containerservice releases (#18393)
Post release automated changes for azure-arm-containerservice
commit 005e39c1522e9de9e0e2a54d415f1163b1d2c35a
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Oct 27 16:31:38 2021 +0800
containerservice-tack2 (#18385)
* containerservice-tack2
* update
commit 518dc805cdaee4cfc1e6a0992841fbcc11f5d77c
Author: Liangying.Wei <lianwei@microsoft.com>
Date: Wed Oct 27 14:52:07 2021 +0800
Reuse azure logger and move endpoint setting into options (#18359)
commit f2a1e3802be3606571c6150f64a11ab799c2a2f7
Author: Petr Švihlík <rocky.intel@gmail.com>
Date: Wed Oct 27 08:26:19 2021 +0200
fixed method name as per the azure board review (#18378)
commit 65832ba81838f40a2c89347de19fd7811d369d12
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Oct 27 11:35:10 2021 +0800
appplatform-track2 (#18380)
* appplatform-track2
* update
* update
commit 625589cdbf2da3052e2ea84f6386829b16f6862d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Oct 26 19:18:02 2021 -0700
Post release automated changes for azure-arm-recoveryservices (#18361)
commit 90a62556e63878aaa2eff25b7f539035c8fe1c88
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Tue Oct 26 15:53:14 2021 -0700
[Samples] update communication and app-config samples (#18362)
commit 6e6fb6aedef5eac0eb646601bbaa3f428555827b
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Tue Oct 26 15:37:15 2021 -0700
[App Config] Better error message for AppConfigClient with invalid connection strings (#18356)
* better error message for AppConfigClient
* changelog
* (connectionStringOrEndpoint || "").match
* connectionStringOrEndpoint?.match
commit b4d48e45788af3ddcc04188a01d33a3ca00647d9
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Tue Oct 26 18:28:47 2021 -0400
[Text Analytics] Merging feature branch for v5.2-beta.2 to main (#18355)
* [Text Analytics] Regenerate using v3.2-preview.2 swagger (#17026)
* [Text Analytics] Regenerate using v3.2-preview.2 swagger
* regenerate with latest version
* [Text Analytics] Support Custom Text (#17128)
* [Text Analytics] Support Custom Text
* update readme and compile new actions
* export ClassificationResult
* edit
* edit
* edit
* [Text Analytics] Make project and deployment names required (#17402)
* [Text Analytics] Add tests for Custom Text (#17756)
* [Text Analytics] Add tests for Custom Text
* update
* remove only
* [Text Analytics] Refine proposed API View (#17794)
* [Text Analytics] Refine proposed API View
* update changelog
* [Text Analytics] address archboard feedback (#18131)
* address archboard feedback
* Update sdk/textanalytics/ai-text-analytics/src/multiCategoryClassifyResult.ts
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
* [Text Analytics] Add samples for Custom Text (#17822)
* [Text Analytics] Add samples for Custom Text
* edit summary
* Update sdk/textanalytics/ai-text-analytics/samples-dev/customText.ts
Co-authored-by: Will Temple <witemple@microsoft.com>
* revert samples
* unpublish
Co-authored-by: Will Temple <witemple@microsoft.com>
* [Text Analytics] Use persistent CI resource
* fix typo
* address feedback
* fix typo
* [Text Analytics] Fix Preview.2 samples (#18257)
* [Text Analytics] Re-record all tests (#18354)
* address feedback
* update swagger link
* edit
* fix recordings
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Will Temple <witemple@microsoft.com>
commit 93fa1009693546f984c2402be29a8f8a5e45ef47
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Oct 26 14:10:51 2021 -0700
Add latest released version to prepare prerelease (#18373)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit d60fc1fec39e288677deed776740a72db5312df1
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Tue Oct 26 10:56:10 2021 -0700
[core-http] HttpHeaders.clone() should keep raw header name casing (#18348)
Original header names are still available in the values of
`_headersMap` and in the result of `headersArray()`. However we
currently initialize the clone using `this.rawHeaders()` which returns
an object with lower-cased keys thus the original raw header names
are lost.
When cloning HttpHeaders, we should use the original header names in
the clone instead.
commit 4c16af6eb4ffeaadba734ae15beed771b17bed2b
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Tue Oct 26 13:13:21 2021 -0400
[Text Analytics] Delete unused URL parsing helper (#18357)
commit 730ee58d708261b224f070109c35e38355d05654
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Tue Oct 26 12:09:10 2021 +0800
recoveryservices-track2 (#18342)
commit 6140e810bb0bde5338b285e3e772b8ef1c7ba608
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 25 17:05:57 2021 -0700
Post release automated changes for core releases (#18358)
Post release automated changes for azure-core-client
commit 79aa07f77706c8d669930837ca332fa317230f54
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Mon Oct 25 18:59:12 2021 -0400
[core-client] Prepare v1.3.2 release (#18352)
commit 79bbf95efef8f97fba54fca2e5ed617d94278fcf
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Mon Oct 25 14:51:17 2021 -0700
[KeyVault] - Use 7.3-preview for certificates and secrets (#18346)
commit e662d41605a5869a3e553c89b9e1d74fa2417f72
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 25 13:55:05 2021 -0700
Automatic rush update --full (#18343)
commit 739a68bfcea8723fb44ab4bb3079d532a3f58952
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 25 13:52:33 2021 -0700
Post release automated changes for azure-arm-containerregistry (#18303)
commit be355116959ffb72bedb5c62fb41f1cf85d0b765
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Mon Oct 25 13:01:48 2021 -0700
[KeyVault] - Add missing lib:dom reference (#18344)
## What
- Add lib: dom entry to keyvault-secrets tsconfig
- Add lib: dom entry to keyvault-admin tsconfig
- Remove dom.d.ts from keyvault-common
## Why
During min/max testing we found that the dom.d.ts file doesn't actually help
when keyvault-common is bundled in with the rest of the source files. The other
keyvault packages are already including lib: dom which is why things worked fine
for them.
The solution here is to just add lib: dom to kv-secrets to match the other kv
packages.
While not strictly necessary yet I did add it to keyvault-admin as well because
it'll surely come up once MHSM deployments resume correctly.
commit c2c723ddafca39dca375a7f8b36af16ed03e9fe3
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date: Mon Oct 25 14:23:58 2021 -0400
Identity alpha build is failing with missing test-utils dependency (#18345)
commit ce466e54362b95d9507412f0e943cf93ceb437fd
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Sun Oct 24 21:40:14 2021 -0700
Post release automated changes for azure-arm-logic (#18337)
commit f1068b17a6e16219b870e9eb661862ccbca6de42
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Oct 25 10:37:54 2021 +0800
logic-track2 (#18313)
commit 7a7d99d271f62aef320963d26bab76b4dea50afc
Author: Timo van Veenendaal <me@timo.nz>
Date: Fri Oct 22 23:05:56 2021 -0700
[Perf Framework] rename perfstress to perf and runAsync to run (#18290)
Reported in #18033.
Basically did a bulk find+replace everywhere. Things _seem_ to be working OK, but wouldn't be surprised if there's something somewhere I've missed, or somewhere where I've replaced something I shouldn't.
I've split the rename of PerfStress -> Perf and runAsync -> run into two commits for ease of review :)
commit 58beb3e7d18650c5d961c5099e2519f58a963d99
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 22 15:07:27 2021 -0700
Fully automate cluster buildout. Add azure file share mount to stress tests. (#18327)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
commit 04c45d14c8a2b531a4f869c355b76b2fd260af22
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Fri Oct 22 17:42:56 2021 -0400
[Identity] Re-enabling the Service Fabric MSI (#17579)
* [Identity] Re-enabling the Service Fabric MSI
* Update managedIdentityCredential.spec.ts
* CHANGELOG entry
* Update fabricMsi.ts
* Update fabricMsi.ts
commit a00a662e3f50f4b4d45bee634d41932996c49459
Author: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Date: Fri Oct 22 16:18:12 2021 -0400
[core-client] Skip parameter overwriting if the path is absolute (#18310)
* Skip parameter overwriting if the path is absolute
* add a comment
* update changelog
* update TA recordings
* address feedback
commit f26bb90567e828fca5d01172ae6d020f141b2432
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Fri Oct 22 13:13:56 2021 -0700
[KeyVault] - Address archboard review feedback (#18319)
## What
- return bytes from getRandomBytes
- rename KeyReleasePolicy.data to KeyReleasePolicy.encodedPolicy
- rename target to targetAttestationToken
## Why
These address recent architecture board review comments and will improve the
overall experience when using these new APIs.
Resolves #18307
Resolves #18317
commit 66a7eb4544df757e803d487a1bc8be7a5e3314d4
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Fri Oct 22 15:44:26 2021 -0400
Revert "[Identity] Pointing to troubleshooting guide on more credentials (#18296)" (#18311)
This reverts commit d75512a573757a7cfa1a774b27d635f714d0e168.
commit d79c90f49312851d798de610d3c0eb481b66e25c
Author: Andrej Kyselica <andrej@kyselica.com>
Date: Fri Oct 22 14:55:03 2021 -0400
fix nested code quote (#18318)
commit 1c04b202f507af6297d00318aa06f9663f15108e
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Fri Oct 22 08:40:07 2021 -0700
Revert "[KeyVault] - Add key_ops to JWK and deprecate keyOps (#17914)" (#18314)
This reverts commit 0ad4ea3cd1128d908dae2ef0a902f4a7c1177a9f.
We decided not to take this change in - the reasons are:
1. Currently there's no _clean_ way to prevent modeler4 from normalizing a name. That is tracked in https://github.com/Azure/autorest.typescript/issues/1211 but the swagger transform is messy at this point
2. Originally I had applied the transformation in code when deserializing a JWK from the server; however, I forgot there's also the importKey operation
3. While a customer did ask for this in dotnet, nobody has asked for this in JS so there's a lot of risk for very little customer benefit
commit 0a3dd1580b444d88eb9d9fbaafb6ecf0882211aa
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Fri Oct 22 08:21:44 2021 -0700
[KeyVault] - Move dom reference to dts file (#18315)
In order to work around a known typing issue when using the global URL, we added
a reference comment in source code.
This PR just moves that declaration to a separate dts file in order to stay
consistent with how we're doing it in other packages.
commit c52e8a2d207c2197b28b56d1b13c07b754203b6b
Author: Petr Švihlík <rocky.intel@gmail.com>
Date: Fri Oct 22 09:12:35 2021 +0200
Renamed exchangeTeamsToken to exchangeTeamsUserAadToken (#18306)
* exchangeTeamsToken to exchangeTeamsUserAadToken
commit 4cc59c0b2f56f7a8e119b2f45d077d4e0c87a192
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Thu Oct 21 22:40:16 2021 -0700
[Service Bus] ATOM API - Make service version configurable (#18254)
* ServiceBusAtomAPIVersion
* older API Version is broken
* tests
* rename
* changelog
* getRandomServiceVersion
* remove .only
* address Jeremy's feedback
* serviceVersion comments
* docs
* test with both the api versions
* Donot expose ServiceBusAtomAPIVersion
* test
* doc update
commit 88791cd070e4e105ea5d1e82beac54e4a5acbf7c
Author: Harsha Nalluru <sanallur@microsoft.com>
Date: Thu Oct 21 17:54:32 2021 -0700
[Unified Recorder] AddSanitizer (#17379)
* connection string sanitizer
* removeHeaderSanitizer
* add server
* rename as unit tests
* update integration test commands
* lock file
* sanitizer tests
* lock file
* del;ete sanitizer test file
* build failures
* sanitizer starter tests
* export setEnvironmentVariables from recorder
* sanitizer and related changes
* pass client.start param
* recorder.start takes options
* update karma.conf
* core-v1 and core-v2 tests with sanitizer
* recordings
* remnove console.log
* getRealAndFakePairs rename
* session file not needed
* doc comment
* temp-commands
* sanitizer APIs
* add more routes to the server
* lock file
* tests with the local server
* node recordings
* browser counterparts
* echo skipped
* comment out
* UriRegexSanitizer
* UriSubscriptionIdSanitizer
* continuationSanitizer
* headerRegexSanitizers
* Codespaces
* UriRegexSanitizer
* simplify UriRegexSanitizer test
* UriSubscriptionIdSanitizer
* recordigns
* lock file
* unneeded commented code
* ResetSanitizer did not work as expected
* groupForReplace and transformsInfo
* adding sanitizer to start method
* recordings
* some docs and handleEnvSetupForPlayback
* lock file
* docs
* changelog
* changelog
* comments
* Daniel's feedback
* lock file
* ProxyToolSanitizers, sanitizerKeywordMapping
* refactor
* add comment
* more docs
* test-proxy starter code for starting
* Revert "test-proxy starter code for starting"
This reverts commit 49a2d6816a901b04fe3d9669923c8b9e58fe72a2.
* Jeremy's and Daniels's feedback
* part feedback from Will
* mistype
* exclude Exclude from Exclude<T, undefined> to not have Exclude
* Simplify getKeyValuePair method
* getConnStringAsJSON
Co-authored-by: Codespaces <codespaces@github.com>
commit f975db12027cafeb27c60d3db56409c219c81bec
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Thu Oct 21 15:46:45 2021 -0700
[ContainerRegistry] support passing service version via client options (#18067)
This PR adds an optional `serviceVersion` proeprty to `ContainerRegistryClientOptions`.
commit 27d81495f905a24a9f82ec3a152073e05729657d
Author: Dina Berry <41597107+diberry@users.noreply.github.com>
Date: Thu Oct 21 10:17:25 2021 -0700
Fix minor typo (#18293)
commit 49cebf06eb430cee3a6cc31fca75b629e02d4eda
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Thu Oct 21 09:55:01 2021 +0800
containerregistry-track2 (#18285)
commit d75512a573757a7cfa1a774b27d635f714d0e168
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Wed Oct 20 21:09:02 2021 -0400
[Identity] Pointing to troubleshooting guide on more credentials (#18296)
* added the troubleshooting guide to the credentials that use MSAL
* CHANGELOG
commit 0ca3320c72864919350d7af2a67c97843d78e150
Author: Jeremy Meng <yumeng@microsoft.com>
Date: Wed Oct 20 16:57:42 2021 -0700
[ContainerRegistry] Remove browser related docs (#17717)
* [ContainerRegistry] Remove browser related docs
as the service doesn't support configuring CORS settings, which make it not
possible to use in a secure browser environment.
* Link to CORS consideration doc
commit ef42711ac167b15af2e0898183c7cba4b3b91b30
Author: Brian Terlson <brian.terlson@microsoft.com>
Date: Wed Oct 20 16:13:52 2021 -0700
[Web-Pubsub] Update to latest API version, support DAC, support APIM (#17134)
commit 72aff0fe90a9e976cf6057aa541a663b86f604f7
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Oct 20 12:08:01 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2093 (#18288)
* Consume Codeowners parser library, ceperate users from teams in codeownerse
* Update get-pr-owners and related logic
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit 08ce4b0eed073a122d803afcfbcdf0d551d9280f
Author: Petr Švihlík <rocky.intel@gmail.com>
Date: Wed Oct 20 09:57:02 2021 +0200
Added Public Preview API version for the Custom Teams Endpoint (#18271)
* Added Public Preview API version for Custom Teams Endpoint
* Updated readme, samples, changelog
* Added a test for expired token and empty token
* Fixed tests for exchangeTeamsToken
* Updated test recordings
commit 2177931d55fecce4e59e0a1d7f2dc67b4107f8dc
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Oct 20 15:19:56 2021 +0800
update (#18281)
commit 35161af18387dd7a6ac14b04254444e795ef488e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Oct 19 20:18:24 2021 -0700
Post release automated changes for postgresql releases (#18280)
Post release automated changes for azure-arm-postgresql
commit 6120a0a69fee75d0874ab5a37ba89120daa5a003
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Oct 20 11:08:14 2021 +0800
Update package.json for subscriptions (#18279)
* update-package.json-for-subscriptions
* update-package.json-for-subscriptions
commit 92e46cb57b17b24989bcf4d6d0fa96e0d171eb58
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Wed Oct 20 10:26:55 2021 +0800
postgresql-track2 (#18263)
* postgresql-track2
* update
commit 6144868b30a5d9d4243fb7f9ba08707d25b5b55b
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Oct 19 19:19:59 2021 -0400
[Identity] Fix Azure CLI Credential on Windows (#18275)
Some time ago, a security change was made on the Azure CLI credential that changed the `exec` call to `execFile` for `az` calls, here: https://github.com/Azure/azure-sdk-for-js/pull/14408. This PR moved from Node.js’s `child_process.exec()` to `child_process.execFile()`. That change however didn’t take in consideration that `exec` would run commands in a shell and `execFile` would not. Turns out that, on Windows, the Azure CLI `az` is not a program Windows can find without a shell. For the longest time, whenever I saw this error, it seemed like an environment issue and not a real bug. Thanks to this customer issue: https://github.com/Azure/azure-sdk-for-js/issues/18268 things finally clicked.
This PR ensures that the AzureCLICredential calls to the `az` program within a shell.
Note: v1 doesn’t have this problem because it still uses `exec`: https://github.com/Azure/azure-sdk-for-js/blob/hotfix/identity_1.5.2/sdk/identity/identity/src/credentials/azureCliCredential.ts#L42
Feedback always appreciated 🙏
commit 48ebdfbf8a221969d9c2300aeb9e93fb0ad3074e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Oct 19 14:44:55 2021 -0700
update to latest test-proxy tag (#18276)
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
commit 0ac4aac6448ca6ed13f265c5cfb981d511942657
Author: Dina Berry <41597107+diberry@users.noreply.github.com>
Date: Tue Oct 19 11:10:30 2021 -0700
Expose API from App registration, not Enterprise app (#18255)
commit c027e05a7e6ba6539b03ba92e00c06f0a33d2aa1
Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
Date: Tue Oct 19 11:00:31 2021 -0700
Update CHANGELOG.md (#18273)
commit bc96130d1b730c2300ea3bc28419899e7c72c4af
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Tue Oct 19 10:42:04 2021 -0700
Automatic rush update --full (#18247)
commit 0e85c8ea4befd5f7613d067815303ba9e49fed91
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Oct 19 13:41:38 2021 -0400
[Identity Plugins] Increased version to v1.0.1 (#18258)
commit 1e507db7050533e92f8bdf0b7a22310b9c8e3fe4
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 19:53:42 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2085 (#18259)
* Fix up identity resolver to make it more reliable, publish notification configuration as a tool
* Use both username and email to resolve queuing user
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
commit 6ebc0269c747555163300e7d3e1c63282a2776f6
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 16:11:03 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2100 (#18252)
* Add group id into metadata for java use
* Update Update-DocsMsPackages.ps1
* Update Update-DocsMsPackages.ps1
* Update eng/common/scripts/Update-DocsMsPackages.ps1
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
* Update eng/common/scripts/Update-DocsMsPackages.ps1
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
commit 2ce90510e7f7c580266f3f765d6b4f963767acc8
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 13:31:45 2021 -0700
adjust the docker-start-proxy to take advantage of the linux specific commands that allow contact of localhost (#18250)
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
commit 4e1e77af1586795ece96e16a3e3102ebeb067333
Author: govardhan <27.govardhan@gmail.com>
Date: Tue Oct 19 01:18:34 2021 +0530
updated the cosmosdb doc with correct syntax and return type (#18228)
commit 972059c315512d9d682681e214e68860e50e39ce
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 12:41:06 2021 -0700
Post release automated changes for purview releases (#18187)
* Post release automated changes for azure-rest-purview-scanning
* Fix readme
Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
commit 0163e3cb2873879004ec0ff54355445ee5fcc71d
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 12:40:56 2021 -0700
Post release automated changes for purview releases (#18215)
* Post release automated changes for azure-rest-purview-administration
* Fix samples readme
Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
commit 201a7754dadec5babccd3982af6a9b6e6b156611
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Mon Oct 18 12:40:03 2021 -0700
Update Purview owner (#18249)
commit fb1f1a7835db1fc9bf2d6e9e200f3f87cf600165
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 12:39:32 2021 -0700
Post release automated changes for purview releases (#18192)
* Post release automated changes for azure-rest-purview-catalog
* Fix samples readme
Co-authored-by: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
commit 0c47584b30fd6b8c9443ce610254dd26d4147ff4
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Mon Oct 18 07:57:05 2021 -0700
[Tables] Multiple small fixes to Tables SDK (#18211)
* Multiple small fixes to Tables SDK
* Remove un-needed changes
* Update sdk/tables/data-tables/README.md
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
* Update sdk/tables/data-tables/README.md
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
* Update sdk/tables/data-tables/src/serialization.ts
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
* Update sdk/tables/data-tables/src/utils/bufferSerializer.ts
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
* bring back base64 encoding
* update sample name
* Fix format and update changelog
* Update sample name
* Remove un-needed re-recordings
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
commit 5215a7d829e63302c0fe5f0b1c90b35ef7945541
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 02:24:37 2021 -0700
Post release automated changes for compute releases (#18244)
Post release automated changes for azure-arm-compute
commit baa70f87320b8fc8c323e147b4ad0f54966aca9e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Mon Oct 18 01:58:13 2021 -0700
Post release automated changes for policy releases (#18243)
Post release automated changes for azure-arm-policy
commit f4198b6a5517ce284d83704aac6f7250d151cc76
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Oct 18 16:40:24 2021 +0800
compute-track2 (#18239)
* compute-track2
* update
commit 29b628083f4936d068e1548da23b4608f944b007
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Mon Oct 18 14:48:37 2021 +0800
policy-track2 (#18229)
* policy-track2
* update
* update
commit c3b75ee4e29d6cd2008fbd29101769d7012f3793
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 17:57:19 2021 -0700
Post release automated changes for identity releases (#18218)
Post release automated changes for azure-identity
commit 3e965811e6255ff474f5f2974db82ab4073358fc
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Fri Oct 15 14:42:08 2021 -0700
Support manually handling continuationTokens (#18179)
* Support manually handling continuationTokens
* Use PageSettings and update version
* Update samples and page type
* Address PR Comments
* Undo changes to generated samples
* Fix format
commit 6464b0efa4b250685eec5356477cb7d073d2af72
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 13:08:08 2021 -0700
Post release automated changes for synapse releases (#18056)
* Post release automated changes for azure-synapse-spark
* Post release automated changes for azure-synapse-artifacts
commit 850366a7117a76f5c9afa0a453a25d3925a968ae
Author: Jose Manuel Heredia Hidalgo <joheredi@microsoft.com>
Date: Fri Oct 15 12:44:52 2021 -0700
[Purview Administration] Prepare for 1.0.0-beta.1 release (#18212)
* Regenetate with latest api-version and update changelog
* Update changelog
commit 64936d6abd3b4c6160cfe63377ca2c34e5567868
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 11:49:04 2021 -0700
Post release automated changes for monitor releases (#18084)
Post release automated changes for azure-monitor-query
commit 55dc5736f404c5f08f544213eba1bfb2560ac650
Author: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com>
Date: Sat Oct 16 02:15:30 2021 +0800
update to latest (#18144)
commit cdbe548db571b39a7dccff41aa68db736910042f
Author: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com>
Date: Sat Oct 16 02:15:13 2021 +0800
Fix Synapse AccessControl Readme Issue (#18143)
* Fix Synapse AccessControl Readme Issue
* Update run_test.ts
Co-authored-by: Tong Xu (MSFT) <57166602+v-xuto@users.noreply.github.com>
commit 45723afcb83de53ac8e540b73df446e535468da2
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Fri Oct 15 14:15:02 2021 -0400
[Identity] changing the release date (#18213)
We couldn’t release yesterday, but we were able to test the bundles. Let’s get this out today.
commit edb6fb4d757fd7b0e70f837c5520fcb3cae7737a
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 11:04:20 2021 -0700
Post release automated changes for monitor releases (#18053)
Post release automated changes for azure-monitor-opentelemetry-exporter
commit dcc3156e6dedbf7f8627f4c5c12343092f11c6ca
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 11:01:13 2021 -0700
Post release automated changes for azure-arm-apimanagement (#18114)
commit 52f4889c9cfa4152cfdaafde647b9f50f41cd9e9
Author: govardhan <27.govardhan@gmail.com>
Date: Fri Oct 15 23:20:04 2021 +0530
[Cosmos] removing the upsert as a supported feature (#18193)
commit c1f7abf764911c4d5962df24b07c2fc425d0e5d1
Author: Kevin <skiimilk@gmail.com>
Date: Sat Oct 16 01:47:52 2021 +0800
Fix spelling error (#18186)
commit b2d9efe1f9716816c55117313144f059bde73360
Author: Maor Leger <maorleger@users.noreply.github.com>
Date: Fri Oct 15 10:43:25 2021 -0700
[KeyVault] - Support multitenant challenge authentication (#18082)
## What
- Parse tenantId from WWW-Authenticate authorization field and pass it to the getToken call when parsing challenges
## Why
Identity will soon add multi-tenant challenge authentication support. It's already supported in `main` today, and will supported
in production soon. On the KeyVault side we just need to pull out the tenant ID from the `authorization` field and pass it in
as part of the `GetTokenOptions` options bag when calling `getToken`. Older Identity clients will ignore this field, but newer
clients will use it as the tenantId.
Resolves #17619
commit 5075150408b4c4d44c97dac9ad5c37ffdd1ab989
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:32:27 2021 -0700
Post release automated changes for azure-arm-eventhub (#18198)
commit e197af8b8b23e7b875fc51d67fcdcf76eb3334a5
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:31:49 2021 -0700
Post release automated changes for azure-arm-compute (#18196)
commit 9da00cc3b186affeaeca0b1575d6e40d34050a86
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:31:40 2021 -0700
Post release automated changes for azure-arm-features (#18200)
commit 798aca894f73385dd678ee12eefcbdcd90db640b
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:31:34 2021 -0700
Post release automated changes for azure-arm-storage (#18207)
commit 5aeee52243b14828fcdb923ace2534d66b323751
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:31:28 2021 -0700
Post release automated changes for azure-arm-policy (#18209)
commit 15e48a44ce509212ea4bcb51fd3d60947a16516e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 10:07:06 2021 -0700
Post release automated changes for azure-data-tables (#17495)
commit 45c84009f60fc00c1db37211f02203807be22f84
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:18:04 2021 -0700
Post release automated changes for eventgrid releases (#18197)
Post release automated changes for azure-arm-eventgrid
commit 5cb453510c95928e1f7afdcfeb1b78c3b010d272
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:08:38 2021 -0700
Post release automated changes for security releases (#18184)
Post release automated changes for azure-arm-security
commit df175ca0121b32a9322895a52156082bfa63e6db
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:06:45 2021 -0700
Post release automated changes for appservice releases (#18194)
Post release automated changes for azure-arm-appservice
commit 208a20957b7186146fedfc20f54fb11d056ed142
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:05:35 2021 -0700
Post release automated changes for authorization releases (#18195)
Post release automated changes for azure-arm-authorization
commit 3ac3f7e1199c8d44c79c43e7a66fea6994ec8096
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:03:11 2021 -0700
Post release automated changes for keyvault releases (#18199)
Post release automated changes for azure-arm-keyvault
commit 32462c8f6bb00aa98ed7600743f3b5d5cac2a38e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:02:31 2021 -0700
Post release automated changes for locks releases (#18201)
Post release automated changes for azure-arm-locks
commit 843021c32486802eaae14caeb5e9e2c4dbfac90e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:01:44 2021 -0700
Post release automated changes for managedapplications releases (#18202)
Post release automated changes for azure-arm-managedapplications
commit 53275f74504dd11b6a3bdd98e3fc395f5b1f82f9
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:01:11 2021 -0700
Post release automated changes for redis releases (#18203)
Post release automated changes for azure-arm-rediscache
commit fc7cb118f34f8705c667911bf5df23a22f8dd59c
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:00:49 2021 -0700
Post release automated changes for network releases (#18204)
Post release automated changes for azure-arm-network
commit fc18040f18cbb599848c58f10563e4e1ac6f7733
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 03:00:21 2021 -0700
Post release automated changes for resources releases (#18205)
Post release automated changes for azure-arm-resources
commit b01fc24700710c7e90bff850139aefe247059c5e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 02:59:41 2021 -0700
Post release automated changes for servicebus releases (#18206)
Post release automated changes for azure-arm-servicebus
commit 48bb7d330fa82825e14c605f9f0f9f83e3dfc6af
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Fri Oct 15 02:59:19 2021 -0700
Post release automated changes for links releases (#18208)
Post release automated changes for azure-arm-links
commit 9baaaf6404bab19631914dcfbf8c47359710fd15
Author: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Date: Fri Oct 15 15:38:30 2021 +0800
update-purview-catalog-version-for-release (#18191)
commit f447a83ca994eaae54b019fc82ce7bfc65c1e197
Author: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Date: Fri Oct 15 14:30:45 2021 +0800
update purview catalog changelog (#18188)
commit 5f2a1c443d3ddfe802d5c25747946ec8890ea80c
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 14 22:56:53 2021 -0700
Post release automated changes for sql releases (#18182)
Post release automated changes for azure-arm-sql
commit 29b72e32940830050b091b25d135ce37951d4ab4
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Thu Oct 14 22:56:33 2021 -0700
Post release automated changes for operationalinsights releases (#18185)
Post release automated changes for azure-arm-operationalinsights
commit d560735e6ae124c83916c16fcdc5a42cd06ad8d0
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Fri Oct 15 10:44:11 2021 +0800
security & operationinsights update (#18180)
* update changelog
* update
commit 67a8c56507ad78067a03042cbf2b3cd7b4b7a166
Author: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Date: Fri Oct 15 10:27:16 2021 +0800
update purview scanning samples (#18154)
* update purview scanning samples
* Update README.md
* remove comment out line
* update samples
* to resolve comments
commit f5ea75af7ef24d663cfa9cc959a42f61fcb3ea53
Author: Ramya Rao <ramya.rao.a@outlook.com>
Date: Thu Oct 14 17:53:25 2021 -0700
Updates to CodeOwners file for folks no longer with the team (#18178)
commit a89de3847738955633a65ebde9b46d61005f337a
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Thu Oct 14 20:27:35 2021 -0400
[Identity] Spotted a code issue in the OBO sample (#18177)
👷 Better late than never.
commit 8801bdb0cc59edabb6b403d26eace14ba6e6186a
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Thu Oct 14 19:02:19 2021 -0400
plugins to 1.0.0 and specified a release date in the CHANGELOGs (#18176)
commit afbcea7b063f1f5c0511790e9fa8e35b1c217644
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Thu Oct 14 17:54:47 2021 -0400
[Identity] 2.0.0 release date (#18175)
commit a4241d1273d8490e950b0839dd7628134d7c4aa2
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Thu Oct 14 14:11:26 2021 -0400
[Identity] Better names for the InteractiveBrowserCredential options (#18166)
commit 28e3f8058c5ef0423e1136a06fa01f14c8071b57
Author: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Date: Thu Oct 14 11:18:59 2021 -0400
Update npm tag setting script to generate new tags based on currently tagged versions (#18165)
commit 9cee4779fa51ab266c9f82c34a9fbb7d38124838
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Thu Oct 14 17:22:11 2021 +0800
operationalinsights-track2 (#18172)
commit 529fcd7b52be3dab1ba63c9cfe67782fbedd5834
Author: colawwj <70128817+colawwj@users.noreply.github.com>
Date: Thu Oct 14 10:56:53 2021 +0800
security-track1 (#18167)
commit ac86a56992d339ce7e337fbc4e282f0b02d30fe3
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date: Wed Oct 13 10:43:51 2021 -0700
Sync eng/common directory with azure-sdk-tools for PR 2095 (#18149)
* Mitigate relative path calculation error on multiple iterations
* Revert "Mitigate relative path calculation error on multiple iterations"
This reverts commit 45baedd990c6a3085742a38a4891d8706a93be77.
* GetRelativePath should check if path is already relative before calling [IO.Path]::GetRelativePath
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
commit 0afa58e9a8072a4f9a112b4feb37aabcd988e42f
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Tue Oct 12 19:12:09 2021 -0700
add troubleshooting guide for identity (#17734)
* add troubleshooting guide for identity
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
commit a319c90966f63eb57bd785db65f627c50b96f608
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Oct 12 22:01:34 2021 -0400
[Identity] On Behalf Of sample (#18109)
* [Identity] On Behalf Of sample
* once again, I forgot to remove en-us
* Apply suggestions from code review
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
* extra line
* removed old section
* Apply suggestions from code review
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
commit 63be7d208da651c911e5c716cf602ad7081fe003
Author: KarishmaGhiya <kaghiya@microsoft.com>
Date: Tue Oct 12 18:15:34 2021 -0700
Readme inconsistency (#18098)
commit 80662729cec289223c0e3a5bfa8bdc6bd3040f81
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Oct 12 15:51:28 2021 -0400
[Identity] What if we accepted the PEM certificate string contents? (#18017)
This PR serves to explore the idea of changing the public API of ClientCertificateCredential before we release v2, to allow users to either pass the path to a PEM certificate in the filesystem, or the string certificate contents directly.
.NET allows a similar set of alternatives (with more flexibility on the type of certificates than us): https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs#L96
This could help us provide a better experience for issues similar to #17715
Feedback appreciated 🙏
commit 68fbad61668f1423b76f22509c974e20af607e75
Author: Daniel Rodríguez <sadasant@users.noreply.github.com>
Date: Tue Oct 12 14:57:34 2021 -0400
[Identity] Removed AzureApplicationCredential from our public API (#18129)
* [Identity] Removed AzureApplicationCredential from our public API
* Apply suggestions from code review
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com>
commit 1e706fc1369b0ac2b5a064a4a667af54f9f00ae9
Author: Hiroshi Yoshioka <40815708+hyoshioka0128@users.noreply.github.com>
Date: Wed Oct 13 00:23:18 2021 +0900
Typo "Typescript"→"TypeScript" (#18141)
https://docs.microsoft.com/en-us/javascript/api/overview/azure/service-bus-readme?view=azure-node-latest
…
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 14, 2022
Review request for Microsoft.ContainerService to add version 2022-03-02-preview (Azure#18633) * Adds base for updating Microsoft.ContainerService from version preview/2022-02-02-preview to version 2022-03-02-preview * Updates readme * Updates API version in new specs and examples * feat: add `/rotateServiceAccountSigningKeys` API (Azure#18359) * feat: add `/rotateServiceAccountSigningKeys` API * chore: remove duplicated description * feat: add `workloadIdentity` settings to `SecurityProfile` (Azure#18360) * fix: update example name (Azure#18382) * add creationData to mc data (Azure#18414) * add creationData to mc data * fix test * fix format * Add API properties and example JSON for Web App Routing of IngressProfile (Azure#18564) * Add API properties and example JSON for Web App Routing of IngressProfile. * Add a ending period for description to match the style in all other "descriptions" in the same file. * Update readmes for the 2022-03-02-preview dev branch of container service (Azure#18358) * update readme * update sdk readmes * Agentpool alias minor version 2022-03-02-preview (Azure#18381) * Add field currentOrchestratorVersion to support Agentpool alias minor version * Add new exmaple for alias minor version * Remove example for PrettierCheck * Fix typo * Latest patch version supported is 1.22.7 at the moment * Address comments - refine descriptions for fields * feat: add ManagedCluster StorageProfile in 0302preview (Azure#18590) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Swagger change for ignore-pod-disruption-budget (Azure#18548) * Swagger change for ignore-pod-disruption-budget * Change ignorePodDisruptionBudget to string in example file. * Change ignorePodDisruptionBudget to boolean type. * add effectiveNoProxy for AKS (Azure#18544) * add effectiveNoProxy for AKS * add to correct api * fix lowercase -> uppercase O * spelling * Replace common type definitions with references since 2022-03-02-preview for Microsoft.ContainerService (Azure#18567) * replace Resource * replace SystemData * replace parameters * change track2 to python Co-authored-by: hbc <bcxxxxxx@gmail.com> Co-authored-by: Qingqing <qizhe@microsoft.com> Co-authored-by: Yi Zhang <yizhang5@microsoft.com> Co-authored-by: Thalia Wang <58485997+wenxuan0923@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: Tong Chen <45081443+tonche@users.noreply.github.com> Co-authored-by: Ace Eldeib <aleldeib@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.