-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update keyvault to enable live testing in sovereign clouds for multiple services #21717
Conversation
@benbp Could you please review this PR? |
@v-xuto pipeline changes look good to me, but I defer to a language owner for reviewing the test code changes. |
/azp run python - keyvault - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
@v-xuto assuming the tests pass is this ready to merge? It looks like there were some external dependency issues from yesterday's failure, so I'm re-running them. |
@benbp: I cancelled the run of "python - keyvault - tests-weekly". It was failing due to the DevOps cache task bug, and we're running low on agents due to provisioning issues. |
@v-xuto I think you'll have to rebase this PR with the latest |
@v-xuto Sorry about the failures! The As for the caching issue, that's something we're still working on. I made a temporary fix in the weekly tests pipeline, so re-running it should hopefully work. If it still fails, just let me know and we can provide an update when a more permanent fix is out. |
@v-xuto we could potentially be running to conflicts with other HSM jobs in the same region depending on when it's ran. There's a strict quota for HSM resources per region within the same subscription, so it's possible that's the issue. I'm re-running to see if it works again. |
@benbp This |
@mccoyp it seems the HSM tests on python in general are failing/timing out. I wonder if the issue might be that HSM tests are running for both keys and administration (https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/keyvault/tests.yml#L20), meaning it will try to provision two HSM resources in the same region+subscription causing quota issues/delays? |
@benbp True, I've been trying to figure out what's going on with HSM deployment for live pipelines. I don't think it's a quota issue; the service allowed five HSMs per region per subscription in preview, and there are usually no HSMs active in This build from 12/8 had some service-related failures, but HSMs got deployed correctly. Here is the The next day, on 12/9, resource deployment failed in this build. The test-resources.json file from the build commit is identical to the one from the day before, and both commits have the same I do think it could be a good idea to deploy only one HSM for pipeline testing, and it might resolve this issue if simultaneous deployment is the problem. |
@mccoyp perhaps we should try changing the HSM region and seeing if that works. Maybe there's a current issue in the westus region. Also if this is an active/known issue for public, I say we merge this PR to get the usgov/china testing going. |
I created a PR here to unblock HSM deployment |
Thanks @v-xuto! |
…le services (Azure#21717) * Update keyvault to enable live testing in sovereign clouds for multiple services * Add async test recordings * Add test_key_crud_operations recordings
…le services (Azure#21717) * Update keyvault to enable live testing in sovereign clouds for multiple services * Add async test recordings * Add test_key_crud_operations recordings
[Hub Generated] Publish private branch 'user/pri/2022-12-01' (Azure#21717) * add or modify files * Fixed spellcheck validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * Fixed avocado validation err * avacado fix * avacado fix * avacado fix * avacado fix' * avacado fix * avacado fix * revert custom-words.txt * update custom-words.txt * updated PreCheckResult * removed SystemData * removed SystemData Co-authored-by: Aditya Ravishankar <ravishankara@microsoft.com>
These changes enable keyvault to run live tests against Public, UsGov and China.
So skip the following tests:
test_key_client.py::KeyClientTests::test_key_crud_operations
,test_keys_async.py::KeyVaultKeyTest::test_key_crud_operations
,test_samples_keys.py::TestExamplesKeyVault::test_example_key_crud_operations
,test_samples_keys_async.py::TestExamplesKeyVault::test_example_key_crud_operations
So skip the following tests:
test_key_client.py::KeyClientTests::test_key_rotation
,test_key_client.py::KeyClientTests::test_key_rotation_policy
,test_keys_async.py::KeyVaultKeyTest::test_key_rotation
,test_keys_async.py::KeyVaultKeyTest::test_key_rotation_policy
So add code
MatrixFilters:ArmTemplateParameters=^(?!.*enableHsm.*true)
in UsGov and China cloudconfig in tests.yml.Pipeline results:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1194909&view=results
@benbp , @jameszliao-msft , @lmazuel , @AlexGhiondea , @chlowell for notification.