Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hid QQ Parquet from public API #21152

Merged
merged 4 commits into from
May 5, 2021
Merged

Hid QQ Parquet from public API #21152

merged 4 commits into from
May 5, 2021

Conversation

gapra-msft
Copy link
Member

No description provided.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label May 4, 2021
@gapra-msft
Copy link
Member Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@check-enforcer
Copy link

check-enforcer bot commented May 4, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@gapra-msft gapra-msft marked this pull request as ready for review May 4, 2021 19:53
jaschrep-msft
jaschrep-msft reviewed May 4, 2021
View reviewed changes
...e-storage-blob/src/main/java/com/azure/storage/blob/implementation/util/BlobQueryReader.java
@@ -231,12 +230,12 @@ public static QuerySerialization transformInputSerialization(BlobQuerySerializat
generatedFormat.setJsonTextConfiguration(transformJson(
(BlobQueryJsonSerialization) userSerialization));

} else if (userSerialization instanceof BlobQueryParquetSerialization) {
/*} else if (userSerialization instanceof BlobQueryParquetSerialization) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a TODO for why this is commented out?

jaschrep-msft
jaschrep-msft approved these changes May 4, 2021
View reviewed changes
...e-storage-blob/src/main/java/com/azure/storage/blob/implementation/util/BlobQueryReader.java
@@ -323,12 +322,12 @@ private static JsonTextConfiguration transformJson(BlobQueryJsonSerialization js
* @param parquetSerialization {@link BlobQueryParquetSerialization}
* @return {@link JsonTextConfiguration}
*/
private static Object transformParquet(BlobQueryParquetSerialization parquetSerialization) {
/*private static Object transformParquet(BlobQueryParquetSerialization parquetSerialization) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

...ge/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/Transforms.java
@@ -446,15 +444,15 @@ static BlobQuerySerialization toBlobQuerySerialization(FileQuerySerialization se
} else if (ser instanceof FileQueryArrowSerialization) {
FileQueryArrowSerialization arrSer = (FileQueryArrowSerialization) ser;
return new BlobQueryArrowSerialization().setSchema(toBlobQueryArrowSchema(arrSer.getSchema()));
} else if (ser instanceof FileQueryParquetSerialization) {
return new BlobQueryParquetSerialization();
/*} else if (ser instanceof FileQueryParquetSerialization) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@gapra-msft gapra-msft merged commit 74dbd5f into Azure:feature/storage/stg77 May 5, 2021
@gapra-msft gapra-msft deleted the storage/privateQQParquet branch May 5, 2021 15:55
gapra-msft added a commit that referenced this pull request May 7, 2021
@gapra-msft @rickle-msft @kasobol-msft
[Storage] Added features for STG77 (#21216)
7d25905 
* updated service version (#20260)

* Added back support to lease a share (#20327)

* Modified sas tests

* Added query parquet input serialization (#20305)

* Added support for HNS soft delete (#20353)

* re-record.

* fix that test.

* Hid QQ Parquet from public API (#21152)

* purge recordings.

* purge recordings.

* [Storage] Fix recordings. (#21172)

* nio

* blobs.

* recordings.

* exclusive access to service props.

* recording.

* Fix recordings. (#21186)

* purge recordings.

* fix recordings. (#21208)

* fix that test.

Co-authored-by: Rick Ley <frley@microsoft.com>
Co-authored-by: gapra <gapra@microsoft.com>
Co-authored-by: Kamil Sobol <kasobol@microsoft.com>
Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Oct 25, 2022
CodeGen from PR 21074 in Azure/azure-rest-api-specs
6e0485d 
Release appcomplianceautomation microsoft.app compliance automation 2022 11 16 preview 1 (Azure#21074)

* add appcomplianceautomation specs

* update appcomplianceautomation specs for 2022-11-16-preview

* remove privatepreview and beta (Azure#21124)

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>

* Release appcomplianceautomation microsoft.app compliance automation 2022 11 16 preview resolve comments 2 (Azure#21152)

* fix comments

* remove duplicate in body

* resolve comments

* edit examples to match schema

* fix failure

* fix model validation

* change passed to passedCount

* add x-ms-enum to isPass

* change delete 200 description

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>

* set sasUri x-ms-secret to true (Azure#21161)

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>

* remove properties from download request body (Azure#21184)

* remove properties from download request body

* remove properties in snapshot_resourcelist_download.json

* keep statuscode 201 and 202 in patch report response, due to RPSaas will change 202 to 201

* add body in patch report 201 response

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>

* change ProvisioningState Cancelled to Canceled, and some descriptions (Azure#21237)

* change ProvisioningState Cancelled to Canceled, and some descriptions

* add x-ms-enum extension to ComplianceState

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>

Co-authored-by: Yanwen Liu <yanwenliu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaschrep-msft jaschrep-msft jaschrep-msft approved these changes

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@kasobol-msft kasobol-msft Awaiting requested review from kasobol-msft

@rickle-msft rickle-msft Awaiting requested review from rickle-msft

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gapra-msft @jaschrep-msft @alzimmermsft