Added support for HNS soft delete #20353
Conversation
ghost
added
the
...le-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeFileSystemAsyncClient.java
Outdated
Show resolved
Hide resolved
...le-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeFileSystemAsyncClient.java
Show resolved
Hide resolved
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
kasobol-msft and
rickle-msft
as code owners
...le-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeFileSystemAsyncClient.java
Outdated
Show resolved
Hide resolved
...le-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeFileSystemAsyncClient.java
Show resolved
Hide resolved
| * @return A reactive response emitting the list of files/directories. | ||
| */ | ||
| @ServiceMethod(returns = ReturnType.COLLECTION) | ||
| public PagedFlux<PathDeletedItem> listDeletedPaths(String prefix) { |
There was a problem hiding this comment.
Is it really called a "prefix" in datalake? Isn't that more blob terminology, and we'd use "path" or "directory" for datalake?
There was a problem hiding this comment.
This was a comment from the arch board review. I think we want to call it prefix since technically you can provide a partial path here - like for all blobs that start with 'aa' (even if its a dir) you can just pass in 'aa'
| @@ -107,6 +117,14 @@ | |||
| .fileSystem(fileSystemName) | |||
| .version(serviceVersion.getVersion()) | |||
| .buildClient(); | |||
| String blobUrl = DataLakeImplUtils.endpointToDesiredEndpoint(url, "blob", "dfs"); | |||
| this.blobDataLakeStorageFs = new AzureDataLakeStorageRestAPIImplBuilder() | |||
There was a problem hiding this comment.
If I remember correctly, this is the first Blob API we are calling from the FileSystemClient.
* updated service version (#20260) * Added back support to lease a share (#20327) * Modified sas tests * Added query parquet input serialization (#20305) * Added support for HNS soft delete (#20353) * re-record. * fix that test. * Hid QQ Parquet from public API (#21152) * purge recordings. * purge recordings. * [Storage] Fix recordings. (#21172) * nio * blobs. * recordings. * exclusive access to service props. * recording. * Fix recordings. (#21186) * purge recordings. * fix recordings. (#21208) * fix that test. Co-authored-by: Rick Ley <frley@microsoft.com> Co-authored-by: gapra <gapra@microsoft.com> Co-authored-by: Kamil Sobol <kasobol@microsoft.com> Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com>
Original PR for private drop #19196