Added query parquet input serialization #20305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gapra-msft
commented
Mar 31, 2021
gapra-msft
commented
Mar 31, 2021
...azure-storage-file-datalake/src/test/java/com/azure/storage/file/datalake/FileAPITest.groovy
Outdated
Show resolved
Hide resolved
gapra-msft
requested review from
alzimmermsft,
amishra-dev,
jaschrep-msft,
kasobol-msft and
rickle-msft
as code owners
alzimmermsft
approved these changes
Apr 1, 2021
| } else { | ||
| throw logger.logExceptionAsError(new IllegalArgumentException( | ||
| String.format("'input' must be one of %s or %s", BlobQueryJsonSerialization.class.getSimpleName(), | ||
| BlobQueryDelimitedSerialization.class.getSimpleName()))); | ||
| String.format("'input' must be one of %s, %s or %s", BlobQueryJsonSerialization.class.getSimpleName(), |
There was a problem hiding this comment.
Are the allowed input types expected to continue growing? If so, I think it would be good to create external documentation somewhere and just have this error message point towards that.
There was a problem hiding this comment.
https://docs.microsoft.com/en-us/rest/api/storageservices/query-blob-contents#request-body
Below the example xml, there is a table explaining each parameter.
There was a problem hiding this comment.
Just updated the error message. @alzimmermsft can you take a quick look?
seanmcc-msft
approved these changes
Apr 1, 2021
...ure-storage-blob/src/main/java/com/azure/storage/blob/implementation/models/QueryFormat.java
Show resolved
Hide resolved
...e/azure-storage-blob/src/test/java/com/azure/storage/blob/specialized/BlobBaseAPITest.groovy
Show resolved
Hide resolved
gapra-msft
requested review from
ankitarorabit,
anuchandy,
backwind1233,
chenrujun,
ChenTanyi,
conniey,
danieljurek,
FabianMeiswinkel,
g2vinay,
hemanttanwar,
jialindai and
jianghaolu
as code owners
gapra-msft
requested review from
JimSuplizio,
JonathanGiles,
joshfree,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
minnieliu,
mitchdenny,
moderakh,
mrm9084,
mssfang,
pallavit,
samvaity,
saragluna,
simplynaveen20,
srnagar,
stliu,
weidongxu-microsoft,
weshaggard,
xseeseesee,
xinlian12,
yiliuTo,
yungezz and
a team
as code owners
gapra-msft
added a commit
that referenced
this pull request
May 7, 2021
* updated service version (#20260) * Added back support to lease a share (#20327) * Modified sas tests * Added query parquet input serialization (#20305) * Added support for HNS soft delete (#20353) * re-record. * fix that test. * Hid QQ Parquet from public API (#21152) * purge recordings. * purge recordings. * [Storage] Fix recordings. (#21172) * nio * blobs. * recordings. * exclusive access to service props. * recording. * Fix recordings. (#21186) * purge recordings. * fix recordings. (#21208) * fix that test. Co-authored-by: Rick Ley <frley@microsoft.com> Co-authored-by: gapra <gapra@microsoft.com> Co-authored-by: Kamil Sobol <kasobol@microsoft.com> Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Aug 22, 2022
[Nginx] Specify host and schemes (Azure#20305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.