-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added query parquet input serialization #20305
Added query parquet input serialization #20305
Conversation
...azure-storage-file-datalake/src/test/java/com/azure/storage/file/datalake/FileAPITest.groovy
Outdated
Show resolved
Hide resolved
} else { | ||
throw logger.logExceptionAsError(new IllegalArgumentException( | ||
String.format("'input' must be one of %s or %s", BlobQueryJsonSerialization.class.getSimpleName(), | ||
BlobQueryDelimitedSerialization.class.getSimpleName()))); | ||
String.format("'input' must be one of %s, %s or %s", BlobQueryJsonSerialization.class.getSimpleName(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the allowed input types expected to continue growing? If so, I think it would be good to create external documentation somewhere and just have this error message point towards that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.microsoft.com/en-us/rest/api/storageservices/query-blob-contents#request-body
Below the example xml, there is a table explaining each parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated the error message. @alzimmermsft can you take a quick look?
...ure-storage-blob/src/main/java/com/azure/storage/blob/implementation/models/QueryFormat.java
Show resolved
Hide resolved
...e/azure-storage-blob/src/test/java/com/azure/storage/blob/specialized/BlobBaseAPITest.groovy
Show resolved
Hide resolved
* updated service version (#20260) * Added back support to lease a share (#20327) * Modified sas tests * Added query parquet input serialization (#20305) * Added support for HNS soft delete (#20353) * re-record. * fix that test. * Hid QQ Parquet from public API (#21152) * purge recordings. * purge recordings. * [Storage] Fix recordings. (#21172) * nio * blobs. * recordings. * exclusive access to service props. * recording. * Fix recordings. (#21186) * purge recordings. * fix recordings. (#21208) * fix that test. Co-authored-by: Rick Ley <frley@microsoft.com> Co-authored-by: gapra <gapra@microsoft.com> Co-authored-by: Kamil Sobol <kasobol@microsoft.com> Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com>
[Nginx] Specify host and schemes (Azure#20305)
No description provided.