Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review request v3 for Microsoft.Portal to onboard to TypeSpec #29796

Conversation

sayeedalam-microsoft
Copy link
Contributor

@sayeedalam-microsoft sayeedalam-microsoft commented Jul 11, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • Onboarding Microsoft.Portal to TypeSpec

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Jul 11, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Jul 11, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 70 Warnings warning [Detail]
Compared specs (v0.10.12) new version base version
portal.json 2022-12-01-preview(c0a799d) 2020-09-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ 1009 - RemovedRequiredParameter The required parameter 'dashboard' was removed in the new version.
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L101:11
⚠️ 1009 - RemovedRequiredParameter The required parameter 'dashboard' was removed in the new version.
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L257:11
⚠️ 1010 - AddingRequiredParameter The required parameter 'resource' was added in the new version.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L453:11
⚠️ 1010 - AddingRequiredParameter The required parameter 'properties' was added in the new version.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L515:11
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L107:13
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L63:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/types.json#L404:11
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L655:11
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/types.json#L307:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L709:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/types.json#L282:11
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L733:11
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L630:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L591:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L725:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L411:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L694:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L465:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L827:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L490:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L843:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L494:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L853:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L498:17
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L694:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L465:9
⚠️ 1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L762:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L441:13
⚠️ 1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L729:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L450:9
⚠️ 1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L659:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L552:9
⚠️ 1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L804:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L573:9
⚠️ 1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L690:5
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L457:5
⚠️ 1022 - RemovedAdditionalProperties The new version removes the 'additionalProperties' element.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L786:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L573:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uri' than the previous one ''.
New: common-types/resource-management/v5/types.json#L413:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L663:9
⚠️ 1023 - TypeFormatChanged The new version has a different format '' than the previous one 'int32'.
New: common-types/resource-management/v5/types.json#L264:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L719:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L386:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L195:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L596:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L433:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L88:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L495:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L244:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L551:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L149:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L344:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L307:9
⚠️ 1023 - TypeFormatChanged The new version has a different format 'uri' than the previous one ''.
New: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L680:9
Old: Microsoft.Portal/preview/2020-09-01-preview/portal.json#L397:9
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 1 Errors, 3 Warnings failed [Detail]
Compared specs (v2.2.2) new version base version
package-2022-12-01-preview package-2022-12-01-preview(c0a799d) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
TenantLevelAPIsNotAllowed /providers/Microsoft.Portal/tenantConfigurations/{configurationName} is a tenant level api. Tenant level APIs are strongly discouraged and subscription or resource group level APIs are preferred instead. If you cannot model your APIs at these levels, you will need to present your design and get an exception from PAS team.
Location: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L164
⚠️ PreviewVersionOverOneYear The API version:2022-12-01-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L5
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listtenantconfigurationviolations' in:'ListTenantConfigurationViolationsOperations_List'. Consider updating the operationId
Location: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L58
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L965
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Jul 11, 2024

Swagger Generation Artifacts

️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
Rule Message
RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=440943&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
"detail":"Run.ps1 failed with exit code 1 "
️❌ azure-sdk-for-python failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 3ccbeb6d1573c8b5be28fbdcb5517633f012273d. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.2
    cmderr	[automation_init.sh] npm notice
    warn		Warning: cannot find emitter config for azure-sdk-for-python in tspconfig.yaml for typespec project specification/portal/Dashboard.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-sdk-for-python in tspconfig.yaml for typespec project specification/portal/TenantConfiguration.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmdout	[automation_generate.sh] [Autorest] https://aka.ms/autorest
    cmdout	[automation_generate.sh] [Autorest] info    | AutoRest core version selected from configuration: 3.10.2.
    cmdout	[automation_generate.sh] [Autorest]
    cmdout	[automation_generate.sh] [Autorest] There is a new version of AutoRest available (3.7.1).
    cmdout	[automation_generate.sh] [Autorest]  > You can install the newer version with with npm install -g autorest@latest
    cmdout	[automation_generate.sh] [Autorest]
    cmdout	[automation_generate.sh] [Autorest] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@autorestcore@3.10.2/nodemodules/@autorest/core/dist' (3.10.2)
    cmdout	[automation_generate.sh] [Autorest] info    |    Installing AutoRest extension '@autorest/modelerfour' (4.27.0 -> 4.27.0)
    cmdout	[automation_generate.sh] [Autorest] info    |    Installed AutoRest extension '@autorest/modelerfour' (4.27.0->4.27.0)
    cmdout	[automation_generate.sh] [Autorest] info    |    Installing AutoRest extension '@autorest/python' (6.15.0 -> 6.15.0)
    cmdout	[automation_generate.sh] [Autorest] info    |    Installed AutoRest extension '@autorest/python' (6.15.0->6.15.0)
    cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    cmdout	[automation_generate.sh] [Autorest] warning | SecurityDefinedSpecAndConfig | OpenAPI spec has a security definition but autorest security config is defined. Security config from autorest will be used.
    cmdout	[automation_generate.sh] [Autorest] error   | DuplicateOperation | Duplicate Operation 'Operations' > 'list' detected(This is most likely due to 2 operation using the same 'operationId' or 'tags'). Duplicates have those paths:
    cmdout	[automation_generate.sh] [Autorest]   - get /providers/Microsoft.Portal/operations
    cmdout	[automation_generate.sh] [Autorest]   - get /providers/Microsoft.Portal/operations
    cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 1 errors occured -- cannot continue.
    cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
    cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin checker reported failure.
    cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
    cmdout	[automation_generate.sh] [Autorest] AutoRest code generation utility [cli version: 3.6.1; node: v18.20.4]
    cmdout	[automation_generate.sh] [Autorest] (C) 2018 Microsoft Corporation.
    cmdout	[automation_generate.sh] [Autorest] https://aka.ms/autorest
    cmdout	[automation_generate.sh] [Autorest] info    | AutoRest core version selected from configuration: 3.10.2.
    cmdout	[automation_generate.sh] [Autorest]
    cmdout	[automation_generate.sh] [Autorest] There is a new version of AutoRest available (3.7.1).
    cmdout	[automation_generate.sh] [Autorest]  > You can install the newer version with with npm install -g autorest@latest
    cmdout	[automation_generate.sh] [Autorest]
    cmdout	[automation_generate.sh] [Autorest] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@autorestcore@3.10.2/nodemodules/@autorest/core/dist' (3.10.2)
    cmdout	[automation_generate.sh] [Autorest] info    |    Loading AutoRest extension '@autorest/modelerfour' (4.27.0->4.27.0)
    cmdout	[automation_generate.sh] [Autorest] info    |    Loading AutoRest extension '@autorest/python' (6.15.0->6.15.0)
    cmdout	[automation_generate.sh] [Autorest] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    cmdout	[automation_generate.sh] [Autorest] warning | SecurityDefinedSpecAndConfig | OpenAPI spec has a security definition but autorest security config is defined. Security config from autorest will be used.
    cmdout	[automation_generate.sh] [Autorest] error   | DuplicateOperation | Duplicate Operation 'Operations' > 'list' detected(This is most likely due to 2 operation using the same 'operationId' or 'tags'). Duplicates have those paths:
    cmdout	[automation_generate.sh] [Autorest]   - get /providers/Microsoft.Portal/operations
    cmdout	[automation_generate.sh] [Autorest]   - get /providers/Microsoft.Portal/operations
    cmdout	[automation_generate.sh] [Autorest] fatal   | Error: 1 errors occured -- cannot continue.
    cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
    cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin checker reported failure.
    cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
    cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 3ccbeb6d1573c8b5be28fbdcb5517633f012273d. SDK Automation 14.0.0
    command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    warn		Warning: cannot find emitter config for azure-sdk-for-java in tspconfig.yaml for typespec project specification/portal/Dashboard.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-sdk-for-java in tspconfig.yaml for typespec project specification/portal/TenantConfiguration.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-sdk-for-java in tspconfig.yaml for typespec project specification/portal/TenantConfiguration.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
  • ️✔️azure-resourcemanager-portal [Preview SDK Changes]
    info	[Changelog]
️❌ azure-sdk-for-go failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 3ccbeb6d1573c8b5be28fbdcb5517633f012273d. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    warn		Warning: cannot find emitter config for azure-sdk-for-go in tspconfig.yaml for typespec project specification/portal/Dashboard.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-sdk-for-go in tspconfig.yaml for typespec project specification/portal/TenantConfiguration.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    cmderr	[generator automation-v2] [ERROR] total 1 error(s):
    cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` 'WARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/portal/armportal
    cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/portal/armportal, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/portal/armportal
    cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/portal/armportal
    cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/portal/armportal
    cmderr	[generator automation-v2] [ERROR] autorest --use=@autorest/go@4.0.0-preview.63 --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/portal/armportal --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md
    cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v18.20.4]
    cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
    cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
    cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.7.1).
    cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
    cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@autorestcore@3.10.2/nodemodules/@autorest/core/dist' (3.10.2)
    cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/go' (4.0.0-preview.63 -> 4.0.0-preview.63)
    cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/go' (4.0.0-preview.63->4.0.0-preview.63)
    cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/modelerfour' (4.26.2 -> 4.26.2)
    cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/modelerfour' (4.26.2->4.26.2)
    cmderr	[generator automation-v2] [ERROR] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    cmderr	[generator automation-v2] [ERROR] warning | UsingTemporaryFlag | modelerfour.treat-type-object-as-anything options is a temporary flag. It WILL be removed in the future.
    cmderr	[generator automation-v2] [ERROR] warning | SecurityDefinedSpecAndConfig | OpenAPI spec has a security definition but autorest security config is defined. Security config from autorest will be used.
    cmderr	[generator automation-v2] [ERROR] error   | DuplicateOperation | Duplicate Operation 'Operations' > 'List' detected(This is most likely due to 2 operation using the same 'operationId' or 'tags'). Duplicates have those paths:
    cmderr	[generator automation-v2] [ERROR] - get /providers/Microsoft.Portal/operations
    cmderr	[generator automation-v2] [ERROR] - get /providers/Microsoft.Portal/operations
    cmderr	[generator automation-v2] [ERROR] fatal   | Error: 1 errors occured -- cannot continue.
    cmderr	[generator automation-v2] [ERROR] fatal   | Process() cancelled due to failure
    cmderr	[generator automation-v2] [ERROR] error   |   Error: Plugin checker reported failure.
    cmderr	[generator automation-v2] [ERROR] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
    cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
    cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1
    cmderr	[generator automation-v2] [ERROR] ': exit status 1
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️❌ azure-sdk-for-js failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 3ccbeb6d1573c8b5be28fbdcb5517633f012273d. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    cmderr	[automation_generate.sh] [ERROR] An error occurred while generating codes for readme file: "specification/portal/resource-manager/readme.md":
    cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: autorest --version=3.9.7 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/portal/resource-manager/readme.md --use=@autorest/typescript@^6.0.12
    cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
    cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
    cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: autorest --version=3.9.7 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/portal/resource-manager/readme.md --use=@autorest/typescript@^6.0.12
    cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:885:11)
    cmderr	[automation_generate.sh] [ERROR]     at execSync (node:child_process:957:15)
    cmderr	[automation_generate.sh] [ERROR]     at /home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:39:46
    cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
    cmderr	[automation_generate.sh] [ERROR]     at /home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:115:75
    cmderr	[automation_generate.sh] [ERROR]     at new Promise (<anonymous>)
    cmderr	[automation_generate.sh] [ERROR]     at Object.__awaiter (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:111:16)
    cmderr	[automation_generate.sh] [ERROR]     at generateMgmt (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:20:20)
    cmderr	[automation_generate.sh] [ERROR]     at /home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/autoGenerateInPipeline.js:46:55"
    cmderr	[automation_generate.sh] [ERROR] An error occurred while generating codes for readme file: "specification/portal/resource-manager/readme.md":
    cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: autorest --version=3.9.7 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/portal/resource-manager/readme.md --use=@autorest/typescript@^6.0.12
    cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
    cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
    cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: autorest --version=3.9.7 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/portal/resource-manager/readme.md --use=@autorest/typescript@^6.0.12
    cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:885:11)
    cmderr	[automation_generate.sh] [ERROR]     at execSync (node:child_process:957:15)
    cmderr	[automation_generate.sh] [ERROR]     at /home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:39:46
    cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
    cmderr	[automation_generate.sh] [ERROR]     at /home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:115:75
    cmderr	[automation_generate.sh] [ERROR]     at new Promise (<anonymous>)
    cmderr	[automation_generate.sh] [ERROR]     at Object.__awaiter (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:111:16)
    cmderr	[automation_generate.sh] [ERROR]     at generateMgmt (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/hlc/generateMgmt.js:20:20)
    cmderr	[automation_generate.sh] [ERROR]     at /home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/autoGenerateInPipeline.js:46:55"
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-js]: sh .scripts/automation_generate.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    warn		Warning: cannot find emitter config for azure-sdk-for-js in tspconfig.yaml for typespec project specification/portal/Dashboard.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-sdk-for-js in tspconfig.yaml for typespec project specification/portal/Dashboard.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-sdk-for-js in tspconfig.yaml for typespec project specification/portal/TenantConfiguration.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-sdk-for-js in tspconfig.yaml for typespec project specification/portal/TenantConfiguration.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-sdk-for-js in tspconfig.yaml for typespec project specification/portal/TenantConfiguration.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 3ccbeb6d1573c8b5be28fbdcb5517633f012273d. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.2
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    warn		Warning: cannot find emitter config for azure-resource-manager-schemas in tspconfig.yaml for typespec project specification/portal/Dashboard.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-resource-manager-schemas in tspconfig.yaml for typespec project specification/portal/Dashboard.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-resource-manager-schemas in tspconfig.yaml for typespec project specification/portal/TenantConfiguration.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-resource-manager-schemas in tspconfig.yaml for typespec project specification/portal/TenantConfiguration.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-resource-manager-schemas in tspconfig.yaml for typespec project specification/portal/TenantConfiguration.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
️️✔️ azure-powershell succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 3ccbeb6d1573c8b5be28fbdcb5517633f012273d. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    warn		Warning: cannot find emitter config for azure-powershell in tspconfig.yaml for typespec project specification/portal/Dashboard.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    warn		Warning: cannot find emitter config for azure-powershell in tspconfig.yaml for typespec project specification/portal/TenantConfiguration.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.portal.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@sayeedalam-microsoft
Copy link
Contributor Author

@arm Reviewer
Please approve and advise with the suppression process.

Getting Swagger LintDiff error. TenantLevelAPIsNotAllowed

We got the exception from the PAS team:
image

@raosuhas
Copy link

@sayeedalam-microsoft the exception looks good to me. But if you are upgrading to typespec , then please do it in place for an existing versions. Do not combine a typespec conversion PR with a version upgrade PR

@raosuhas raosuhas added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 18, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 18, 2024
@sayeedalam-microsoft sayeedalam-microsoft changed the title Review request v2 for Microsoft.Portal to add version preview/2022-12-01-preview Review request v3 for Microsoft.Portal to onboard to TypeSpec Jul 19, 2024
@sayeedalam-microsoft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sayeedalam-microsoft sayeedalam-microsoft added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jul 30, 2024
@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 1, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 1, 2024
@sayeedalam-microsoft sayeedalam-microsoft added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Aug 1, 2024
@allenjzhang
Copy link
Member

allenjzhang commented Aug 2, 2024

Here is my analysis on the flagged cross version breaking change:

1009 - RemovedRequiredParameter

**Actionable:**

The required parameter 'dashboard' was removed in the new version.
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/portal/resource-manager/Microsoft.Portal/preview/2020-09-01-preview/portal.json#L101:11

If you are still using autorest:
You can use following to keep swagger same

`@@encodedName(Dashboards.createOrUpdate::parameters.resource, "application/json", "dashboard");`

AND

You should use @clientName to keep the body param same in old SDK. https://azure.github.io/typespec-azure/docs/howtos/migrate-swagger/migrate-arm-tips#changing-the-names-of-request-payload-parameters

1010 - AddingRequiredParameter

The required parameter 'properties' was added in the new version.
[Microsoft.Portal/preview/2022-12-01-preview/portal.json#L515:11](https://github.com/Azure/azure-rest-api-specs/blob/c0a799df9939935eca1b6db1eb6bd9ed55c7468c/specification/portal/resource-manager/Microsoft.Portal/preview/2022-12-01-preview/portal.json#L515:11)

1017 - ReferenceRedirection

- There are a few such as error can be ignored, since old custom ErrorDefinition is standardized to ErrorDetail.
- There are some due to rename such as `DashboardPropertiesWithProvisioningState` vs `DashboardProperties`. You would need to decide whether to keep the same or incurr SDK changes. Again, @clientName can be used to shape the SDK while @encodedName to shape swagger
- 

1022 - RemovedAdditionalProperties

**Actions Needed**

You should use `metadata? : Record<unknown>` instead of `metadata? : {}`.

1023 - TypeFormatChanged

Ignore This may create SDK changes. But it may be right to go to common types v5 standard over custom forked common definitions.

1025 - RequiredStatusChange

Ignore

1026 - TypeChanged

**Action/Review needed**
-  The new version has a different type 'boolean' than the previous one 'string'.
-  The new version has a different type 'string' than the previous one 'integer'.

1029 - ReadonlyPropertyChanged

Ignore: Possbile SDK impact, but can't fix

1032 - DifferentAllOf

Ignore: Standardizing to common-type via allof

1034 - AddedRequiredProperty

Ignore: page.value is now required but it is a response model.

1036 - ConstraintChanged

Ignore: Refinement on the dashboardName regEx patterns. Non-sdk impact anyway.

1038 - AddedPath

Ignore: I assume new version added new `tenantConfiguration` operations was intentional

1040 - AddedReadOnlyPropertyInResponse

Ignore: You have redefined standard types in your swagger instead of ref to common-types. They are removed now.

1048 - AddedXmsEnum

Ignore: Refinement of string type into extensible string based enum

1007 - RemovedClientParameter

Ignore:  TypeSpec inline the parameter

1012 - RemovedResponseCode

Ignore. No need to declare standard 404 

1045 - AddedOptionalProperty

Ignore: Old definition was not up to date.

@sayeedalam-microsoft sayeedalam-microsoft merged commit 38865af into Azure:main Aug 5, 2024
28 of 30 checks passed
@sayeedalam-microsoft sayeedalam-microsoft deleted the add-api-version-microsoft-portal-2022-12-01-preview-v2 branch August 6, 2024 20:46
@danielrbradley
Copy link

@sayeedalam-microsoft please could you clarify if the lense part metadata type can really only be Extension/HubsExtension/PartType/MarkdownPart or if there are other possible valid values such as Extension/HubsExtension/PartType/ArgQuerySingleValueTile, Extension/HubsExtension/PartType/ArgQueryChartTile and Extension/HubsExtension/PartType/ArgQueryGridTile?

Could we add all possible valid values to the specification, or otherwise broaden this field to be of type string to avoid flagging valid fields as errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants