Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review request v3 for Microsoft.Portal to onboard to TypeSpec #29796

Iteration#2: Adding the typespec

c0a799d
Select commit
Loading
Failed to load commit list.
Merged

Review request v3 for Microsoft.Portal to onboard to TypeSpec #29796

Iteration#2: Adding the typespec
c0a799d
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff failed Jul 11, 2024 in 5m 0s

Swagger LintDiff failed

LintDiff: 1 Errors, 3 Warnings
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.2) new version base version
package-2022-12-01-preview package-2022-12-01-preview(c0a799d) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
TenantLevelAPIsNotAllowed /providers/Microsoft.Portal/tenantConfigurations/{configurationName} is a tenant level api. Tenant level APIs are strongly discouraged and subscription or resource group level APIs are preferred instead. If you cannot model your APIs at these levels, you will need to present your design and get an exception from PAS team.
Location: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L164
⚠️ PreviewVersionOverOneYear The API version:2022-12-01-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L5
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listtenantconfigurationviolations' in:'ListTenantConfigurationViolationsOperations_List'. Consider updating the operationId
Location: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L58
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.Portal/preview/2022-12-01-preview/portal.json#L965