-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relay: Removed the maxLength for entity names #1535
Conversation
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues Send feedback and make AutoRest Linter Azure Bot smarter day by day! Thanks for your co-operation. |
@@ -2181,7 +2181,6 @@ | |||
"required": true, | |||
"type": "string", | |||
"minLength": 1, | |||
"maxLength": 50, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any maximum length at all for these? 2gb? 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
No modification for AutorestCI/azure-sdk-for-ruby |
No modification for AutorestCI/azure-sdk-for-python |
No modification for AutorestCI/azure-sdk-for-node |
…d balancer (#1528) * Updating documentation for Microsoft.VisualStudio with project resource APIs. Corrections to existing examples. (#1498) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs (#1502) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs * Updated tag names * Microsoft.Sql - Added data sync to package-2015-05-preview (#1510) * Added advisors and data sync to package-2015-05-preview * Removed advisors so current branch is only data sync * Make MsDeploy and MsDeployLog Azure resources (#1519) * Add public certificates, Functions Admin Token and MSDeploy APIs * Revert resource definition changes and description change for site properties * Make type and name readonly properties. Add ARM envelope to MSDeployStatus object * Fix missing quotation issue. * Add long running operation to MS deploy * Make MsDeploy and MsDeployLog Azure resources * Fix some AutoRest validation issues. Use dictionary for msdeploy.setparameters * Ensure models are same across all schemas in Microsoft.Web * Fix azure resource type across all models * Remove conflicting ListOperations. It is not used for public Azure. * no YAML in glob patterns for report scripts * Copying 2017-06-01 to 2017-08-01 * Changes for new API version * Updated script to run autorest with grouping swaggers based on config file (#1529) * Removed the maxLength for entities (#1527) * Update folder structure example. (#1489) Agreed on the changes * [Travis-ci] Oad in ci status (#1520) * Breaking change build should fail if result contains error Skipping newly added files Incorporating review feedback * testing * log the result as oad.compare returns promise for caller * Use published oad * Revert "testing" This reverts commit a9be94d. * Removed maxLength from entity name (#1531) * This is to add Cognitive Services data-plane API specs starting with Face API. (#1467) * Adding data plane spec starting with Face * Move Spec to right folder * Fixing validation issues. * Fixing issues and adding a readme.md * Fixing examples by removing decimals. * Removing another decimal value * Update readme.md * Updating spec based on comments. * Removing .gitignore. * Relay: Removed the maxLength for entity names (#1535)
…d balancer (#1528) (#1543) * Updating documentation for Microsoft.VisualStudio with project resource APIs. Corrections to existing examples. (#1498) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs (#1502) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs * Updated tag names * Microsoft.Sql - Added data sync to package-2015-05-preview (#1510) * Added advisors and data sync to package-2015-05-preview * Removed advisors so current branch is only data sync * Make MsDeploy and MsDeployLog Azure resources (#1519) * Add public certificates, Functions Admin Token and MSDeploy APIs * Revert resource definition changes and description change for site properties * Make type and name readonly properties. Add ARM envelope to MSDeployStatus object * Fix missing quotation issue. * Add long running operation to MS deploy * Make MsDeploy and MsDeployLog Azure resources * Fix some AutoRest validation issues. Use dictionary for msdeploy.setparameters * Ensure models are same across all schemas in Microsoft.Web * Fix azure resource type across all models * Remove conflicting ListOperations. It is not used for public Azure. * no YAML in glob patterns for report scripts * Copying 2017-06-01 to 2017-08-01 * Changes for new API version * Updated script to run autorest with grouping swaggers based on config file (#1529) * Removed the maxLength for entities (#1527) * Update folder structure example. (#1489) Agreed on the changes * [Travis-ci] Oad in ci status (#1520) * Breaking change build should fail if result contains error Skipping newly added files Incorporating review feedback * testing * log the result as oad.compare returns promise for caller * Use published oad * Revert "testing" This reverts commit a9be94d. * Removed maxLength from entity name (#1531) * This is to add Cognitive Services data-plane API specs starting with Face API. (#1467) * Adding data plane spec starting with Face * Move Spec to right folder * Fixing validation issues. * Fixing issues and adding a readme.md * Fixing examples by removing decimals. * Removing another decimal value * Update readme.md * Updating spec based on comments. * Removing .gitignore. * Relay: Removed the maxLength for entity names (#1535)
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger