Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relay : Removed the maxLength for entity names #3587

Merged
merged 3 commits into from
Aug 16, 2017
Merged

Relay : Removed the maxLength for entity names #3587

merged 3 commits into from
Aug 16, 2017

Conversation

v-Ajnava
Copy link
Member

Description

Removed the MaxLength for entity names.
swagger PR Link : Azure/azure-rest-api-specs#1535

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@shahabhijeet
Copy link
Member

@v-Ajnava no tests?

shahabhijeet
shahabhijeet suggested changes Aug 16, 2017
View reviewed changes
Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the AssemblyFileVersion is updated, this PR is good to go

src/SDKs/Relay/Management.Relay/Properties/AssemblyInfo.cs Outdated
@@ -8,7 +8,7 @@
[assembly: AssemblyTitle("Microsoft Azure Relay Management Library")]
[assembly: AssemblyDescription("Provides Microsoft Azure Relay management functions for managing the Microsoft Azure Relay service")]

[assembly: AssemblyVersion("2.0.0.0")]
[assembly: AssemblyVersion("2.0.1.0")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-Ajnava usually you always bump up file version and only bump up AssemblyVersion when you bump up major version.

@shahabhijeet shahabhijeet merged commit 95a1126 into Azure:psSdkJson6 Aug 16, 2017
JasonYang-MSFT pushed a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
@JasonYang-MSFT
Relay : Removed the maxLength for entity names (Azure#3587)
765681d 
* Removed the maxLength for entity names

* added test for maxlength removal

* updated the AssemblyFileVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-Ajnava @shahabhijeet @msftclas