Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs #1502

DheerendraRathor · 2017-08-03T15:05:10Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkciprbot · 2017-08-03T15:27:39Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/recoveryservicesbackup/resource-manager/readme.md
Before the PR: Warning(s): 45 Error(s): 17
After the PR: Warning(s): 48 Error(s): 17

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

jhendrixMSFT · 2017-08-03T23:35:34Z

specification/recoveryservicesbackup/resource-manager/readme.md

@@ -38,8 +40,9 @@ license-header: MICROSOFT_MIT

 These settings apply only when `--tag=package-2016-12` is specified on the command line.


Need to update the tag name to match below.

jhendrixMSFT · 2017-08-03T23:37:19Z

...yservicesbackup/resource-manager/Microsoft.RecoveryServices/2016-12-01/backupManagement.json

@@ -1107,101 +1104,6 @@
        "deprecated": false
      }
    },
-    "/Subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.RecoveryServices/vaults/{vaultName}/backupJobs": {


Why is this (and other) API removed?

They are moved to new file jobs.json with new API version as current one were buggy for Python SDK and Azure CLI.

Buggy on which side, the swagger, REST endpoint (or both)? The removal will introduce breaking changes for clients using this API version. Usually the pattern here is to fix the APIs in a new version and deprecate the existing ones so that clients don't break and can migrate to the new ones.

It was buggy on service side which led to broken Python SDK. This change won't break any existing client code using REST APIs directly as old API version is still present in service. Also it won't be a breaking change for SDK users as only serialization of duration is changed in service code which is handled by generated SDKs internally.

And I don't see how keeping both API versions helps here, Autorest currently doesn't support multiple API versions for same API.

Autorest does support multiple API versions however today not all SDKs make them available (this is slowly changing).
Regardless there appears to be other breaking changes here as well, e.g. when I diff backupManagement.json and jobs.json I see a lot of removed operations. What happened to them?

@jhendrixMSFT I don't get it. What other operations are removed? There are just 2 operations removed from backupManagement.json and both are added to jobs.json with new api version.

Sigh you are right, I've been comparing the wrong stuff. :( Sorry for the noise I should have this wrapped up shortly.

azuresdkciprbot · 2017-08-04T05:40:37Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/recoveryservicesbackup/resource-manager/readme.md
Before the PR: Warning(s): 45 Error(s): 17
After the PR: Warning(s): 48 Error(s): 17

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

jhendrixMSFT · 2017-08-07T16:40:04Z

specification/recoveryservicesbackup/resource-manager/readme.md

 input-file:
+- Microsoft.RecoveryServices/2017-07-01/jobs.json
 - Microsoft.RecoveryServices/2016-12-01/backupManagement.json


If this swagger is being deleted then you need to remove it from the yaml.

Didn't understand this point either. Swagger is not deleted, only api version for 2 operations has been updated. Those two operations have been moved to jobs.json.
So as a whole number of operations are constant, just 2 operations have new api version.

My mistake, I didn't read close enough.

jhendrixMSFT · 2017-08-07T18:11:38Z

...tion/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/2017-07-01/jobs.json

+            "type": "string"
+          }
+        },
+        "eTag": {


The linter is complaining about this casing, see https://travis-ci.org/Azure/azure-rest-api-specs/jobs/260887527. I believe the casing should be "etag" and looking at other swaggers would appear to confirm.

It is due to a bug introduced here Azure/autorest#2152 (comment) . A PR Azure/azure-openapi-validator#85 has been opened for fix in Autorest.

AutorestCI · 2017-08-09T15:19:45Z

Azure/azure-sdk-for-python#1354

AutorestCI · 2017-08-09T15:19:53Z

Azure/azure-sdk-for-ruby#886

AutorestCI · 2017-08-09T15:20:02Z

No modification for AutorestCI/azure-sdk-for-node

…d balancer (#1528) * Updating documentation for Microsoft.VisualStudio with project resource APIs. Corrections to existing examples. (#1498) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs (#1502) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs * Updated tag names * Microsoft.Sql - Added data sync to package-2015-05-preview (#1510) * Added advisors and data sync to package-2015-05-preview * Removed advisors so current branch is only data sync * Make MsDeploy and MsDeployLog Azure resources (#1519) * Add public certificates, Functions Admin Token and MSDeploy APIs * Revert resource definition changes and description change for site properties * Make type and name readonly properties. Add ARM envelope to MSDeployStatus object * Fix missing quotation issue. * Add long running operation to MS deploy * Make MsDeploy and MsDeployLog Azure resources * Fix some AutoRest validation issues. Use dictionary for msdeploy.setparameters * Ensure models are same across all schemas in Microsoft.Web * Fix azure resource type across all models * Remove conflicting ListOperations. It is not used for public Azure. * no YAML in glob patterns for report scripts * Copying 2017-06-01 to 2017-08-01 * Changes for new API version * Updated script to run autorest with grouping swaggers based on config file (#1529) * Removed the maxLength for entities (#1527) * Update folder structure example. (#1489) Agreed on the changes * [Travis-ci] Oad in ci status (#1520) * Breaking change build should fail if result contains error Skipping newly added files Incorporating review feedback * testing * log the result as oad.compare returns promise for caller * Use published oad * Revert "testing" This reverts commit a9be94d. * Removed maxLength from entity name (#1531) * This is to add Cognitive Services data-plane API specs starting with Face API. (#1467) * Adding data plane spec starting with Face * Move Spec to right folder * Fixing validation issues. * Fixing issues and adding a readme.md * Fixing examples by removing decimals. * Removing another decimal value * Update readme.md * Updating spec based on comments. * Removing .gitignore. * Relay: Removed the maxLength for entity names (#1535)

…d balancer (#1528) (#1543) * Updating documentation for Microsoft.VisualStudio with project resource APIs. Corrections to existing examples. (#1498) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs (#1502) * Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs * Updated tag names * Microsoft.Sql - Added data sync to package-2015-05-preview (#1510) * Added advisors and data sync to package-2015-05-preview * Removed advisors so current branch is only data sync * Make MsDeploy and MsDeployLog Azure resources (#1519) * Add public certificates, Functions Admin Token and MSDeploy APIs * Revert resource definition changes and description change for site properties * Make type and name readonly properties. Add ARM envelope to MSDeployStatus object * Fix missing quotation issue. * Add long running operation to MS deploy * Make MsDeploy and MsDeployLog Azure resources * Fix some AutoRest validation issues. Use dictionary for msdeploy.setparameters * Ensure models are same across all schemas in Microsoft.Web * Fix azure resource type across all models * Remove conflicting ListOperations. It is not used for public Azure. * no YAML in glob patterns for report scripts * Copying 2017-06-01 to 2017-08-01 * Changes for new API version * Updated script to run autorest with grouping swaggers based on config file (#1529) * Removed the maxLength for entities (#1527) * Update folder structure example. (#1489) Agreed on the changes * [Travis-ci] Oad in ci status (#1520) * Breaking change build should fail if result contains error Skipping newly added files Incorporating review feedback * testing * log the result as oad.compare returns promise for caller * Use published oad * Revert "testing" This reverts commit a9be94d. * Removed maxLength from entity name (#1531) * This is to add Cognitive Services data-plane API specs starting with Face API. (#1467) * Adding data plane spec starting with Face * Move Spec to right folder * Fixing validation issues. * Fixing issues and adding a readme.md * Fixing examples by removing decimals. * Removing another decimal value * Update readme.md * Updating spec based on comments. * Removing .gitignore. * Relay: Removed the maxLength for entity names (#1535)

msftclas added the cla-not-required label Aug 3, 2017

Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs

e46e012

DheerendraRathor force-pushed the current branch from f781070 to e46e012 Compare August 3, 2017 15:14

azuresdkci assigned jhendrixMSFT Aug 3, 2017

jhendrixMSFT reviewed Aug 3, 2017

View reviewed changes

Updated tag names

3b4f156

jhendrixMSFT reviewed Aug 7, 2017

View reviewed changes

jhendrixMSFT mentioned this pull request Aug 7, 2017

Operations moved into separate swagger with new API version should not be a breaking change Azure/openapi-diff#89

Open

jhendrixMSFT approved these changes Aug 9, 2017

View reviewed changes

jhendrixMSFT merged commit 52649c0 into Azure:current Aug 9, 2017

AutorestCI mentioned this pull request Aug 9, 2017

[RecoveryServicesBackup] Added Api-Version 2017-07-01 Azure/azure-sdk-for-python#1354

Merged

AutorestCI mentioned this pull request Aug 9, 2017

Automatic PR from RestAPI-PR1502 Azure/azure-sdk-for-ruby#886

Closed

DheerendraRathor mentioned this pull request Aug 9, 2017

Updated RecoveryServices.Backup from latest swagger spec Azure/azure-sdk-for-net#3566

Merged

8 tasks

gmainar mentioned this pull request Aug 14, 2017

New API Version 2017-08-01: Adding Sku property into publicIP and loa… #1543

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs #1502

Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs #1502

DheerendraRathor commented Aug 3, 2017 •

edited by azuresdkci

Loading

azuresdkciprbot commented Aug 3, 2017

jhendrixMSFT Aug 3, 2017

jhendrixMSFT Aug 3, 2017

DheerendraRathor Aug 4, 2017

jhendrixMSFT Aug 4, 2017

DheerendraRathor Aug 5, 2017

jhendrixMSFT Aug 7, 2017

DheerendraRathor Aug 7, 2017

jhendrixMSFT Aug 7, 2017

azuresdkciprbot commented Aug 4, 2017

jhendrixMSFT Aug 7, 2017

DheerendraRathor Aug 7, 2017

jhendrixMSFT Aug 7, 2017

jhendrixMSFT Aug 7, 2017

DheerendraRathor Aug 9, 2017 •

edited

Loading

AutorestCI commented Aug 9, 2017

AutorestCI commented Aug 9, 2017

AutorestCI commented Aug 9, 2017

		@@ -38,8 +40,9 @@ license-header: MICROSOFT_MIT

		These settings apply only when `--tag=package-2016-12` is specified on the command line.

Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs #1502

Added Api-Version 2017-07-01 for RecoveryServices.Backup Jobs #1502

Conversation

DheerendraRathor commented Aug 3, 2017 • edited by azuresdkci Loading

PR information

Quality of Swagger

azuresdkciprbot commented Aug 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

azuresdkciprbot commented Aug 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DheerendraRathor Aug 9, 2017 • edited Loading

Choose a reason for hiding this comment

AutorestCI commented Aug 9, 2017

AutorestCI commented Aug 9, 2017

AutorestCI commented Aug 9, 2017

DheerendraRathor commented Aug 3, 2017 •

edited by azuresdkci

Loading

DheerendraRathor Aug 9, 2017 •

edited

Loading