refactor java worker - add middleware support #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kaibocai
requested review from
anirudhgarg,
TsuyoshiUshio,
amamounelsayed and
shreyas-gopalakrishna
as code owners
trask
reviewed
Sep 22, 2022
src/main/java/com/microsoft/azure/functions/worker/binding/BindingDataStore.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Sep 22, 2022
src/main/java/com/microsoft/azure/functions/worker/binding/BindingDataStore.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Sep 22, 2022
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Show resolved
Hide resolved
trask
reviewed
Sep 22, 2022
src/main/java/com/microsoft/azure/functions/worker/broker/FactoryJavaMethodExecutor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/FunctionDefinition.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/JavaFunctionBroker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/JavaFunctionBroker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/JavaMethodExecutorImpl.java
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/MethodBindInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/MethodBindInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/MethodBindInfo.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/ParamBindInfo.java
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/exception/FunctionBaseException.java
Outdated
Show resolved
Hide resolved
trask
previously approved these changes
Sep 23, 2022
src/main/java/com/microsoft/azure/functions/worker/broker/JavaMethodExecutorImpl.java
Outdated
Show resolved
Hide resolved
* middleware support logics * refactor code * rename middleware chain * refactor code * fix error * refactor code * minor updates * remove used local varaible * APIs change accordingly * update method name * update method name
kaibocai
force-pushed
the
kaibocai/de-java811
branch
from
6eb147d to
9547726
Compare
|
rebase the dev branch |
This was referenced Sep 27, 2022
kaibocai
changed the title
shreyas-gopalakrishna
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
This PR include two features:
1st feature
mainly decoupled function definition (build at function load request processing) and function executor (build at invocation request process). It includes updates as below
FunctionLoadRequest, now updated the logic to build the executor atInvocationRequest.ExecutionContextDataSourceclass topublic, as this class is only used internal in java worker, it should cause any issue on changing it's scope topublic.ExecutionContextDataSourceto use builder pattern as it has to many arguments in old constructor.dataStore,methodBindInfo,containingClasstoExecutionContextDataSource, since decoupled the function definition and function executor, now function executor relies onExecutionContextDataSourceto get all required objects.MethodBindInfo,ParamBindInfofrom nested class to top class as they are used by other class besides their parent class.2nd feature
Add support for middleware.
This PR along with core library PR #11 and durable java sdk PR #87 resolve #595
Pull request checklist
release_notes.mdAdditional information
Additional PR information