Skip to content

middleware support logics #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 27, 2022
Merged

Conversation

kaibocai
Copy link
Member

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from joint review with Kaibo and Sreyas

@kaibocai kaibocai force-pushed the kaibocai/middleware-pr2 branch from 2d2e78a to 207f3cc Compare September 23, 2022 20:09
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from joint review with @kaibocai @shreyas-gopalakrishna

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can discuss/review the Optional usage on the API pr

@kaibocai kaibocai merged commit 6eb147d into kaibocai/de-java811 Sep 27, 2022
@kaibocai kaibocai deleted the kaibocai/middleware-pr2 branch September 27, 2022 22:28
kaibocai added a commit that referenced this pull request Sep 27, 2022
* middleware support logics

* refactor code

* rename middleware chain

* refactor code

* fix error

* refactor code

* minor updates

* remove used local varaible

* APIs change accordingly

* update method name

* update method name
shreyas-gopalakrishna pushed a commit that referenced this pull request Oct 5, 2022
* decouple function definition and function executor

* add function exceptions

* remove unnecessary synchronized block

* review updates

* fix invocatioid error

* rename factory get method

* middleware support logics (#659)

* middleware support logics

* refactor code

* rename middleware chain

* refactor code

* fix error

* refactor code

* minor updates

* remove used local varaible

* APIs change accordingly

* update method name

* update method name

* update core lib version to 1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants