-
Notifications
You must be signed in to change notification settings - Fork 64
middleware support logics #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fa09cbd
to
2d2e78a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from joint review with Kaibo and Sreyas
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/JavaFunctionBroker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
2d2e78a
to
207f3cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from joint review with @kaibocai @shreyas-gopalakrishna
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/ParameterResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/JavaFunctionBroker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/JavaFunctionBroker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/JavaFunctionBroker.java
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/JavaFunctionBroker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/JavaFunctionBroker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/JavaFunctionBroker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/broker/JavaFunctionBroker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/chain/InvocationChain.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can discuss/review the Optional
usage on the API pr
src/main/java/com/microsoft/azure/functions/worker/binding/ExecutionContextDataSource.java
Outdated
Show resolved
Hide resolved
* middleware support logics * refactor code * rename middleware chain * refactor code * fix error * refactor code * minor updates * remove used local varaible * APIs change accordingly * update method name * update method name
* decouple function definition and function executor * add function exceptions * remove unnecessary synchronized block * review updates * fix invocatioid error * rename factory get method * middleware support logics (#659) * middleware support logics * refactor code * rename middleware chain * refactor code * fix error * refactor code * minor updates * remove used local varaible * APIs change accordingly * update method name * update method name * update core lib version to 1.1.0
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
release_notes.md
Additional information
Additional PR information