Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding endpoint type option to the extension #1241

Merged
merged 17 commits into from
Feb 23, 2020

Conversation

rakeshvanga
Copy link
Contributor

@rakeshvanga rakeshvanga commented Feb 4, 2020


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/rakeshvanga/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

@rakeshvanga rakeshvanga changed the title Adding endpoint type option to the extension [Don't Merge] Adding endpoint type option to the extension Feb 4, 2020
Copy link
Contributor

@amsoedal amsoedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rakeshvanga rakeshvanga changed the title [Don't Merge] Adding endpoint type option to the extension Adding endpoint type option to the extension Feb 11, 2020
@rakeshvanga
Copy link
Contributor Author

rakeshvanga commented Feb 18, 2020

This PR is ready to be checked in. @zikalino can you merge these changes?
The only thing that is left is to update the blob with the correct whl file. I'm not doing that since there might be other changes still left. Once the pr is approved, I would update the whl file in storage blob.

Copy link
Contributor

@haroldrandom haroldrandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to re-build and re-upload wheel to you private contianer.
image

@rakeshvanga
Copy link
Contributor Author

You may need to re-build and re-upload wheel to you private contianer.
image

Updated the latest whl file to our container. @haroldrandom , can you review and merge it now?

@haroldrandom
Copy link
Contributor

Sure, but why added label “do not merge”?

@rakeshvanga
Copy link
Contributor Author

rakeshvanga commented Feb 21, 2020

@zikalino added this label due to miscommunication. There is no need to wait on this PR.

@haroldrandom haroldrandom merged commit 21f17ae into Azure:master Feb 23, 2020
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants