Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding endpoint type option to the extension #1241

Merged
merged 17 commits into from
Feb 23, 2020
Merged

Adding endpoint type option to the extension #1241

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e31d63c
adding endpoint type to cli changes.
rakeshvanga Feb 4, 2020
5107363
fixed linter errors/warnings
rakeshvanga Feb 4, 2020
a4ff7f9
update version.
rakeshvanga Feb 5, 2020
619124e
Register the endpoint type list in the extension.
rakeshvanga Feb 7, 2020
4a716b7
Updated index.json to pick up the latest extension
rakeshvanga Feb 11, 2020
0dad002
adding the missing sha256 digest
rakeshvanga Feb 11, 2020
6c090f6
updated the min version of the ext
rakeshvanga Feb 11, 2020
956d8f0
Merge branch 'master' into master
rakeshvanga Feb 12, 2020
707311b
use lower case alphabets for digest
rakeshvanga Feb 12, 2020
a6bde18
Merge branch 'master' of https://github.com/rakeshvanga/azure-cli-ext…
rakeshvanga Feb 12, 2020
75de429
remove the minCoreCliVersion on az cli
rakeshvanga Feb 13, 2020
610b873
Set the min Version to 81
rakeshvanga Feb 18, 2020
3003b2d
Merge branch 'master' into master
Feb 20, 2020
216de55
update to latest version
rakeshvanga Feb 20, 2020
d7fea6c
Merge branch 'master' of https://github.com/rakeshvanga/azure-cli-ext…
rakeshvanga Feb 21, 2020
d430998
Merge branch 'master' into master
Feb 22, 2020
95c500c
Merge branch 'master' into master
Feb 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/dev-spaces/azext_dev_spaces/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ def load_arguments(self, _):
c.argument('cluster_name', options_list=['--name', '-n'])
c.argument('update', options_list=['--update'], action='store_true')
c.argument('space_name', options_list=['--space', '-s'])
c.argument('endpoint_type', options_list=['--endpoint', '-e'])
c.argument('do_not_prompt', options_list=['--yes', '-y'],
action='store_true', help='Do not prompt for confirmation. Requires --space.')

Expand Down
9 changes: 8 additions & 1 deletion src/dev-spaces/azext_dev_spaces/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# pylint:disable=no-member,too-many-lines,too-many-locals,too-many-statements


def ads_use_dev_spaces(cluster_name, resource_group_name, update=False, space_name=None, do_not_prompt=False):
def ads_use_dev_spaces(cluster_name, resource_group_name, update=False, space_name=None, endpoint_type=None, do_not_prompt=False):
rakeshvanga marked this conversation as resolved.
Show resolved Hide resolved
"""
Use Azure Dev Spaces with a managed Kubernetes cluster.

Expand All @@ -31,6 +31,9 @@ def ads_use_dev_spaces(cluster_name, resource_group_name, update=False, space_na
:type update: bool
:param space_name: Name of the new or existing dev space to select. Defaults to an interactive selection experience.
:type space_name: String
:param endpoint_type: The endpoint type to be used for a Azure Dev Spaces controller. \
See https://aka.ms/azds-networking for more information.
:type endpoint_type: String
:param do_not_prompt: Do not prompt for confirmation. Requires --space.
:type do_not_prompt: bool
"""
Expand All @@ -44,6 +47,10 @@ def ads_use_dev_spaces(cluster_name, resource_group_name, update=False, space_na
use_command_arguments.append('--space')
use_command_arguments.append(space_name)

if endpoint_type is not None:
use_command_arguments.append('--endpoint')
use_command_arguments.append(endpoint_type)

if do_not_prompt:
use_command_arguments.append('-y')
subprocess.call(
Expand Down