Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] netappfiles download url 404 blocks CI both in azure-cli and azure-cli-extensions #1310

Merged

Conversation

haroldrandom
Copy link
Contributor

The download URL seems to be invalid.

image

▶ dig anfclipython.blob.core.windows.net

; <<>> DiG 9.11.3-1ubuntu1.11-Ubuntu <<>> anfclipython.blob.core.windows.net
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 21311
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 65494
;; QUESTION SECTION:
;anfclipython.blob.core.windows.net. IN A

;; Query time: 66 msec
;; SERVER: 127.0.0.53#53(127.0.0.53)
;; WHEN: Sat Feb 22 02:33:33 UTC 2020
;; MSG SIZE  rcvd: 63

it blocks PR by failed a CI check "IndexVerify":

  1. fix bug aks-preview to use float(nan) #1304
  2. Adding endpoint type option to the extension #1241

Also, will fail CI of Azure/azure-cli


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/haroldrandom/azure-cli-extensions.git@hotfix-netappfiles-downloadurl-404#subdirectory=src/$EXT&egg=$EXT"

@yungezz yungezz self-requested a review February 22, 2020 02:39
@yungezz
Copy link
Member

yungezz commented Feb 22, 2020

HI @leonardbf , pls look at this PR also.

@yonzhan yonzhan added this to the S166 milestone Feb 22, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 22, 2020

add to S166.

Copy link
Collaborator

@yonzhan yonzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haroldrandom
Copy link
Contributor Author

Merge it seems no response from netappfiles teams and block several PR in both Azure/azure-cli and Azure/azure-cli-extensions.

@haroldrandom haroldrandom merged commit f380e3c into Azure:master Feb 23, 2020
@haroldrandom haroldrandom changed the title [hotfix] netappfiles download url 404 [hotfix] netappfiles download url 404 blocks CI both in azure-cli and azure-cli-extensions Feb 23, 2020
@haroldrandom haroldrandom deleted the hotfix-netappfiles-downloadurl-404 branch February 23, 2020 03:54
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants