This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: Update go-dev tools image for go 1.11.4 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboersma
changed the title
mboersma
changed the title
tariq1890
approved these changes
Dec 26, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma, tariq1890 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 53.21% 53.19% -0.03%
==========================================
Files 95 95
Lines 14230 14230
==========================================
- Hits 7573 7569 -4
- Misses 5991 5995 +4
Partials 666 666 |
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 53.21% 53.19% -0.03%
==========================================
Files 95 95
Lines 14230 14230
==========================================
- Hits 7573 7569 -4
- Misses 5991 5995 +4
Partials 666 666 |
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 53.21% 53.19% -0.03%
==========================================
Files 95 95
Lines 14230 14230
==========================================
- Hits 7573 7569 -4
- Misses 5991 5995 +4
Partials 666 666 |
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 53.21% 53.19% -0.03%
==========================================
Files 95 95
Lines 14230 14230
==========================================
- Hits 7573 7569 -4
- Misses 5991 5995 +4
Partials 666 666 |
This was referenced Dec 31, 2018
juhacket
pushed a commit
to juhacket/aks-engine
that referenced
this pull request
Mar 14, 2019
* chore: Update go-dev tools image for go 1.11.4 See https://golang.org/doc/devel/release.html#go1.11.minor and https://github.com/deis/docker-go-dev/releases/tag/v1.18.0 * Bump to go-dev:v1.18.1 See https://github.com/deis/docker-go-dev/releases/tag/v1.18.1 * Run linters inside go-dev container * Increase linter timeout to 3 minutes * Remove `make test-style` docker command for CircleCI environment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
See https://golang.org/doc/devel/release.html#go1.11.minor
and https://github.com/deis/docker-go-dev/releases/tag/v1.18.0
Release note: