Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: change labels and service name from kube-dns to coredns #200

Closed
wants to merge 1 commit into from

Conversation

idanlevin
Copy link

@idanlevin idanlevin commented Dec 25, 2018

What this PR does / why we need it:
This PR fixes the coredns labels and service name
Which issue this PR fixes :
Fixes #199

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@acs-bot acs-bot added the size/S label Dec 25, 2018
@acs-bot
Copy link

acs-bot commented Dec 25, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: idanlevin
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: brendandburns

If they are not already assigned, you can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tariq1890
Copy link
Contributor

tariq1890 commented Dec 27, 2018

Can you rebase this PR @idanlevin ?

@tariq1890
Copy link
Contributor

tariq1890 commented Dec 27, 2018

Thanks for your contribution @idanlevin :). These changes certainly make sense, I had a look at the coredns repo and the deployment YAMLs over there still use the k8s-app: kube-dns as the label.

See here

It might be worthwhile to clarify the reasoning behind this label usage with the coredns maintainers. Thoughts?

@idanlevin
Copy link
Author

@tariq1890 yes, I also see it's kept this way in the Kubernetes repo, I'll try to get a hold of the maintainers.

@idanlevin
Copy link
Author

posted the question here -
coredns/deployment#116

will update

@mboersma mboersma changed the title Change labels and service name from kube-dns to coredns fix: change labels and service name from kube-dns to coredns Dec 31, 2018
@mboersma
Copy link
Member

@idanlevin the goimports error in the CircleCI tests was fixed by #205. Sorry about that! Could you rebase this PR off the master branch? It should pass tests after that.

@mboersma mboersma added the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Dec 31, 2018
@idanlevin
Copy link
Author

I'm closing this PR since it seems to be by design as described here:
coredns/deployment#116

@idanlevin idanlevin closed this Jan 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-rebase Changes in the target branch require a `git rebase` and `git push -f` size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoreDNS deployment label is incorrect
4 participants