Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: Update go-dev tools image for go 1.11.4 #205

Merged
merged 5 commits into from
Dec 26, 2018
Merged

chore: Update go-dev tools image for go 1.11.4 #205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8065cec
chore: Update go-dev tools image for go 1.11.4
mboersma Dec 26, 2018
60dea2c
Bump to go-dev:v1.18.1
mboersma Dec 26, 2018
af94a74
Run linters inside go-dev container
mboersma Dec 26, 2018
987a4b5
Increase linter timeout to 3 minutes
mboersma Dec 26, 2018
52877c8
Remove `make test-style` docker command for CircleCI environment
mboersma Dec 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bump to go-dev:v1.18.1 
See https://github.com/deis/docker-go-dev/releases/tag/v1.18.1
  • Loading branch information
@mboersma
mboersma committed Dec 26, 2018
commit 60dea2c0f2cc9d2c352e6ca4dfeff40946966c5a
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2
defaults: &defaults
working_directory: /go/src/github.com/Azure/aks-engine
docker:
- image: quay.io/deis/go-dev:v1.18.0
- image: quay.io/deis/go-dev:v1.18.1
environment:
GOPATH: /go

Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ GITTAG := $(VERSION_SHORT)
endif

REPO_PATH := github.com/Azure/aks-engine
DEV_ENV_IMAGE := quay.io/deis/go-dev:v1.18.0
DEV_ENV_IMAGE := quay.io/deis/go-dev:v1.18.1
DEV_ENV_WORK_DIR := /go/src/${REPO_PATH}
DEV_ENV_OPTS := --rm -v ${CURDIR}:${DEV_ENV_WORK_DIR} -w ${DEV_ENV_WORK_DIR} ${DEV_ENV_VARS}
DEV_ENV_CMD := docker run ${DEV_ENV_OPTS} ${DEV_ENV_IMAGE}
Expand Down Expand Up @@ -109,7 +109,7 @@ test: generate

.PHONY: test-style
test-style:
@scripts/validate-go.sh
scripts/validate-go.sh

.PHONY: test-e2e
test-e2e:
Expand Down
2 changes: 1 addition & 1 deletion makedev.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
$REPO_PATH = "github.com/Azure/aks-engine"
$DEV_ENV_IMAGE = "quay.io/deis/go-dev:v1.18.0"
$DEV_ENV_IMAGE = "quay.io/deis/go-dev:v1.18.1"
$DEV_ENV_WORK_DIR = "/go/src/$REPO_PATH"

docker.exe run -it --rm -w $DEV_ENV_WORK_DIR -v `"$($PWD)`":$DEV_ENV_WORK_DIR $DEV_ENV_IMAGE bash