Skip to content

Fix all the eslint errors #24504

New issue
Jump to bottom
New issue
Jump to bottom
Closed
Closed
Fix all the eslint errors#24504
Labels
Framework[Type] Task
@blowery

Description

@blowery
blowery
opened on Apr 26, 2018

At the moment, we use eslines when running build lint checks to only lint changed lines in the code base. This is less than ideal, as it often misses new errors that arise when we upgrade eslint or add / alter rules. Instead, we should get rid of all of the eslint errors and run eslint normally.

The following is a list of all of the eslint errors currently on master. If you'd like to fix a set, please make up a PR and add the PR# after the affected line.

When fixing the errors, there are three common strategies: 1) fix the offending code, 2) ignore the error with an // eslint-disable-* the-error instruction or 3) turn off the offending eslint rule entirely. 1 is preferred, 2 is understandable and 3 requires some broader discussion.

This list was updated May 14 2018

Metadata

Assignees

No one assigned

    Labels

    Framework[Type] Task

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions