Lint fix: search-preview: Follow CSS namespace guidelines #31665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunsathiya
added
[Status] Needs Review
jsnajdr
approved these changes
Mar 22, 2019
There was a problem hiding this comment.
Looks good, thanks! 👍
The next steps after this PR would be to break up the big SEO stylesheet into individual components and import them as ES modules. But that's probably already your plan 😉
The SearchPreview component is also a good fit for a functional React component with useTranslate hook.
|
Thank you! :) I am tracking it here #31667 Will attempt a PR. |
matticbot
removed
the
[Status] Needs Review
arunsathiya
added
the
[Feature] SEO Tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
search-previewcomponentTesting instructions
/settings/traffic/{site-domain}(need a WordPress.com Business plan site)Show previewsmasterbranch