Lint fixes: Reader-related blocks #25212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluefuton
added
[Status] In Progress
[Feature] Reader
bluefuton
commented
Jun 1, 2018
| @@ -37,20 +37,6 @@ class PostCommentForm extends Component { | |||
| } ); | |||
| } | |||
|
|
|||
| componentDidUpdate() { | |||
There was a problem hiding this comment.
Seems to be redundant - this.refs.commentText no longer exists.
bluefuton
commented
Jun 1, 2018
| @@ -43,20 +43,6 @@ class PostCommentForm extends React.Component { | |||
| } ); | |||
| } | |||
|
|
|||
| componentDidUpdate() { | |||
There was a problem hiding this comment.
Seems to be redundant - this.refs.commentText no longer exists.
bluefuton
added
[Status] Needs Review
blowery
reviewed
Jun 1, 2018
| <div | ||
| className="conversation-caterpillar__gravatars" | ||
| onClick={ this.handleTickle } | ||
| aria-hidden="true" |
There was a problem hiding this comment.
does this mean screen readers won't see the 🐛 as clickable?
There was a problem hiding this comment.
The linter doesn't like non-interactive elements with an onClick, but I think a useful bonus to be able to expand the caterpillar by clicking the gravatars so I wanted to keep that behaviour. On balance I thought the best option was to hide just the gravatar images from assistive devices, since the "Load previous comments..." button will be available to do the expansion (it's a button element):
bluefuton
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24504.
Address linting issues in client/blocks related to Reader.
No functional changes.