Improve reporting to users #246
Conversation
There was a problem hiding this comment.
phpcs scanning turned up:
🚫 6 errors
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
There was a problem hiding this comment.
phpcs scanning turned up:
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
There was a problem hiding this comment.
phpcs scanning turned up:
🚫 71 errors
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
Posting will continue in further review(s)
…to vipgoci_report_submit_pr_generic_support_comment()
There was a problem hiding this comment.
phpcs scanning turned up:
🚫 27 errors
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
Posting will continue in further review(s)
Improve reporting to users in pull request feedback and in the command line.
TODO:
--versionoption.--helpin a better way..vipgoci_options[ In GitHub reviews, report which options were altered #145 ]PHPDoccomments for new or updated functions (main code only; for VIP)vipgoci_github_wait()to two seconds to avoid GitHub API limit errors.vipgoci_github_pr_review_submit()should be renamed and moved toreports.php. [ Move functions and functionality between files #142 ]vipgoci_github_pr_generic_comment_submit_results()should be renamed and moved toreports.php. [ Move functions and functionality between files #142 ]vipgoci_github_pr_generic_support_comment_submit()toreports.phpand rename tovipgoci_report_submit_pr_generic_support_comment().vipgoci_github_wait()togithub-misc.phpvipgoci_option_array_handle()to cover empty parameter.vipgoci_github_wait().vipgoci_util_php_interpreter_get_version().vipgoci_output_sanitize_version_number().vipgoci_output_html_escape().vipgoci_phpcs_get_version().vipgoci_report_create_scan_details_list().vipgoci_report_create_scan_details_software_versions()vipgoci_report_create_scan_details_php_lint_options()vipgoci_report_create_scan_details_phpcs_configuration()vipgoci_report_create_scan_details_svg_configuration()vipgoci_report_create_scan_details_auto_approve_configuration()vipgoci_report_results_to_github_were_submitted()tests/integration/PhpcsScanPossiblyUseNewStandardFileTest.phpso to check value of$options['phpcs-standard-original']vipgoci_options_read_repo_file()updates$options['repo-options-set'].