Move functions and functionality between files

[gudmdharalds]

In order to make vip-go-ci clearer and better maintainable, functions should be moved and some things refined a bit.

The following functions should be moved to another file:

• Solved in Apply WP CS for a few files, move functionality between files #247:

  • Move vipgoci_cache() to cache.php
  • Move vipgoci_cached_indication_str() to cache.php
  • Move vipgoci_patch_changed_lines() to github-misc.php
  • Move vipgoci_github_pr_remove_drafts() to github-misc.php
  • Move vipgoci_blame_filter_commits() to github-misc.php
  • Rename vipgoci_github_comment_match() and move to results.php
  • Rename vipgoci_issues_filter_irrellevant() and move to results.php
  • Rename vipgoci_issues_filter_duplicate() and move to results.php
  • Move vipgoci_results_sort_by_severity() to results.php
  • Move vipgoci_log() to log.php
  • Move vipgoci_sysexit() to log.php

• Solved in Improve reporting to users #246:

  • vipgoci_github_pr_review_submit() should be renamed and moved to reporting.php. Logic that submits raw data to GitHub should live in github-api.php.
  • vipgoci_github_pr_generic_comment_submit_results() should be renamed and moved to reporting.php. Logic that submits raw data to GitHub should live in github-api.php.

• Functionality in main.php should be moved:

  • Functionality related to auto-approvals: https://github.com/Automattic/vip-go-ci/blob/master/main.php#L1739-L1801 -- should be in the function itself. [ Break vipgoci_run() into multiple functions #207 ]