Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply WP CS for a few files, move functionality between files #247

Merged
merged 59 commits into from
Feb 17, 2022

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented Feb 15, 2022

Apply WordPress coding standard for a few files, along with strict types and setting variable types (see #157).

Apply WordPress coding standards, strict types and set variable types for the following files:

  • auto-approval.php
  • ap-file-types.php
  • ap-hashes-api.php
  • ap-nonfunctional-changes.php
  • ap-svg-files.php
  • defines.php
  • github-commit-status.php
  • latest-release.php
  • test.bootstrap.php
  • results.php
  • skip-file.php
  • statistics.php
  • support-level-label.php
  • Changelog entry (for VIP) [ Changelog for version 1.2.0 #243 ]

Move functions between files (see [ #142 ]) :

  • Move vipgoci_log() to log.php
  • Move vipgoci_sysexit() to log.php
    • Update test for the function.
  • Move vipgoci_results_sort_by_severity() to results.php
    • Update test for the function.
  • Move vipgoci_cache() to cache.php
    • Update test for the function.
  • Move vipgoci_cached_indication_str() to cache.php
    • Update test for the function.
  • Move vipgoci_patch_changed_lines() to github-misc.php
    • Update test for the function.
  • Move vipgoci_github_pr_remove_drafts() to github-misc.php
    • Update test for the function.
  • Move vipgoci_blame_filter_commits() to github-misc.php
    • Update test for the function.
  • Move vipgoci_markdown_comment_add_pagebreak() to github-misc.php
    • Update test for the function.
  • Move vipgoci_github_transform_to_emojis() to github-misc.php
    • Update test for the function.
  • Move vipgoci_issues_filter_irrellevant() to results.php
    • Update test for the function.
  • Move vipgoci_issues_filter_duplicate() to results.php
    • Update test for the function.
  • Move vipgoci_github_comment_match() to results.php
    • Update test for the function.

Apply WordPress coding standards, etc for the new files:

  • cache.php
  • github-misc.php
  • log.php

Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 1 error


This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

ap-hashes-api.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 1 error


This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

ap-hashes-api.php Show resolved Hide resolved
@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot dismissed their stale review February 16, 2022 15:05

Dismissing review as all inline comments are obsolete by now

Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 1 error


This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

auto-approval.php Show resolved Hide resolved
@gudmdharalds gudmdharalds changed the title Apply WP CS for a few files Apply WP CS for a few files, move functionality between files Feb 16, 2022
Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 3 errors

⚠️ 5 warnings


This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

cache.php Show resolved Hide resolved
cache.php Show resolved Hide resolved
requires.php Outdated Show resolved Hide resolved
requires.php Outdated Show resolved Hide resolved
requires.php Outdated Show resolved Hide resolved
results.php Show resolved Hide resolved
results.php Show resolved Hide resolved
results.php Show resolved Hide resolved
Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 5 errors


This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

requires.php Outdated Show resolved Hide resolved
support-level-label.php Outdated Show resolved Hide resolved
support-level-label.php Outdated Show resolved Hide resolved
support-level-label.php Outdated Show resolved Hide resolved
support-level-label.php Outdated Show resolved Hide resolved
@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot dismissed their stale review February 17, 2022 21:26

Dismissing review as all inline comments are obsolete by now

@gudmdharalds gudmdharalds merged commit 20e8382 into main Feb 17, 2022
@gudmdharalds gudmdharalds deleted the update-wp-cs-2 branch February 17, 2022 22:12
@gudmdharalds gudmdharalds mentioned this pull request Feb 9, 2023
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants