Skip to content

Extra GitHub review posted when there are skipped files #238

Closed
@gudmdharalds

Description

Bug report

Expected behavior

When Maximum number of lines exceeded error has been reported once because of a lengthy file during one run, and there are no additonal PHPCS/SVG/Linting issues to report in a second run, no GitHub review should be posted in the second one.

Observed Behavior

A review is posted containing only this informational message: This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation. This should not be posted on its own.

Reproducing the problem

Steps to reproduce the problem:

  1. Get latest vip-go-ci
  2. Run a scan with a file that is too large. Observe a review being posted, including the Maximum number of lines exceeded message.
  3. Run the scan again against the same commit-ID. Observe a review being posted with only the above informational message.

System information

  • PHP 8.1 and PHP 7.4
  • Linux.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions