Add skip large files for post PHPCS checks #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovidiul
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
Hi @ariskataoka thank you for adding the changes, they look good on my part! 🙇♂️
robersongomes
approved these changes
Oct 21, 2021
ariskataoka
added a commit
that referenced
this pull request
Oct 22, 2021
ariskataoka
added a commit
that referenced
this pull request
Nov 10, 2021
* Changelog for version 1.0.9 * Adding version 1.0.9 * Add #204 to the 1.0.9 changelog * Add #209 to the 1.0.9 changelog * Add #217 to the 1.0.9 changelog * Remove #205 changelog It's been postponed and won't be part of the 1.0.9 version. * Add #208 to the 1.0.9 changelog * Add #214 to the 1.0.9 changelog * Add release date to the change log Co-authored-by: Ariana Kataoka <aris.kataoka@gmail.com> Co-authored-by: Ariana Kataoka <ariana.kataoka@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running the PHPCS scan,
vip-go-ciperforms a few checks; and they can be expensive for large files.E.g.:
The following code block, which is called after the PHPCS, will potentially result in an OOM for a large file:
https://github.com/Automattic/vip-go-ci/blob/main/git-repo.php#L371-L396
Those checks should be skipped for the large files since the phpcs scan command itself is also skipped for the same scenario.
This PR applies the condition to skip large files during those checks - since they are not necessary.
Edit
Obs about tests:
For this scenario, we ideally would write tests to assert if the expensive methods were called or not when the files are large.
However, since this project is procedural, it's not possible to determine via
phpunitwhether a method is called or not. - not without rewriting the entire phpcs scan logic.Having that in mind, the tests found in the PhpcsScanScanCommitTest.php test class are still passing, and for the moment, that would be enough to validate that this code is not breaking any scenario.
Edit to add TODO list in the description:
TODO: