Add logic to avoid duplicated comments about limit of lines exceeded in the same PR #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpcomvip-vipgoci-bot
previously requested changes
Sep 10, 2021
There was a problem hiding this comment.
phpcs scanning turned up:
🚫 1 error
This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.
Closed
ariskataoka
force-pushed
the
add-logic-pr-comment-line-limit-1-0-9
branch
from
aee12e5 to
c3fceb0
Compare
wpcomvip-vipgoci-bot
dismissed
their stale review
Dismissing review as all inline comments are obsolete by now
ariskataoka
force-pushed
the
add-logic-pr-comment-line-limit-1-0-9
branch
2 times, most recently
from
8e899b6 to
fb87ce9
Compare
ariskataoka
force-pushed
the
add-logic-pr-comment-line-limit-1-0-9
branch
from
fb87ce9 to
6ec66c0
Compare
…ipgo_get_large_files_from_pr_comments functions
ariskataoka
force-pushed
the
add-logic-pr-comment-line-limit-1-0-9
branch
from
a2988ac to
d61bfad
Compare
… in the same PR before +Adjust var names to keep consistency
ariskataoka
force-pushed
the
add-logic-pr-comment-line-limit-1-0-9
branch
from
18e2a10 to
8ec2804
Compare
mchanDev
approved these changes
Oct 26, 2021
ariskataoka
added a commit
that referenced
this pull request
Oct 26, 2021
ariskataoka
added a commit
that referenced
this pull request
Nov 10, 2021
* Changelog for version 1.0.9 * Adding version 1.0.9 * Add #204 to the 1.0.9 changelog * Add #209 to the 1.0.9 changelog * Add #217 to the 1.0.9 changelog * Remove #205 changelog It's been postponed and won't be part of the 1.0.9 version. * Add #208 to the 1.0.9 changelog * Add #214 to the 1.0.9 changelog * Add release date to the change log Co-authored-by: Ariana Kataoka <aris.kataoka@gmail.com> Co-authored-by: Ariana Kataoka <ariana.kataoka@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, whenever the
vip-go-ciscans the repository and finds file(s) that contain more than the limit of lines, it posts a comment on the PR, saying that they have been skipped due to the maximum lines permitted reached.If the file is not fixed, it will repeat the message for each build scan.
This PR adds the logic to avoid that message duplication.
TODO:
Current behavior: duplicated comments
This PR behavior: