Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new GitHub Teams API #205

Merged
merged 13 commits into from
Feb 9, 2022
Merged

Use new GitHub Teams API #205

merged 13 commits into from
Feb 9, 2022

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented Aug 27, 2021

Update to use new GitHub Teams API endpoint instead of a deprecated Teams API endpoint.

This closes #128.

TODO:

  • Use new GitHub Teams API endpoint
  • Add org-name parameter as needed
  • New endpoint uses slugs instead of IDs, update code to reflect this.
  • Update unit-tests as needed
  • Update README
  • Add or update PHPDoc comments for new or updated functions.
  • Changelog entry [ Changelog for version 1.2.0 #243 ]
  • Check automated unit-tests

@gudmdharalds gudmdharalds added this to the 1.0.9 milestone Aug 27, 2021
@gudmdharalds gudmdharalds self-assigned this Aug 27, 2021
ariskataoka added a commit that referenced this pull request Oct 22, 2021
It's been postponed and won't be part of the 1.0.9 version.
@ariskataoka ariskataoka removed this from the 1.0.9 milestone Oct 22, 2021
ariskataoka added a commit that referenced this pull request Nov 10, 2021
* Changelog for version 1.0.9

* Adding version 1.0.9

* Add #204 to the 1.0.9 changelog

* Add #209 to the 1.0.9 changelog

* Add #217 to the 1.0.9 changelog

* Remove #205 changelog

It's been postponed and won't be part of the 1.0.9 version.

* Add #208 to the 1.0.9 changelog

* Add #214 to the 1.0.9 changelog

* Add release date to the change log

Co-authored-by: Ariana Kataoka <aris.kataoka@gmail.com>
Co-authored-by: Ariana Kataoka <ariana.kataoka@automattic.com>
@gudmdharalds gudmdharalds added this to the PHP 8 support milestone Jan 21, 2022
@gudmdharalds gudmdharalds modified the milestones: PHP 8 support, 1.2.0 Feb 4, 2022
Copy link
Collaborator

@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpcs scanning turned up:

🚫 11 errors

⚠️ 6 warnings


This bot provides automated PHP linting and PHPCS scanning. For more information about the bot and available customizations, see our documentation.

github-api.php Outdated Show resolved Hide resolved
github-api.php Outdated Show resolved Hide resolved
github-api.php Outdated Show resolved Hide resolved
github-api.php Outdated Show resolved Hide resolved
github-api.php Outdated Show resolved Hide resolved
tests/integration/GitHubTeamMembersManyTest.php Outdated Show resolved Hide resolved
tests/integration/GitHubTeamMembersManyTest.php Outdated Show resolved Hide resolved
@@ -6,8 +6,9 @@

final class GitHubTeamMembersTest extends TestCase {
var $options = array(
'github-token' => null,
'team-id' => null,
'github-token' => null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Warning( severity 5 ): Array double arrow not aligned correctly; expected 1 space(s) between "'github-token'" and double arrow, but found 2 (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned).

tests/integration/GitHubTeamMembersTest.php Outdated Show resolved Hide resolved
tests/integration/GitHubTeamMembersTest.php Outdated Show resolved Hide resolved
@wpcomvip-vipgoci-bot wpcomvip-vipgoci-bot dismissed their stale review February 9, 2022 14:20

Dismissing review as all inline comments are obsolete by now

@gudmdharalds gudmdharalds merged commit fe5614e into main Feb 9, 2022
@gudmdharalds gudmdharalds deleted the update-new-teams-api branch February 9, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new GitHub's Teams API endpoints
3 participants