feat[my-account-block]: add option to toggle off icon/text, and update tests

[laurelfulford]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR adds an option to hide either the icon or label on the My Account Button block (but not both at the same time).

As part of that, I changed how the button acts if you don't give it a text label (instead of not showing anything, it will fallback to the default labels) -- when it's hidden in the settings, the label is still used as screen reader text so we don't want it to be empty even if it's not visible.

I also updated the tests to check for the default (vs. making sure empty strings were empty), and tweaked the behaviour to make sure logged in admins (not just readers) would see the My Account labels - I thought this was working before but I was seeing Sign In in trunk.

See NPPD-1183.

How to test the changes in this Pull Request:

1. Apply this PR and run npm run build. As a bonus you can also test this alongside feat: make My Account button only show icon on mobile newspack-block-theme#406, but it's not required.
2. If using the default header patterns, the button should already be in the header. If not, add the My Account Button block to the header.
3. Click on the button and confirm you have a Display panel under the Settings tab, with an option to Display label and Display icon. Both should be enabled by default:

4. Try turning of each option and confirm that the button updates appropriately (hiding the text or the icon). Confirm that you can't turn off both options at once -- if you try to turn off say, the icon, the label should switch to visible if it isn't already, and vis versa.
5. Try changing the text labels on each state of the button (Signed in, Signed out), turn off the Show label toggle, and view on the front end.
6. Confirm you only see the icons; when you inspect the icon, you should see your label text wrapped in a screen-reader-text span.
7. Try signing in/signing up in an incognito window, and confirm hidden text is right (that you can see the Signed out text in the markup when you're not logged in, and Signed in text when you are).
8. Try editing the header again and switching the settings so you can see the text, but not the icon; repeat step 7.
9. Try editing the text label of each button and leave it blank; confirm you can still see the placeholder in the editor.
10. Publish your changes and confirm you see the default text on the front-end (Sign In and My Account).
11. Run the tests just to make sure they come back okay.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[Copilot]

Pull request overview

This PR adds display controls to the My Account Button block, allowing users to selectively hide either the icon or label text, while ensuring at least one element remains visible for usability. The PR also improves the empty label fallback behavior and fixes an issue where logged-in admins were seeing incorrect button labels.

Changes:

• Added showLabel and showIcon boolean attributes with UI toggles in the Inspector Controls
• Updated empty label handling to fallback to defaults instead of rendering nothing
• Added data-wp-logged-in attribute to preserve correct labels for logged-in WordPress users
• Updated tests to verify fallback behavior for empty labels

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/blocks/my-account-button/block.json	Added showLabel and showIcon boolean attributes with default values of true
src/blocks/my-account-button/edit.js	Implemented Inspector Controls with toggle controls and mutual exclusivity logic, added conditional rendering for icon/label visibility
src/blocks/my-account-button/class-my-account-button-block.php	Added showLabel/showIcon attribute handling, conditional rendering logic, screen-reader-text class for hidden labels, and data-wp-logged-in attribute
src/reader-activation-auth/index.js	Added check for logged-in WordPress users to preserve correct label text and prevent unnecessary reader authentication checks
tests/unit-tests/class-test-my-account-button-block.php	Split empty label test into separate signed-in/signed-out tests, updated assertions to verify fallback to default labels
src/blocks/my-account-button/README.md	Added documentation for the new Display toggle feature

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[thomasguillot]

Here's an update, using styles: d315db9

[laurelfulford]

@thomasguillot Looks good to me! 🙂 Now we just need to see what an uninvolved third-party has to say!