Skip to content

feat: make My Account button only show icon on mobile#406

Open
laurelfulford wants to merge 3 commits intotrunkfrom
feat/switch-my-account-to-icon
Open

feat: make My Account button only show icon on mobile#406
laurelfulford wants to merge 3 commits intotrunkfrom
feat/switch-my-account-to-icon

Conversation

@laurelfulford
Copy link
Contributor

@laurelfulford laurelfulford commented Feb 2, 2026

All Submissions:

Changes proposed in this Pull Request:

This either needs to be tested with Automattic/newspack-plugin#4443, or after it's merged.

See NPPD-1183.

How to test the changes in this Pull Request:

  1. Apply this PR and feat[my-account-block]: add option to toggle off icon/text, and update tests newspack-plugin#4443 if needed.
  2. Navigate to the Site Editor and edit the Header (Mobile) pattern; reset it first if it has any changes saved.
  3. Confirm that the default pattern (pattern 1) uses an icon for the My Account Button block:
CleanShot 2026-02-02 at 11 00 17@2x
  1. In the Template Part tab, switch the template part to use Header Mobile (Style 3). Confirm it also uses just the icon for the My Account Block button.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot force-pushed the feat/switch-my-account-to-icon branch from b6f279e to e84e192 Compare February 4, 2026 12:18
@thomasguillot
Copy link
Contributor

@laurelfulford I updated the patterns based on the new classname approach.

I've also included a (future) fix (9322328). Related: #409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants