feat: replace WooCommerce’s login form with our own #1854

dkoo · 2022-08-04T19:26:52Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Replaces the native WooCommerce login form with our own, utilizing the same markup as we use for the login modal (but with some additional styles to make it render inline).

To do so, we rely a bit on a hack to hijack the rendering of the WooCommerce login form template; when this template is about to be rendered, we replace with an empty template file and instead call our render_auth_form method to output the form markup. There may be a more elegant way to do this, but I couldn't find one in the short term (cc @claudiulodro if you have any suggestions). @miguelpeixe suggested a bit of a less-hacky way to do this by simply calling the render_auth_form method in the template itself.

Closes #1850.

How to test the changes in this Pull Request:

Check out this branch.
In a new session, while not logged in, visit the My Account page to log in.
Confirm that you see our Reader Activation login form here instead of the usual native WC login form.
Confirm that all functionality works here as expected, and that once you log in successfully you're redirected to the My Account dashboard in the logged-in state.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

miguelpeixe

Some CSS could hide the page title like we already do for the redesigned account page:

includes/templates/reader-activation/login-form.php

includes/class-reader-activation.php

Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com>

dkoo · 2022-08-04T20:44:01Z

Some CSS could hide the page title like we already do for the redesigned account page:

Done in 6342ad1.

miguelpeixe

I missed another tweak and also looks like there's a disproportionate top margin from the Sign In form, WDYT?

includes/class-reader-activation.php

…tancse

Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com>

dkoo · 2022-08-04T20:58:12Z

I missed another tweak and also looks like there's a disproportionate top margin from the Sign In form, WDYT?

Agreed, 23f56e4 removes the padding from the content wrapper for inline forms.

assets/reader-activation/auth.js

miguelpeixe

Looks good now! 🙌

Thank you for the revisions!

dkoo · 2022-08-04T21:50:40Z

Thanks for your patience with the back and forth!

* feat: set client id cookie; reader activation tweaks (#1780) * feat(reader-activation): registration auth cookie control (#1787) * fix(reader-activation): username generation handling (#1789) * feat(stripe): webhook auto-creation and validation * feat(reader-activation): account link and auth form (#1754) Co-authored-by: Adam Boro <adam@adamboro.com> * feat: handle new frequency options in Campaigns dashbaord (#1779) * feat: handle new frequency options in Campaigns dashbaord * feat: only enable new frequency options if reader activation flag is on * feat(registration-block): newsletter subscription (#1778) * fix(popups): use new Campaigns method for creating donation events on new orders (#1794) * fix(popups): use new Campaigns method for creating donation events on new orders * refactor: use action hook instead of calling Campaigns methods directly * chore: remove unneeded condition * refactor: use a hook for WooCommerce donations, too * fix: add client_id to contact info passed from Stripe * feat(my-account): stripe billing portal link (#1761) Note: some styling relies on Automattic/newspack-theme#1875 Closes #1742 Closes #1739 Closes #1740 Closes #1741 Closes #1782 * feat(registration-block): login with Google (#1781) Closes #1774 Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * chore(deps): bump @babel/preset-env from 7.18.6 to 7.18.9 Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.18.6 to 7.18.9. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.18.9/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump date-fns from 2.28.0 to 2.29.1 Bumps [date-fns](https://github.com/date-fns/date-fns) from 2.28.0 to 2.29.1. - [Release notes](https://github.com/date-fns/date-fns/releases) - [Changelog](https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md) - [Commits](date-fns/date-fns@v2.28.0...v2.29.1) --- updated-dependencies: - dependency-name: date-fns dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump @babel/plugin-transform-runtime from 7.18.6 to 7.18.9 Bumps [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime) from 7.18.6 to 7.18.9. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.18.9/packages/babel-plugin-transform-runtime) --- updated-dependencies: - dependency-name: "@babel/plugin-transform-runtime" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump stripe/stripe-php from 8.10.0 to 8.11.0 Bumps [stripe/stripe-php](https://github.com/stripe/stripe-php) from 8.10.0 to 8.11.0. - [Release notes](https://github.com/stripe/stripe-php/releases) - [Changelog](https://github.com/stripe/stripe-php/blob/master/CHANGELOG.md) - [Commits](stripe/stripe-php@v8.10.0...v8.11.0) --- updated-dependencies: - dependency-name: stripe/stripe-php dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * feat: register anonymous single donors (#1795) Co-authored-by: Adam Borowski <adam@adamboro.com> * feat(registration-block): editable success state (#1785) Closes #1768 Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com> * feat(registration-block): add success icon (#1804) * refactor: remove unneeded prop * feat: send user metadata to AC (#1793) * feat: remove reader registration on adding contact via hook This was causing an infinite loop: Newsletters is triggering reader registration when a contact is added (`Newspack_Newsletters_Subscription::newspack_registered_reader`). Then, on adding a contact, registration was triggered again here. * fix(registration-block): margin for success message (#1808) * Reader Activation: auth form with third-party and lists subscriptions (#1800) * feat: tweak registration block styling * feat(reader-auth): make password login the first option, instead of login link Closes #1809 * fix(reader-activation): reinitialize auth links after DOM load (#1812) * fix: ensure scroll on smaller height (#1813) * feat(reader-activation): settings wizard (#1773) Co-authored-by: Adam Boro <adam@adamboro.com> * feat: handle contact update w/out lists selection (#1816) Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * chore: logger update (#1807) Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * feat(reader-activation): disable 3rd party login buttons initially (#1806) * feat(reader-activation): prevent updating user email in my-account * feat(reader-activation): activecampaign master list (#1818) Co-authored-by: Adam Boro <adam@adamboro.com> * chore(deps): bump stripe/stripe-php from 8.11.0 to 8.12.0 Bumps [stripe/stripe-php](https://github.com/stripe/stripe-php) from 8.11.0 to 8.12.0. - [Release notes](https://github.com/stripe/stripe-php/releases) - [Changelog](https://github.com/stripe/stripe-php/blob/master/CHANGELOG.md) - [Commits](stripe/stripe-php@v8.11.0...v8.12.0) --- updated-dependencies: - dependency-name: stripe/stripe-php dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix(campaigns-wizard): segmentation wording * feat(rss): adds offset feature (#1790) Adds offset feature to RSS, allowing better ad integration with RSS feed based emails * fix(reader-activation): handle no lists config available * fix: fix fatal error when debug mode active (#1826) * feat: reorganise donations wizard and use buttongroup for donation type (#1824) * fix: google auth button type (#1829) * fix(magic-links): fix email encoding on sent link (#1833) * fix(registration-block): don't escape html for sign in labels (#1834) * fix(reader-activation): add metadata to reader registered on donation * fix(registration-block): render on preview (#1844) Co-authored-by: Derrick Koo <dkoo@users.noreply.github.com> * fix(reader-activation): remove async prop from library (#1846) * feat(analytics): send GA events on the server side (#1828) * refactor: abstract server-side GA custom event sending * feat(reader-activation): send custom event to GA on reader registration * feat: report user login method to GA; refactor how it's stored * refactor: handle extended data from the newspack_newsletters_contact_data hook * feat: send NTG custom events on registration, newsletter signup * fix(my account): handle legacy data (#1823) * fix(reader-activation): handle modal conflict when auth is triggered from a prompt Closes #1835 * feat(reader-activation): optimistic account link (#1847) * fix(google-auth): ensure popup on user click event (#1831) Co-authored-by: Adam Boro <adam@adamboro.com> * feat(active-campaigns): override is-new-contact for legacy contacts * feat(active-campaign): metadata improvements (#1851) * feat: if registering an email that already has an account, show different message (#1849) * feat: if registering an email that already has an account, show different message * refactor: use existing var * feat: replace WooCommerce’s login form with our own (#1854) * feat: replace WooCommerce’s login form with our own * fix: use WC method to get account URL Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * refactor: call render method from template file * feat: hide page title on WC account pages * refactor: restore modal on My Account pages; handle multiple form instancse * refactor: use $class method to build inline class Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * style: remove unneeded padding from inline form * fix: move handlers and functions outside of loop * chore: reword auth message for consistency * fix: avoid JS error if redirect input is null * fix: avoid JS error if email input is null Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * fix(newsletters): use international date format (#1855) * fix: tweak arguments for magic link client hash (#1862) * feat(donations): remove defaultFrequency from the configuration (#1814) It's not configurable. See Automattic/newspack-blocks#1218 * fix(ga): cookie parsing (#1857) * fix(active-campaign): legacy contacts detection (#1858) Co-authored-by: Adam Boro <adam@adamboro.com> Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com> Co-authored-by: matticbot <sysops+ghmatticbot@automattic.com> Co-authored-by: dnalla1928 <53319922+dnalla1928@users.noreply.github.com> Co-authored-by: Claudiu Lodromanean <claudiulodro@gmail.com>

# [1.88.0-alpha.1](v1.87.0...v1.88.0-alpha.1) (2022-08-05) ### Bug Fixes * **active-campaign:** legacy contacts detection ([#1858](#1858)) ([67640a5](67640a5)) * **campaigns-wizard:** segmentation wording ([ddf61ad](ddf61ad)) * ensure scroll on smaller height ([#1813](#1813)) ([e234e8b](e234e8b)) * fix fatal error when debug mode active ([#1826](#1826)) ([d9388ee](d9388ee)) * **ga:** cookie parsing ([#1857](#1857)) ([a936abd](a936abd)) * google auth button type ([#1829](#1829)) ([3704d9f](3704d9f)) * **google-auth:** ensure popup on user click event ([#1831](#1831)) ([0af9abf](0af9abf)) * **magic-links:** fix email encoding on sent link ([#1833](#1833)) ([8d4756c](8d4756c)) * **my account:** handle legacy data ([#1823](#1823)) ([6816799](6816799)) * **newsletters:** use international date format ([#1855](#1855)) ([4cda57d](4cda57d)) * **popups:** use new Campaigns method for creating donation events on new orders ([#1794](#1794)) ([49dc14c](49dc14c)) * **reader-activation:** add metadata to reader registered on donation ([722724c](722724c)) * **reader-activation:** handle modal conflict when auth is triggered from a prompt ([c2a0141](c2a0141)), closes [#1835](#1835) * **reader-activation:** handle no lists config available ([23b0249](23b0249)) * **reader-activation:** reinitialize auth links after DOM load ([#1812](#1812)) ([0a4b499](0a4b499)) * **reader-activation:** remove async prop from library ([#1846](#1846)) ([4131ca6](4131ca6)) * **reader-activation:** username generation handling ([#1789](#1789)) ([17edf2a](17edf2a)) * **registration-block:** don't escape html for sign in labels ([#1834](#1834)) ([871300d](871300d)) * **registration-block:** margin for success message ([#1808](#1808)) ([1bfe546](1bfe546)) * **registration-block:** render on preview ([#1844](#1844)) ([87b9be9](87b9be9)) * tweak arguments for magic link client hash ([#1862](#1862)) ([8dcd45e](8dcd45e)) ### Features * **active-campaign:** metadata improvements ([#1851](#1851)) ([48883af](48883af)) * **active-campaigns:** override is-new-contact for legacy contacts ([34dd9a2](34dd9a2)) * **analytics:** send GA events on the server side ([#1828](#1828)) ([3e384e1](3e384e1)) * **donations:** remove defaultFrequency from the configuration ([#1814](#1814)) ([b6aa894](b6aa894)) * handle contact update w/out lists selection ([#1816](#1816)) ([67574d1](67574d1)) * handle new frequency options in Campaigns dashbaord ([#1779](#1779)) ([c770a7d](c770a7d)) * if registering an email that already has an account, show different message ([#1849](#1849)) ([bf48bc4](bf48bc4)) * **my-account:** stripe billing portal link ([#1761](#1761)) ([3e69af1](3e69af1)), closes [#1742](#1742) [#1739](#1739) [#1740](#1740) [#1741](#1741) [#1782](#1782) * **reader-activation:** account link and auth form ([#1754](#1754)) ([b163664](b163664)) * **reader-activation:** activecampaign master list ([#1818](#1818)) ([ecbbc47](ecbbc47)) * **reader-activation:** disable 3rd party login buttons initially ([#1806](#1806)) ([c806bfe](c806bfe)) * **reader-activation:** optimistic account link ([#1847](#1847)) ([85c550a](85c550a)) * **reader-activation:** prevent updating user email in my-account ([7d49db4](7d49db4)) * **reader-activation:** registration auth cookie control ([#1787](#1787)) ([aeb0b5b](aeb0b5b)) * **reader-activation:** settings wizard ([#1773](#1773)) ([aaff0de](aaff0de)) * **reader-auth:** make password login the first option, instead of login link ([1fe5ffa](1fe5ffa)), closes [#1809](#1809) * register anonymous single donors ([#1795](#1795)) ([9e4f2f6](9e4f2f6)) * **registration-block:** add success icon ([#1804](#1804)) ([86c38f8](86c38f8)) * **registration-block:** editable success state ([#1785](#1785)) ([7dcea82](7dcea82)), closes [#1768](#1768) * **registration-block:** login with Google ([#1781](#1781)) ([ed79c5c](ed79c5c)), closes [#1774](#1774) * **registration-block:** newsletter subscription ([#1778](#1778)) ([717b5b8](717b5b8)) * reorganise donations wizard and use buttongroup for donation type ([#1824](#1824)) ([f7b58ae](f7b58ae)) * replace WooCommerce’s login form with our own ([#1854](#1854)) ([f5b24c4](f5b24c4)) * **rss:** adds offset feature ([#1790](#1790)) ([321eff5](321eff5)) * send user metadata to AC ([#1793](#1793)) ([03a15ba](03a15ba)) * set client id cookie; reader activation tweaks ([#1780](#1780)) ([96a07ae](96a07ae)) * **stripe:** webhook auto-creation and validation ([365aed9](365aed9)) * tweak registration block styling ([d83448e](d83448e)) ### Reverts * Revert "chore(release): 1.87.0 [skip ci]" ([ca8d55c](ca8d55c))

matticbot · 2022-08-05T22:38:46Z

🎉 This PR is included in version 1.88.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

* feat: replace WooCommerce’s login form with our own * fix: use WC method to get account URL Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * refactor: call render method from template file * feat: hide page title on WC account pages * refactor: restore modal on My Account pages; handle multiple form instancse * refactor: use $class method to build inline class Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * style: remove unneeded padding from inline form * fix: move handlers and functions outside of loop * chore: reword auth message for consistency * fix: avoid JS error if redirect input is null * fix: avoid JS error if email input is null Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com>

# [1.89.0-alpha.1](v1.88.0...v1.89.0-alpha.1) (2022-08-10) ### Bug Fixes * **active-campaign:** legacy contacts detection ([#1858](#1858)) ([67640a5](67640a5)) * **campaigns-wizard:** segmentation wording ([ddf61ad](ddf61ad)) * ensure scroll on smaller height ([#1813](#1813)) ([e234e8b](e234e8b)) * fix fatal error when debug mode active ([#1826](#1826)) ([d9388ee](d9388ee)) * **ga:** cookie parsing ([#1857](#1857)) ([a936abd](a936abd)) * google auth button type ([#1829](#1829)) ([3704d9f](3704d9f)) * **google-auth:** ensure popup on user click event ([#1831](#1831)) ([0af9abf](0af9abf)) * **magic-links:** fix email encoding on sent link ([#1833](#1833)) ([8d4756c](8d4756c)) * **my account:** handle legacy data ([#1823](#1823)) ([6816799](6816799)) * **newsletters:** use international date format ([#1855](#1855)) ([4cda57d](4cda57d)) * **popups:** use new Campaigns method for creating donation events on new orders ([#1794](#1794)) ([49dc14c](49dc14c)) * **reader-activation:** add metadata to reader registered on donation ([722724c](722724c)) * **reader-activation:** handle modal conflict when auth is triggered from a prompt ([c2a0141](c2a0141)), closes [#1835](#1835) * **reader-activation:** handle no lists config available ([23b0249](23b0249)) * **reader-activation:** reinitialize auth links after DOM load ([#1812](#1812)) ([0a4b499](0a4b499)) * **reader-activation:** remove async prop from library ([#1846](#1846)) ([4131ca6](4131ca6)) * **reader-activation:** username generation handling ([#1789](#1789)) ([17edf2a](17edf2a)) * **registration-block:** don't escape html for sign in labels ([#1834](#1834)) ([871300d](871300d)) * **registration-block:** margin for success message ([#1808](#1808)) ([1bfe546](1bfe546)) * **registration-block:** render on preview ([#1844](#1844)) ([87b9be9](87b9be9)) * tweak arguments for magic link client hash ([#1862](#1862)) ([8dcd45e](8dcd45e)) ### Features * **active-campaign:** metadata improvements ([#1851](#1851)) ([48883af](48883af)) * **active-campaigns:** override is-new-contact for legacy contacts ([34dd9a2](34dd9a2)) * **analytics:** send GA events on the server side ([#1828](#1828)) ([3e384e1](3e384e1)) * **donations:** remove defaultFrequency from the configuration ([#1814](#1814)) ([b6aa894](b6aa894)) * handle contact update w/out lists selection ([#1816](#1816)) ([67574d1](67574d1)) * handle new frequency options in Campaigns dashbaord ([#1779](#1779)) ([c770a7d](c770a7d)) * if registering an email that already has an account, show different message ([#1849](#1849)) ([bf48bc4](bf48bc4)) * **my-account:** stripe billing portal link ([#1761](#1761)) ([3e69af1](3e69af1)), closes [#1742](#1742) [#1739](#1739) [#1740](#1740) [#1741](#1741) [#1782](#1782) * **reader-activation:** account link and auth form ([#1754](#1754)) ([b163664](b163664)) * **reader-activation:** activecampaign master list ([#1818](#1818)) ([ecbbc47](ecbbc47)) * **reader-activation:** disable 3rd party login buttons initially ([#1806](#1806)) ([c806bfe](c806bfe)) * **reader-activation:** optimistic account link ([#1847](#1847)) ([85c550a](85c550a)) * **reader-activation:** prevent updating user email in my-account ([7d49db4](7d49db4)) * **reader-activation:** registration auth cookie control ([#1787](#1787)) ([aeb0b5b](aeb0b5b)) * **reader-activation:** settings wizard ([#1773](#1773)) ([aaff0de](aaff0de)) * **reader-auth:** make password login the first option, instead of login link ([1fe5ffa](1fe5ffa)), closes [#1809](#1809) * register anonymous single donors ([#1795](#1795)) ([9e4f2f6](9e4f2f6)) * **registration-block:** add success icon ([#1804](#1804)) ([86c38f8](86c38f8)) * **registration-block:** editable success state ([#1785](#1785)) ([7dcea82](7dcea82)), closes [#1768](#1768) * **registration-block:** login with Google ([#1781](#1781)) ([ed79c5c](ed79c5c)), closes [#1774](#1774) * **registration-block:** newsletter subscription ([#1778](#1778)) ([717b5b8](717b5b8)) * reorganise donations wizard and use buttongroup for donation type ([#1824](#1824)) ([f7b58ae](f7b58ae)) * replace WooCommerce’s login form with our own ([#1854](#1854)) ([f5b24c4](f5b24c4)) * **rss:** adds offset feature ([#1790](#1790)) ([321eff5](321eff5)) * send user metadata to AC ([#1793](#1793)) ([03a15ba](03a15ba)) * set client id cookie; reader activation tweaks ([#1780](#1780)) ([96a07ae](96a07ae)) * **stripe:** webhook auto-creation and validation ([365aed9](365aed9)) * tweak registration block styling ([d83448e](d83448e)) ### Reverts * Revert "chore(release): 1.87.0 [skip ci]" ([ca8d55c](ca8d55c))

matticbot · 2022-08-10T22:13:53Z

🎉 This PR is included in version 1.89.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.89.0](v1.88.0...v1.89.0) (2022-08-16) ### Bug Fixes * **active-campaign:** legacy contacts detection ([#1858](#1858)) ([67640a5](67640a5)) * **campaigns-wizard:** segmentation wording ([ddf61ad](ddf61ad)) * ensure scroll on smaller height ([#1813](#1813)) ([e234e8b](e234e8b)) * fix fatal error when debug mode active ([#1826](#1826)) ([d9388ee](d9388ee)) * **ga:** cookie parsing ([#1857](#1857)) ([a936abd](a936abd)) * google auth button type ([#1829](#1829)) ([3704d9f](3704d9f)) * **google-auth:** catch and display errors ([#1871](#1871)) ([67cbcfd](67cbcfd)) * **google-auth:** ensure popup on user click event ([#1831](#1831)) ([0af9abf](0af9abf)) * **magic-links:** fix email encoding on sent link ([#1833](#1833)) ([8d4756c](8d4756c)) * **my account:** handle legacy data ([#1823](#1823)) ([6816799](6816799)) * **newsletters:** use international date format ([#1855](#1855)) ([4cda57d](4cda57d)) * **oauth:** csrf token lifespan ([#1869](#1869)) ([52e0f8b](52e0f8b)) * parse CID from _ga cookie if it only contains CID string ([#1874](#1874)) ([dc1fb52](dc1fb52)) * **popups:** use new Campaigns method for creating donation events on new orders ([#1794](#1794)) ([49dc14c](49dc14c)) * **reader-activation:** add metadata to reader registered on donation ([722724c](722724c)) * **reader-activation:** handle modal conflict when auth is triggered from a prompt ([c2a0141](c2a0141)), closes [#1835](#1835) * **reader-activation:** handle no lists config available ([23b0249](23b0249)) * **reader-activation:** reinitialize auth links after DOM load ([#1812](#1812)) ([0a4b499](0a4b499)) * **reader-activation:** remove async prop from library ([#1846](#1846)) ([4131ca6](4131ca6)) * **reader-activation:** username generation handling ([#1789](#1789)) ([17edf2a](17edf2a)) * redirecting to My Account after logging in while pre-authed ([#1863](#1863)) ([ddf111e](ddf111e)) * **registration-block:** don't escape html for sign in labels ([#1834](#1834)) ([871300d](871300d)) * **registration-block:** margin for success message ([#1808](#1808)) ([1bfe546](1bfe546)) * **registration-block:** render on preview ([#1844](#1844)) ([87b9be9](87b9be9)) * tweak arguments for magic link client hash ([#1862](#1862)) ([8dcd45e](8dcd45e)) * verify reader on google authentication ([#1873](#1873)) ([c9c4eef](c9c4eef)) ### Features * **active-campaign:** metadata improvements ([#1851](#1851)) ([48883af](48883af)) * **active-campaigns:** override is-new-contact for legacy contacts ([34dd9a2](34dd9a2)) * **analytics:** send GA events on the server side ([#1828](#1828)) ([3e384e1](3e384e1)) * authenticated reader cookie ([#1882](#1882)) ([352316b](352316b)) * better welcome email copy for initial verification ([#1880](#1880)) ([604ebf7](604ebf7)) * cookie reader's preferred auth strategy ([#1875](#1875)) ([fc47f41](fc47f41)) * disable woocomerce welcome emails in favor of verification email ([#1876](#1876)) ([1e470e3](1e470e3)) * **donations:** remove defaultFrequency from the configuration ([#1814](#1814)) ([b6aa894](b6aa894)) * handle contact update w/out lists selection ([#1816](#1816)) ([67574d1](67574d1)) * handle new frequency options in Campaigns dashbaord ([#1779](#1779)) ([c770a7d](c770a7d)) * if registering an email that already has an account, show different message ([#1849](#1849)) ([bf48bc4](bf48bc4)) * lock access to My Account UI until account is verified ([#1877](#1877)) ([a850f48](a850f48)) * **my-account:** stripe billing portal link ([#1761](#1761)) ([3e69af1](3e69af1)), closes [#1742](#1742) [#1739](#1739) [#1740](#1740) [#1741](#1741) [#1782](#1782) * **reader-activation:** account link and auth form ([#1754](#1754)) ([b163664](b163664)) * **reader-activation:** activecampaign master list ([#1818](#1818)) ([ecbbc47](ecbbc47)) * **reader-activation:** disable 3rd party login buttons initially ([#1806](#1806)) ([c806bfe](c806bfe)) * **reader-activation:** optimistic account link ([#1847](#1847)) ([85c550a](85c550a)) * **reader-activation:** prevent updating user email in my-account ([7d49db4](7d49db4)) * **reader-activation:** registration auth cookie control ([#1787](#1787)) ([aeb0b5b](aeb0b5b)) * **reader-activation:** settings wizard ([#1773](#1773)) ([aaff0de](aaff0de)) * **reader-auth:** make password login the first option, instead of login link ([1fe5ffa](1fe5ffa)), closes [#1809](#1809) * register anonymous single donors ([#1795](#1795)) ([9e4f2f6](9e4f2f6)) * **registration-block:** add success icon ([#1804](#1804)) ([86c38f8](86c38f8)) * **registration-block:** editable success state ([#1785](#1785)) ([7dcea82](7dcea82)), closes [#1768](#1768) * **registration-block:** login with Google ([#1781](#1781)) ([ed79c5c](ed79c5c)), closes [#1774](#1774) * **registration-block:** newsletter subscription ([#1778](#1778)) ([717b5b8](717b5b8)) * reorganise donations wizard and use buttongroup for donation type ([#1824](#1824)) ([f7b58ae](f7b58ae)) * replace WooCommerce’s login form with our own ([#1854](#1854)) ([f5b24c4](f5b24c4)) * **rss:** adds offset feature ([#1790](#1790)) ([321eff5](321eff5)) * send user metadata to AC ([#1793](#1793)) ([03a15ba](03a15ba)) * set client id cookie; reader activation tweaks ([#1780](#1780)) ([96a07ae](96a07ae)) * **stripe:** webhook auto-creation and validation ([365aed9](365aed9)) * tweak registration block styling ([d83448e](d83448e)) ### Reverts * Revert "chore(release): 1.87.0 [skip ci]" ([ca8d55c](ca8d55c))

matticbot · 2022-08-16T18:08:22Z

🎉 This PR is included in version 1.89.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

feat: replace WooCommerce’s login form with our own

ef8a537

dkoo added [Type] Enhancement Improved behavior or functionality Reader Activation labels Aug 4, 2022

dkoo requested a review from a team as a code owner August 4, 2022 19:26

dkoo self-assigned this Aug 4, 2022

miguelpeixe requested changes Aug 4, 2022

View reviewed changes

includes/templates/reader-activation/login-form.php Show resolved Hide resolved

includes/class-reader-activation.php Outdated Show resolved Hide resolved

includes/class-reader-activation.php Outdated Show resolved Hide resolved

dkoo and others added 3 commits August 4, 2022 14:37

fix: use WC method to get account URL

000d0ae

Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com>

refactor: call render method from template file

4d6f9d2

feat: hide page title on WC account pages

6342ad1

dkoo requested a review from miguelpeixe August 4, 2022 20:44

miguelpeixe requested changes Aug 4, 2022

View reviewed changes

includes/class-reader-activation.php Outdated Show resolved Hide resolved

dkoo and others added 3 commits August 4, 2022 14:54

refactor: restore modal on My Account pages; handle multiple form ins…

9db42f5

…tancse

refactor: use $class method to build inline class

95c82d5

Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com>

style: remove unneeded padding from inline form

23f56e4

dkoo requested a review from miguelpeixe August 4, 2022 20:59

miguelpeixe requested changes Aug 4, 2022

View reviewed changes

assets/reader-activation/auth.js Outdated Show resolved Hide resolved

assets/reader-activation/auth.js Outdated Show resolved Hide resolved

assets/reader-activation/auth.js Outdated Show resolved Hide resolved

dkoo added 4 commits August 4, 2022 15:26

fix: move handlers and functions outside of loop

b08d5bc

chore: reword auth message for consistency

5ff76f6

fix: avoid JS error if redirect input is null

f897d93

fix: avoid JS error if email input is null

4f687d3

dkoo requested a review from miguelpeixe August 4, 2022 21:38

miguelpeixe approved these changes Aug 4, 2022

View reviewed changes

github-actions bot added the [Status] Approved The pull request has been reviewed and is ready to merge label Aug 4, 2022

dkoo merged commit f5b24c4 into master Aug 4, 2022

dkoo deleted the feat/replace-wc-login-form branch August 4, 2022 21:50

dkoo mentioned this pull request Aug 5, 2022

fix: redirecting to My Account after logging in while pre-authed #1863

Merged

6 tasks

matticbot added the released on @alpha label Aug 5, 2022

matticbot added the released label Aug 16, 2022

leogermani mentioned this pull request Sep 6, 2022

redirect to site home page from my account #1977

Closed

3 tasks

feat: replace WooCommerce’s login form with our own #1854

feat: replace WooCommerce’s login form with our own #1854

Uh oh!

Conversation

dkoo commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Uh oh!

miguelpeixe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dkoo commented Aug 4, 2022

Uh oh!

miguelpeixe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dkoo commented Aug 4, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miguelpeixe left a comment

Choose a reason for hiding this comment

Uh oh!

dkoo commented Aug 4, 2022

Uh oh!

matticbot commented Aug 5, 2022

Uh oh!

matticbot commented Aug 10, 2022

Uh oh!

matticbot commented Aug 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dkoo commented Aug 4, 2022 •

edited

Loading