feat(registration-block): editable success state #1785

adekbadek · 2022-07-15T15:17:52Z

All Submissions:

Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Because this code introduces a save handler on the block, a warning will be shown in the editor. Since the relevant features (Reader Activation) are behind a flag and not officially released yet, I don't think this is an issue.

Due to constraints of the block editor – a block can have only one block-editable area ("inner blocks") – there's only one success state. This means that the same message (with note about confirmation email) will be displayed regardless of whether the reader has an account or not. This is accurate, though, because the email will be sent anyway. Also, this way the response does not reveal if the email exists in the database. WDYT @miguelpeixe ?

I'm not aware of a convention for editing block "states" – here's the switch implemented in this PR:

Please share your thoughts @thomasguillot 👆

Closes #1768.

How to test the changes in this Pull Request:

On master, insert the Reader Registration block on a page
Switch to this branch, observe the block working as before on front-end
Open the editor, observe a notice about needing block recovery – click the block recovery button and observe the recovery succeeding
Save the post, observe it's still working as expected on front-end
In the editor, observe a new sidebar panel – "Edited state" – with a "Initial"/"Success" toggle
Edit the success state by switching the edited state
On the front-end, observe the new success state is displayed after registering

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?

adekbadek · 2022-07-15T15:28:46Z

I've noticed that there are actually two success states – "check your email" and "thank you for registering", but WP blocks allow only one inner-blocks container.

miguelpeixe · 2022-07-15T15:45:36Z

I think this could be handled universally through settings placed on the Engagement wizard (#1773)

miguelpeixe · 2022-07-15T16:19:08Z

Also, this way the response does not reveal if the email exists in the database.

We shouldn't be too worried about that. Anyone attempting to register a new account will know if the email exists in the database.

thomasguillot · 2022-07-19T07:48:56Z

We could use something similar to the ToggleGroupControl and have the states in the toolbar instead of in the sidebar.

adekbadek · 2022-07-19T08:58:51Z

@thomasguillot – that's how I've initially implemented it, but the quirk of "inner blocks blocks" is that the top-level-block toolbar is not visible when there's content inside. For example with columns block, clicking on the block selects the child block, and its toolbar is visible.

adekbadek · 2022-07-19T08:59:22Z

@miguelpeixe –

I think this could be handled universally through settings placed on the Engagement wizard (#1773)

Yeah, the default value could be editable there.

thomasguillot · 2022-07-19T10:17:41Z

that's how I've initially implemented it, but the quirk of "inner blocks blocks" is that the top-level-block toolbar is not visible when there's content inside

Oh I see. A bit annoying.

Ok, so I wonder if we could display some sort of "inner toolbar" at the top when the block (and child blocks) are selected.

adekbadek · 2022-07-19T12:14:29Z

@thomasguillot Good idea, don in f67274d ! Feels a bit weird with the toggle (suggesting an on/off state, not A/B switch), but gets the job done.

thomasguillot · 2022-07-19T14:28:54Z

Feels a bit weird with the toggle (suggesting an on/off state, not A/B switch), but gets the job done.

Hmm yeah you're right. And I guess it's limiting if we end up adding more states. Could we switch to buttons?

Also, can we have this "toolbar" visible only on focus?

adekbadek · 2022-07-20T10:08:46Z

Could we switch to buttons?

Done in d8e5818

Also, can we have this "toolbar" visible only on focus?

Someday, maybe, but I don't think it's a blocker for now.

thomasguillot · 2022-07-22T14:09:16Z

Pushed some small tweaks 84c9862

miguelpeixe

The rendered block does not currently reflect the editor:

Editor	Rendered

The text color and position of privacy text are off. Also, the initial state of the success message shows as a separate paragraph but renders in one line.

miguelpeixe · 2022-07-25T14:56:47Z

assets/blocks/reader-registration/edit.js

 */
 import './editor.scss';

+const variantOptions = [


NIT: variant does not feel like a proper name for this. How about blockState?

Fixed in 2ae7720

adekbadek · 2022-07-25T19:04:39Z

@miguelpeixe –

The text color and position of privacy text are off. Also, the initial state of the success message shows as a separate paragraph but renders in one line.

Fixed in 2ae7720 & a5714b5

miguelpeixe

🎉

* feat: set client id cookie; reader activation tweaks (#1780) * feat(reader-activation): registration auth cookie control (#1787) * fix(reader-activation): username generation handling (#1789) * feat(stripe): webhook auto-creation and validation * feat(reader-activation): account link and auth form (#1754) Co-authored-by: Adam Boro <adam@adamboro.com> * feat: handle new frequency options in Campaigns dashbaord (#1779) * feat: handle new frequency options in Campaigns dashbaord * feat: only enable new frequency options if reader activation flag is on * feat(registration-block): newsletter subscription (#1778) * fix(popups): use new Campaigns method for creating donation events on new orders (#1794) * fix(popups): use new Campaigns method for creating donation events on new orders * refactor: use action hook instead of calling Campaigns methods directly * chore: remove unneeded condition * refactor: use a hook for WooCommerce donations, too * fix: add client_id to contact info passed from Stripe * feat(my-account): stripe billing portal link (#1761) Note: some styling relies on Automattic/newspack-theme#1875 Closes #1742 Closes #1739 Closes #1740 Closes #1741 Closes #1782 * feat(registration-block): login with Google (#1781) Closes #1774 Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * chore(deps): bump @babel/preset-env from 7.18.6 to 7.18.9 Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.18.6 to 7.18.9. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.18.9/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/preset-env" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump date-fns from 2.28.0 to 2.29.1 Bumps [date-fns](https://github.com/date-fns/date-fns) from 2.28.0 to 2.29.1. - [Release notes](https://github.com/date-fns/date-fns/releases) - [Changelog](https://github.com/date-fns/date-fns/blob/master/CHANGELOG.md) - [Commits](date-fns/date-fns@v2.28.0...v2.29.1) --- updated-dependencies: - dependency-name: date-fns dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump @babel/plugin-transform-runtime from 7.18.6 to 7.18.9 Bumps [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime) from 7.18.6 to 7.18.9. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.18.9/packages/babel-plugin-transform-runtime) --- updated-dependencies: - dependency-name: "@babel/plugin-transform-runtime" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump stripe/stripe-php from 8.10.0 to 8.11.0 Bumps [stripe/stripe-php](https://github.com/stripe/stripe-php) from 8.10.0 to 8.11.0. - [Release notes](https://github.com/stripe/stripe-php/releases) - [Changelog](https://github.com/stripe/stripe-php/blob/master/CHANGELOG.md) - [Commits](stripe/stripe-php@v8.10.0...v8.11.0) --- updated-dependencies: - dependency-name: stripe/stripe-php dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * feat: register anonymous single donors (#1795) Co-authored-by: Adam Borowski <adam@adamboro.com> * feat(registration-block): editable success state (#1785) Closes #1768 Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com> * feat(registration-block): add success icon (#1804) * refactor: remove unneeded prop * feat: send user metadata to AC (#1793) * feat: remove reader registration on adding contact via hook This was causing an infinite loop: Newsletters is triggering reader registration when a contact is added (`Newspack_Newsletters_Subscription::newspack_registered_reader`). Then, on adding a contact, registration was triggered again here. * fix(registration-block): margin for success message (#1808) * Reader Activation: auth form with third-party and lists subscriptions (#1800) * feat: tweak registration block styling * feat(reader-auth): make password login the first option, instead of login link Closes #1809 * fix(reader-activation): reinitialize auth links after DOM load (#1812) * fix: ensure scroll on smaller height (#1813) * feat(reader-activation): settings wizard (#1773) Co-authored-by: Adam Boro <adam@adamboro.com> * feat: handle contact update w/out lists selection (#1816) Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * chore: logger update (#1807) Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * feat(reader-activation): disable 3rd party login buttons initially (#1806) * feat(reader-activation): prevent updating user email in my-account * feat(reader-activation): activecampaign master list (#1818) Co-authored-by: Adam Boro <adam@adamboro.com> * chore(deps): bump stripe/stripe-php from 8.11.0 to 8.12.0 Bumps [stripe/stripe-php](https://github.com/stripe/stripe-php) from 8.11.0 to 8.12.0. - [Release notes](https://github.com/stripe/stripe-php/releases) - [Changelog](https://github.com/stripe/stripe-php/blob/master/CHANGELOG.md) - [Commits](stripe/stripe-php@v8.11.0...v8.12.0) --- updated-dependencies: - dependency-name: stripe/stripe-php dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix(campaigns-wizard): segmentation wording * feat(rss): adds offset feature (#1790) Adds offset feature to RSS, allowing better ad integration with RSS feed based emails * fix(reader-activation): handle no lists config available * fix: fix fatal error when debug mode active (#1826) * feat: reorganise donations wizard and use buttongroup for donation type (#1824) * fix: google auth button type (#1829) * fix(magic-links): fix email encoding on sent link (#1833) * fix(registration-block): don't escape html for sign in labels (#1834) * fix(reader-activation): add metadata to reader registered on donation * fix(registration-block): render on preview (#1844) Co-authored-by: Derrick Koo <dkoo@users.noreply.github.com> * fix(reader-activation): remove async prop from library (#1846) * feat(analytics): send GA events on the server side (#1828) * refactor: abstract server-side GA custom event sending * feat(reader-activation): send custom event to GA on reader registration * feat: report user login method to GA; refactor how it's stored * refactor: handle extended data from the newspack_newsletters_contact_data hook * feat: send NTG custom events on registration, newsletter signup * fix(my account): handle legacy data (#1823) * fix(reader-activation): handle modal conflict when auth is triggered from a prompt Closes #1835 * feat(reader-activation): optimistic account link (#1847) * fix(google-auth): ensure popup on user click event (#1831) Co-authored-by: Adam Boro <adam@adamboro.com> * feat(active-campaigns): override is-new-contact for legacy contacts * feat(active-campaign): metadata improvements (#1851) * feat: if registering an email that already has an account, show different message (#1849) * feat: if registering an email that already has an account, show different message * refactor: use existing var * feat: replace WooCommerce’s login form with our own (#1854) * feat: replace WooCommerce’s login form with our own * fix: use WC method to get account URL Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * refactor: call render method from template file * feat: hide page title on WC account pages * refactor: restore modal on My Account pages; handle multiple form instancse * refactor: use $class method to build inline class Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * style: remove unneeded padding from inline form * fix: move handlers and functions outside of loop * chore: reword auth message for consistency * fix: avoid JS error if redirect input is null * fix: avoid JS error if email input is null Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> * fix(newsletters): use international date format (#1855) * fix: tweak arguments for magic link client hash (#1862) * feat(donations): remove defaultFrequency from the configuration (#1814) It's not configurable. See Automattic/newspack-blocks#1218 * fix(ga): cookie parsing (#1857) * fix(active-campaign): legacy contacts detection (#1858) Co-authored-by: Adam Boro <adam@adamboro.com> Co-authored-by: Miguel Peixe <miguel.peixe@automattic.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com> Co-authored-by: matticbot <sysops+ghmatticbot@automattic.com> Co-authored-by: dnalla1928 <53319922+dnalla1928@users.noreply.github.com> Co-authored-by: Claudiu Lodromanean <claudiulodro@gmail.com>

# [1.88.0-alpha.1](v1.87.0...v1.88.0-alpha.1) (2022-08-05) ### Bug Fixes * **active-campaign:** legacy contacts detection ([#1858](#1858)) ([67640a5](67640a5)) * **campaigns-wizard:** segmentation wording ([ddf61ad](ddf61ad)) * ensure scroll on smaller height ([#1813](#1813)) ([e234e8b](e234e8b)) * fix fatal error when debug mode active ([#1826](#1826)) ([d9388ee](d9388ee)) * **ga:** cookie parsing ([#1857](#1857)) ([a936abd](a936abd)) * google auth button type ([#1829](#1829)) ([3704d9f](3704d9f)) * **google-auth:** ensure popup on user click event ([#1831](#1831)) ([0af9abf](0af9abf)) * **magic-links:** fix email encoding on sent link ([#1833](#1833)) ([8d4756c](8d4756c)) * **my account:** handle legacy data ([#1823](#1823)) ([6816799](6816799)) * **newsletters:** use international date format ([#1855](#1855)) ([4cda57d](4cda57d)) * **popups:** use new Campaigns method for creating donation events on new orders ([#1794](#1794)) ([49dc14c](49dc14c)) * **reader-activation:** add metadata to reader registered on donation ([722724c](722724c)) * **reader-activation:** handle modal conflict when auth is triggered from a prompt ([c2a0141](c2a0141)), closes [#1835](#1835) * **reader-activation:** handle no lists config available ([23b0249](23b0249)) * **reader-activation:** reinitialize auth links after DOM load ([#1812](#1812)) ([0a4b499](0a4b499)) * **reader-activation:** remove async prop from library ([#1846](#1846)) ([4131ca6](4131ca6)) * **reader-activation:** username generation handling ([#1789](#1789)) ([17edf2a](17edf2a)) * **registration-block:** don't escape html for sign in labels ([#1834](#1834)) ([871300d](871300d)) * **registration-block:** margin for success message ([#1808](#1808)) ([1bfe546](1bfe546)) * **registration-block:** render on preview ([#1844](#1844)) ([87b9be9](87b9be9)) * tweak arguments for magic link client hash ([#1862](#1862)) ([8dcd45e](8dcd45e)) ### Features * **active-campaign:** metadata improvements ([#1851](#1851)) ([48883af](48883af)) * **active-campaigns:** override is-new-contact for legacy contacts ([34dd9a2](34dd9a2)) * **analytics:** send GA events on the server side ([#1828](#1828)) ([3e384e1](3e384e1)) * **donations:** remove defaultFrequency from the configuration ([#1814](#1814)) ([b6aa894](b6aa894)) * handle contact update w/out lists selection ([#1816](#1816)) ([67574d1](67574d1)) * handle new frequency options in Campaigns dashbaord ([#1779](#1779)) ([c770a7d](c770a7d)) * if registering an email that already has an account, show different message ([#1849](#1849)) ([bf48bc4](bf48bc4)) * **my-account:** stripe billing portal link ([#1761](#1761)) ([3e69af1](3e69af1)), closes [#1742](#1742) [#1739](#1739) [#1740](#1740) [#1741](#1741) [#1782](#1782) * **reader-activation:** account link and auth form ([#1754](#1754)) ([b163664](b163664)) * **reader-activation:** activecampaign master list ([#1818](#1818)) ([ecbbc47](ecbbc47)) * **reader-activation:** disable 3rd party login buttons initially ([#1806](#1806)) ([c806bfe](c806bfe)) * **reader-activation:** optimistic account link ([#1847](#1847)) ([85c550a](85c550a)) * **reader-activation:** prevent updating user email in my-account ([7d49db4](7d49db4)) * **reader-activation:** registration auth cookie control ([#1787](#1787)) ([aeb0b5b](aeb0b5b)) * **reader-activation:** settings wizard ([#1773](#1773)) ([aaff0de](aaff0de)) * **reader-auth:** make password login the first option, instead of login link ([1fe5ffa](1fe5ffa)), closes [#1809](#1809) * register anonymous single donors ([#1795](#1795)) ([9e4f2f6](9e4f2f6)) * **registration-block:** add success icon ([#1804](#1804)) ([86c38f8](86c38f8)) * **registration-block:** editable success state ([#1785](#1785)) ([7dcea82](7dcea82)), closes [#1768](#1768) * **registration-block:** login with Google ([#1781](#1781)) ([ed79c5c](ed79c5c)), closes [#1774](#1774) * **registration-block:** newsletter subscription ([#1778](#1778)) ([717b5b8](717b5b8)) * reorganise donations wizard and use buttongroup for donation type ([#1824](#1824)) ([f7b58ae](f7b58ae)) * replace WooCommerce’s login form with our own ([#1854](#1854)) ([f5b24c4](f5b24c4)) * **rss:** adds offset feature ([#1790](#1790)) ([321eff5](321eff5)) * send user metadata to AC ([#1793](#1793)) ([03a15ba](03a15ba)) * set client id cookie; reader activation tweaks ([#1780](#1780)) ([96a07ae](96a07ae)) * **stripe:** webhook auto-creation and validation ([365aed9](365aed9)) * tweak registration block styling ([d83448e](d83448e)) ### Reverts * Revert "chore(release): 1.87.0 [skip ci]" ([ca8d55c](ca8d55c))

matticbot · 2022-08-05T22:40:55Z

🎉 This PR is included in version 1.88.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Closes #1768 Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com>

# [1.89.0-alpha.1](v1.88.0...v1.89.0-alpha.1) (2022-08-10) ### Bug Fixes * **active-campaign:** legacy contacts detection ([#1858](#1858)) ([67640a5](67640a5)) * **campaigns-wizard:** segmentation wording ([ddf61ad](ddf61ad)) * ensure scroll on smaller height ([#1813](#1813)) ([e234e8b](e234e8b)) * fix fatal error when debug mode active ([#1826](#1826)) ([d9388ee](d9388ee)) * **ga:** cookie parsing ([#1857](#1857)) ([a936abd](a936abd)) * google auth button type ([#1829](#1829)) ([3704d9f](3704d9f)) * **google-auth:** ensure popup on user click event ([#1831](#1831)) ([0af9abf](0af9abf)) * **magic-links:** fix email encoding on sent link ([#1833](#1833)) ([8d4756c](8d4756c)) * **my account:** handle legacy data ([#1823](#1823)) ([6816799](6816799)) * **newsletters:** use international date format ([#1855](#1855)) ([4cda57d](4cda57d)) * **popups:** use new Campaigns method for creating donation events on new orders ([#1794](#1794)) ([49dc14c](49dc14c)) * **reader-activation:** add metadata to reader registered on donation ([722724c](722724c)) * **reader-activation:** handle modal conflict when auth is triggered from a prompt ([c2a0141](c2a0141)), closes [#1835](#1835) * **reader-activation:** handle no lists config available ([23b0249](23b0249)) * **reader-activation:** reinitialize auth links after DOM load ([#1812](#1812)) ([0a4b499](0a4b499)) * **reader-activation:** remove async prop from library ([#1846](#1846)) ([4131ca6](4131ca6)) * **reader-activation:** username generation handling ([#1789](#1789)) ([17edf2a](17edf2a)) * **registration-block:** don't escape html for sign in labels ([#1834](#1834)) ([871300d](871300d)) * **registration-block:** margin for success message ([#1808](#1808)) ([1bfe546](1bfe546)) * **registration-block:** render on preview ([#1844](#1844)) ([87b9be9](87b9be9)) * tweak arguments for magic link client hash ([#1862](#1862)) ([8dcd45e](8dcd45e)) ### Features * **active-campaign:** metadata improvements ([#1851](#1851)) ([48883af](48883af)) * **active-campaigns:** override is-new-contact for legacy contacts ([34dd9a2](34dd9a2)) * **analytics:** send GA events on the server side ([#1828](#1828)) ([3e384e1](3e384e1)) * **donations:** remove defaultFrequency from the configuration ([#1814](#1814)) ([b6aa894](b6aa894)) * handle contact update w/out lists selection ([#1816](#1816)) ([67574d1](67574d1)) * handle new frequency options in Campaigns dashbaord ([#1779](#1779)) ([c770a7d](c770a7d)) * if registering an email that already has an account, show different message ([#1849](#1849)) ([bf48bc4](bf48bc4)) * **my-account:** stripe billing portal link ([#1761](#1761)) ([3e69af1](3e69af1)), closes [#1742](#1742) [#1739](#1739) [#1740](#1740) [#1741](#1741) [#1782](#1782) * **reader-activation:** account link and auth form ([#1754](#1754)) ([b163664](b163664)) * **reader-activation:** activecampaign master list ([#1818](#1818)) ([ecbbc47](ecbbc47)) * **reader-activation:** disable 3rd party login buttons initially ([#1806](#1806)) ([c806bfe](c806bfe)) * **reader-activation:** optimistic account link ([#1847](#1847)) ([85c550a](85c550a)) * **reader-activation:** prevent updating user email in my-account ([7d49db4](7d49db4)) * **reader-activation:** registration auth cookie control ([#1787](#1787)) ([aeb0b5b](aeb0b5b)) * **reader-activation:** settings wizard ([#1773](#1773)) ([aaff0de](aaff0de)) * **reader-auth:** make password login the first option, instead of login link ([1fe5ffa](1fe5ffa)), closes [#1809](#1809) * register anonymous single donors ([#1795](#1795)) ([9e4f2f6](9e4f2f6)) * **registration-block:** add success icon ([#1804](#1804)) ([86c38f8](86c38f8)) * **registration-block:** editable success state ([#1785](#1785)) ([7dcea82](7dcea82)), closes [#1768](#1768) * **registration-block:** login with Google ([#1781](#1781)) ([ed79c5c](ed79c5c)), closes [#1774](#1774) * **registration-block:** newsletter subscription ([#1778](#1778)) ([717b5b8](717b5b8)) * reorganise donations wizard and use buttongroup for donation type ([#1824](#1824)) ([f7b58ae](f7b58ae)) * replace WooCommerce’s login form with our own ([#1854](#1854)) ([f5b24c4](f5b24c4)) * **rss:** adds offset feature ([#1790](#1790)) ([321eff5](321eff5)) * send user metadata to AC ([#1793](#1793)) ([03a15ba](03a15ba)) * set client id cookie; reader activation tweaks ([#1780](#1780)) ([96a07ae](96a07ae)) * **stripe:** webhook auto-creation and validation ([365aed9](365aed9)) * tweak registration block styling ([d83448e](d83448e)) ### Reverts * Revert "chore(release): 1.87.0 [skip ci]" ([ca8d55c](ca8d55c))

matticbot · 2022-08-10T22:15:41Z

🎉 This PR is included in version 1.89.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.89.0](v1.88.0...v1.89.0) (2022-08-16) ### Bug Fixes * **active-campaign:** legacy contacts detection ([#1858](#1858)) ([67640a5](67640a5)) * **campaigns-wizard:** segmentation wording ([ddf61ad](ddf61ad)) * ensure scroll on smaller height ([#1813](#1813)) ([e234e8b](e234e8b)) * fix fatal error when debug mode active ([#1826](#1826)) ([d9388ee](d9388ee)) * **ga:** cookie parsing ([#1857](#1857)) ([a936abd](a936abd)) * google auth button type ([#1829](#1829)) ([3704d9f](3704d9f)) * **google-auth:** catch and display errors ([#1871](#1871)) ([67cbcfd](67cbcfd)) * **google-auth:** ensure popup on user click event ([#1831](#1831)) ([0af9abf](0af9abf)) * **magic-links:** fix email encoding on sent link ([#1833](#1833)) ([8d4756c](8d4756c)) * **my account:** handle legacy data ([#1823](#1823)) ([6816799](6816799)) * **newsletters:** use international date format ([#1855](#1855)) ([4cda57d](4cda57d)) * **oauth:** csrf token lifespan ([#1869](#1869)) ([52e0f8b](52e0f8b)) * parse CID from _ga cookie if it only contains CID string ([#1874](#1874)) ([dc1fb52](dc1fb52)) * **popups:** use new Campaigns method for creating donation events on new orders ([#1794](#1794)) ([49dc14c](49dc14c)) * **reader-activation:** add metadata to reader registered on donation ([722724c](722724c)) * **reader-activation:** handle modal conflict when auth is triggered from a prompt ([c2a0141](c2a0141)), closes [#1835](#1835) * **reader-activation:** handle no lists config available ([23b0249](23b0249)) * **reader-activation:** reinitialize auth links after DOM load ([#1812](#1812)) ([0a4b499](0a4b499)) * **reader-activation:** remove async prop from library ([#1846](#1846)) ([4131ca6](4131ca6)) * **reader-activation:** username generation handling ([#1789](#1789)) ([17edf2a](17edf2a)) * redirecting to My Account after logging in while pre-authed ([#1863](#1863)) ([ddf111e](ddf111e)) * **registration-block:** don't escape html for sign in labels ([#1834](#1834)) ([871300d](871300d)) * **registration-block:** margin for success message ([#1808](#1808)) ([1bfe546](1bfe546)) * **registration-block:** render on preview ([#1844](#1844)) ([87b9be9](87b9be9)) * tweak arguments for magic link client hash ([#1862](#1862)) ([8dcd45e](8dcd45e)) * verify reader on google authentication ([#1873](#1873)) ([c9c4eef](c9c4eef)) ### Features * **active-campaign:** metadata improvements ([#1851](#1851)) ([48883af](48883af)) * **active-campaigns:** override is-new-contact for legacy contacts ([34dd9a2](34dd9a2)) * **analytics:** send GA events on the server side ([#1828](#1828)) ([3e384e1](3e384e1)) * authenticated reader cookie ([#1882](#1882)) ([352316b](352316b)) * better welcome email copy for initial verification ([#1880](#1880)) ([604ebf7](604ebf7)) * cookie reader's preferred auth strategy ([#1875](#1875)) ([fc47f41](fc47f41)) * disable woocomerce welcome emails in favor of verification email ([#1876](#1876)) ([1e470e3](1e470e3)) * **donations:** remove defaultFrequency from the configuration ([#1814](#1814)) ([b6aa894](b6aa894)) * handle contact update w/out lists selection ([#1816](#1816)) ([67574d1](67574d1)) * handle new frequency options in Campaigns dashbaord ([#1779](#1779)) ([c770a7d](c770a7d)) * if registering an email that already has an account, show different message ([#1849](#1849)) ([bf48bc4](bf48bc4)) * lock access to My Account UI until account is verified ([#1877](#1877)) ([a850f48](a850f48)) * **my-account:** stripe billing portal link ([#1761](#1761)) ([3e69af1](3e69af1)), closes [#1742](#1742) [#1739](#1739) [#1740](#1740) [#1741](#1741) [#1782](#1782) * **reader-activation:** account link and auth form ([#1754](#1754)) ([b163664](b163664)) * **reader-activation:** activecampaign master list ([#1818](#1818)) ([ecbbc47](ecbbc47)) * **reader-activation:** disable 3rd party login buttons initially ([#1806](#1806)) ([c806bfe](c806bfe)) * **reader-activation:** optimistic account link ([#1847](#1847)) ([85c550a](85c550a)) * **reader-activation:** prevent updating user email in my-account ([7d49db4](7d49db4)) * **reader-activation:** registration auth cookie control ([#1787](#1787)) ([aeb0b5b](aeb0b5b)) * **reader-activation:** settings wizard ([#1773](#1773)) ([aaff0de](aaff0de)) * **reader-auth:** make password login the first option, instead of login link ([1fe5ffa](1fe5ffa)), closes [#1809](#1809) * register anonymous single donors ([#1795](#1795)) ([9e4f2f6](9e4f2f6)) * **registration-block:** add success icon ([#1804](#1804)) ([86c38f8](86c38f8)) * **registration-block:** editable success state ([#1785](#1785)) ([7dcea82](7dcea82)), closes [#1768](#1768) * **registration-block:** login with Google ([#1781](#1781)) ([ed79c5c](ed79c5c)), closes [#1774](#1774) * **registration-block:** newsletter subscription ([#1778](#1778)) ([717b5b8](717b5b8)) * reorganise donations wizard and use buttongroup for donation type ([#1824](#1824)) ([f7b58ae](f7b58ae)) * replace WooCommerce’s login form with our own ([#1854](#1854)) ([f5b24c4](f5b24c4)) * **rss:** adds offset feature ([#1790](#1790)) ([321eff5](321eff5)) * send user metadata to AC ([#1793](#1793)) ([03a15ba](03a15ba)) * set client id cookie; reader activation tweaks ([#1780](#1780)) ([96a07ae](96a07ae)) * **stripe:** webhook auto-creation and validation ([365aed9](365aed9)) * tweak registration block styling ([d83448e](d83448e)) ### Reverts * Revert "chore(release): 1.87.0 [skip ci]" ([ca8d55c](ca8d55c))

matticbot · 2022-08-16T18:10:28Z

🎉 This PR is included in version 1.89.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

feat(registration-block): editable success state

f18d369

adekbadek added [Status] Needs Review The issue or pull request needs to be reviewed [Status] Needs Design Review labels Jul 15, 2022

adekbadek requested a review from a team as a code owner July 15, 2022 15:17

adekbadek removed the [Status] Needs Review The issue or pull request needs to be reviewed label Jul 15, 2022

feat: always notify about email link

576cd2d

adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Jul 15, 2022

feat: change state editing UI

f67274d

feat: button UI

d8e5818

adekbadek added 2 commits July 20, 2022 14:14

chore: remove unused variable

632ffcc

Merge master into feat/registration-block-success-state

e2fe1b7

adekbadek force-pushed the feat/registration-block-success-state branch from d69e91a to e2fe1b7 Compare July 22, 2022 09:02

style(reader-registration): adjust state-bar

84c9862

thomasguillot removed the [Status] Needs Design Review label Jul 22, 2022

Merge master into feat/registration-block-success-state

acdaa12

miguelpeixe requested changes Jul 25, 2022

View reviewed changes

adekbadek added 2 commits July 25, 2022 21:01

fix: editor alignment & variable name

2ae7720

fix: default success message

a5714b5

adekbadek requested a review from miguelpeixe July 25, 2022 19:04

miguelpeixe approved these changes Jul 25, 2022

View reviewed changes

github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jul 25, 2022

adekbadek merged commit 7dcea82 into master Jul 26, 2022

adekbadek deleted the feat/registration-block-success-state branch July 26, 2022 07:21

matticbot added the released on @alpha label Aug 5, 2022

dkoo pushed a commit that referenced this pull request Aug 10, 2022

feat(registration-block): editable success state (#1785)

e836c5a

Closes #1768 Co-authored-by: Thomas Guillot <thomasguillot@users.noreply.github.com>

matticbot added the released label Aug 16, 2022

feat(registration-block): editable success state #1785

feat(registration-block): editable success state #1785

Uh oh!

Conversation

adekbadek commented Jul 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

Uh oh!

adekbadek commented Jul 15, 2022

Uh oh!

miguelpeixe commented Jul 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miguelpeixe commented Jul 15, 2022

Uh oh!

thomasguillot commented Jul 19, 2022

Uh oh!

adekbadek commented Jul 19, 2022

Uh oh!

adekbadek commented Jul 19, 2022

Uh oh!

thomasguillot commented Jul 19, 2022

Uh oh!

adekbadek commented Jul 19, 2022

Uh oh!

thomasguillot commented Jul 19, 2022

Uh oh!

adekbadek commented Jul 20, 2022

Uh oh!

thomasguillot commented Jul 22, 2022

Uh oh!

miguelpeixe left a comment

Choose a reason for hiding this comment

Uh oh!

miguelpeixe Jul 25, 2022

Choose a reason for hiding this comment

Uh oh!

adekbadek Jul 25, 2022

Choose a reason for hiding this comment

Uh oh!

adekbadek commented Jul 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miguelpeixe left a comment

Choose a reason for hiding this comment

Uh oh!

matticbot commented Aug 5, 2022

Uh oh!

matticbot commented Aug 10, 2022

Uh oh!

matticbot commented Aug 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adekbadek commented Jul 15, 2022 •

edited

Loading

miguelpeixe commented Jul 15, 2022 •

edited

Loading

adekbadek commented Jul 25, 2022 •

edited

Loading