fix(content-distribution): handling multiple post meta #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
fix/content-distribution-consecutive-dispatches
to
trunk
January 21, 2025 19:22
naxoc
approved these changes
Jan 22, 2025
Member
naxoc
left a comment
naxoc
left a comment
There was a problem hiding this comment.
Yep! And good call on updating the function name. 👍
|
Hey @miguelpeixe, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Jan 23, 2025
# [2.5.0-alpha.1](v2.4.0...v2.5.0-alpha.1) (2025-01-23) ### Bug Fixes * **content-distribution:** block additional UI components ([#197](#197)) ([3f30cdb](3f30cdb)) * **content-distribution:** handling multiple post meta ([#199](#199)) ([c93084d](c93084d)) * **content-distribution:** Improve CSS for blocked editor ([#193](#193)) ([295bdad](295bdad)), closes [#181](#181) * **content-distribution:** persist site hash ([#186](#186)) ([120b759](120b759)) * **content-distribution:** prevent consecutive dispatches ([#198](#198)) ([2149a62](2149a62)) * **content-distribution:** refactor outgoing post js ([#188](#188)) ([cc08edc](cc08edc)) * **memberships:** remove managed fields on cancel or expire ([#192](#192)) ([67a5cf0](67a5cf0)) ### Features * **content-distribution:** Block the editor for incoming posts ([#181](#181)) ([48b4cae](48b4cae)) * **content-distribution:** confirm dialog for unlinking and relinking posts ([#190](#190)) ([f36bb28](f36bb28)) * **content-distribution:** migrator ([#185](#185)) ([06ec18a](06ec18a)) * **content-distribution:** post status on create ([#189](#189)) ([1ad3e0c](1ad3e0c)) * sync multiple user roles ([#187](#187)) ([9fa833c](9fa833c))
Contributor
|
🎉 This PR is included in version 2.5.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Feb 3, 2025
# [2.5.0](v2.4.0...v2.5.0) (2025-02-03) ### Bug Fixes * **content-distribution:** block additional UI components ([#197](#197)) ([3f30cdb](3f30cdb)) * **content-distribution:** handling multiple post meta ([#199](#199)) ([c93084d](c93084d)) * **content-distribution:** Improve CSS for blocked editor ([#193](#193)) ([295bdad](295bdad)), closes [#181](#181) * **content-distribution:** persist site hash ([#186](#186)) ([120b759](120b759)) * **content-distribution:** prevent consecutive dispatches ([#198](#198)) ([2149a62](2149a62)) * **content-distribution:** refactor outgoing post js ([#188](#188)) ([cc08edc](cc08edc)) * **memberships:** remove managed fields on cancel or expire ([#192](#192)) ([67a5cf0](67a5cf0)) ### Features * **content-distribution:** Block the editor for incoming posts ([#181](#181)) ([48b4cae](48b4cae)) * **content-distribution:** confirm dialog for unlinking and relinking posts ([#190](#190)) ([f36bb28](f36bb28)) * **content-distribution:** migrator ([#185](#185)) ([06ec18a](06ec18a)) * **content-distribution:** post status on create ([#189](#189)) ([1ad3e0c](1ad3e0c)) * sync multiple user roles ([#187](#187)) ([9fa833c](9fa833c))
Contributor
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of a post meta with multiple entries doesn't work well. It fails to identify existing entries, adding new values every sync.
This PR changes the strategy by detecting whether the entire group has changed and replacing it. This is also to support multiple entries with equal value, which is allowed.
The protected method also got its name updated to not confuse with core's
update_post_meta.Testing