Skip to content

feat(content-distribution): post status on create #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miguelpeixe merged 22 commits into from
Jan 20, 2025
Merged

feat(content-distribution): post status on create #189

miguelpeixe merged 22 commits into from
Jan 20, 2025

Conversation

@miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Jan 17, 2025 •
edited
Loading

1208510338230630-as-1209168371395424
p1737121608239039-slack-C055SRT7WN4

Support configuring the post status on distribution. This should only take effect when creating the post.

image image image

Testing

  1. Distribute a post without changing the status and confirm it's distributed as a draft.
  2. Distribute a post changing the status to "Published" and confirm it's distributed as published.
  3. Do the same via CLI and confirm it also reflects the status:
newspack network distribute post {post_id} --sites=https://node1.local --status_on_create=publish

@miguelpeixe miguelpeixe requested a review from a team as a code owner January 17, 2025 15:45
@miguelpeixe miguelpeixe self-assigned this Jan 17, 2025
Base automatically changed from fix/content-distribution-editor-outgoing-post to trunk January 20, 2025 15:49
@miguelpeixe miguelpeixe requested a review from naxoc January 20, 2025 18:18
naxoc
naxoc approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@naxoc naxoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Added a couple of small comments, but feel free to merge once you are done with those :)

src/content-distribution/incoming-post/style.scss

.editor-sidebar:not(#newspack-network-incoming-post\:newspack-network-content-distribution-panel, #edit-post\:document) {
@include grey-out-outer;

Copy link
Member

@naxoc naxoc Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this one might also overwrite #193

Copy link
Member Author

@miguelpeixe miguelpeixe Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 I did a very bad job fixing conflicts, sorry about that!

Fixed in 8ed2220

src/icons/drafts.js
@@ -0,0 +1,16 @@
/**
Copy link
Member

@naxoc naxoc Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor: but why is it drafts plural? Should it not be singular?

Copy link
Member Author

@miguelpeixe miguelpeixe Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to diverge from the source: https://github.com/WordPress/gutenberg/blob/2943dd3adfa4e1ad33b980760277377df9ac0f91/packages/editor/src/components/post-status/index.js

Copy link
Member

@naxoc naxoc Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. Thanks!

@miguelpeixe miguelpeixe requested a review from naxoc January 20, 2025 20:37
@miguelpeixe miguelpeixe merged commit 1ad3e0c into trunk Jan 20, 2025
4 checks passed
@github-actions
Copy link

github-actions bot commented Jan 20, 2025

Hey @miguelpeixe, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

@miguelpeixe miguelpeixe deleted the feat/content-distribution-status-on-create branch January 20, 2025 20:41
matticbot pushed a commit that referenced this pull request Jan 23, 2025
@semantic-release-bot
chore(release): 2.5.0-alpha.1 [skip ci]
28f511b 
# [2.5.0-alpha.1](v2.4.0...v2.5.0-alpha.1) (2025-01-23)

### Bug Fixes

* **content-distribution:** block additional UI components ([#197](#197)) ([3f30cdb](3f30cdb))
* **content-distribution:** handling multiple post meta ([#199](#199)) ([c93084d](c93084d))
* **content-distribution:** Improve CSS for blocked editor ([#193](#193)) ([295bdad](295bdad)), closes [#181](#181)
* **content-distribution:** persist site hash ([#186](#186)) ([120b759](120b759))
* **content-distribution:** prevent consecutive dispatches ([#198](#198)) ([2149a62](2149a62))
* **content-distribution:** refactor outgoing post js ([#188](#188)) ([cc08edc](cc08edc))
* **memberships:** remove managed fields on cancel or expire ([#192](#192)) ([67a5cf0](67a5cf0))

### Features

* **content-distribution:** Block the editor for incoming posts ([#181](#181)) ([48b4cae](48b4cae))
* **content-distribution:** confirm dialog for unlinking and relinking posts ([#190](#190)) ([f36bb28](f36bb28))
* **content-distribution:** migrator ([#185](#185)) ([06ec18a](06ec18a))
* **content-distribution:** post status on create ([#189](#189)) ([1ad3e0c](1ad3e0c))
* sync multiple user roles ([#187](#187)) ([9fa833c](9fa833c))
@matticbot
Copy link
Contributor

matticbot commented Jan 23, 2025

🎉 This PR is included in version 2.5.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 3, 2025
@semantic-release-bot
chore(release): 2.5.0 [skip ci]
854b624 
# [2.5.0](v2.4.0...v2.5.0) (2025-02-03)

### Bug Fixes

* **content-distribution:** block additional UI components ([#197](#197)) ([3f30cdb](3f30cdb))
* **content-distribution:** handling multiple post meta ([#199](#199)) ([c93084d](c93084d))
* **content-distribution:** Improve CSS for blocked editor ([#193](#193)) ([295bdad](295bdad)), closes [#181](#181)
* **content-distribution:** persist site hash ([#186](#186)) ([120b759](120b759))
* **content-distribution:** prevent consecutive dispatches ([#198](#198)) ([2149a62](2149a62))
* **content-distribution:** refactor outgoing post js ([#188](#188)) ([cc08edc](cc08edc))
* **memberships:** remove managed fields on cancel or expire ([#192](#192)) ([67a5cf0](67a5cf0))

### Features

* **content-distribution:** Block the editor for incoming posts ([#181](#181)) ([48b4cae](48b4cae))
* **content-distribution:** confirm dialog for unlinking and relinking posts ([#190](#190)) ([f36bb28](f36bb28))
* **content-distribution:** migrator ([#185](#185)) ([06ec18a](06ec18a))
* **content-distribution:** post status on create ([#189](#189)) ([1ad3e0c](1ad3e0c))
* sync multiple user roles ([#187](#187)) ([9fa833c](9fa833c))
@matticbot
Copy link
Contributor

matticbot commented Feb 3, 2025

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naxoc naxoc Awaiting requested review from naxoc

Assignees

@miguelpeixe miguelpeixe

Labels

released on @alpha released [Status] Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miguelpeixe @matticbot @naxoc