Skip to content

fix(content-distribution): handling multiple post meta #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguelpeixe merged 3 commits into from
Jan 22, 2025
Merged

fix(content-distribution): handling multiple post meta #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd27d3f
fix(content-distribution): prevent consecutive dispatches
miguelpeixe Jan 21, 2025
c264def
fix(content-distribution): handling multiple post meta
miguelpeixe Jan 21, 2025
ce1dcd5
Merge branch 'trunk' into fix/content-distribution-multiple-post-meta
miguelpeixe Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions includes/content-distribution/class-incoming-post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ public function is_linked(): bool {
*
* @return void
*/
protected function update_post_meta() {
protected function update_meta() {
$data = $this->payload['post_data']['post_meta'];

$reserved_keys = Content_Distribution::get_reserved_post_meta_keys();
Expand All @@ -297,8 +297,12 @@ protected function update_post_meta() {
if ( 1 === count( $meta_value ) ) {
update_post_meta( $this->ID, $meta_key, $meta_value[0] );
} else {
foreach ( $meta_value as $value ) {
add_post_meta( $this->ID, $meta_key, $value );
$value = get_post_meta( $this->ID, $meta_key, false );
if ( $value !== $meta_value ) {
delete_post_meta( $this->ID, $meta_key );
foreach ( $meta_value as $item ) {
add_post_meta( $this->ID, $meta_key, $item );
}
}
}
}
Expand Down Expand Up @@ -497,7 +501,7 @@ public function insert( $payload = [] ) {
$this->post = get_post( $this->ID );

// Handle post meta.
$this->update_post_meta();
$this->update_meta();

// Handle thumbnail.
$thumbnail_url = $post_data['thumbnail_url'];
Expand Down
17 changes: 17 additions & 0 deletions tests/unit-tests/content-distribution/test-incoming-post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,23 @@ public function test_post_meta_sync() {
$this->assertEmpty( get_post_meta( $post_id, 'custom', true ) );
}

/**
* Test adding and deleting post meta.
*/
public function test_add_and_delete_multiple_post_meta() {
$post_id = $this->incoming_post->insert();

$payload = $this->get_sample_payload();

$payload['post_data']['post_meta']['multiple'] = [ 'value 2', 'value 3' ];
$this->incoming_post->insert( $payload );
$this->assertSame( [ 'value 2', 'value 3' ], get_post_meta( $post_id, 'multiple' ) );

$payload['post_data']['post_meta']['multiple'] = [ 'value 3', 'value 3' ];
$this->incoming_post->insert( $payload );
$this->assertSame( [ 'value 3', 'value 3' ], get_post_meta( $post_id, 'multiple' ) );
}

/**
* Test status changes.
*/
Expand Down
Loading