fix: nominal wants issue #2010 #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-potter
approved these changes
Sep 30, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Oct 10, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.65.0` -> `v0.67.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.67.0`](https://github.com/Automattic/harper/releases/tag/v0.67.0) [Compare Source](Automattic/harper@v0.66.0...v0.67.0) #### What's Changed - feat(core): Add support for Python docstrings by [@​rushter](https://github.com/rushter) in [#​2038](Automattic/harper#2038) - feat(web): revise landing page by [@​elijah-potter](https://github.com/elijah-potter) in [#​2046](Automattic/harper#2046) - fix(web): remove faq link by [@​mcecode](https://github.com/mcecode) in [#​2047](Automattic/harper#2047) - fix(obsidian): properly manage dictionary by [@​elijah-potter](https://github.com/elijah-potter) in [#​2050](Automattic/harper#2050) - fix(web): will now work on Hacker News by [@​elijah-potter](https://github.com/elijah-potter) in [#​2053](Automattic/harper#2053) - docs: remove or update remaining faq page links by [@​mcecode](https://github.com/mcecode) in [#​2061](Automattic/harper#2061) - build(deps): bump ordered-float from 5.0.0 to 5.1.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2059](Automattic/harper#2059) - refactor(chrome-ext): drop jquery dependency by [@​Ingramz](https://github.com/Ingramz) in [#​2052](Automattic/harper#2052) - fix(wasm): remove overlaps in the proper order by [@​elijah-potter](https://github.com/elijah-potter) in [#​2062](Automattic/harper#2062) - fix(chrome-plugin): errors saving rule state in Firefox by [@​elijah-potter](https://github.com/elijah-potter) in [#​2064](Automattic/harper#2064) - fix(chrome-ext): disable on comboboxes by [@​elijah-potter](https://github.com/elijah-potter) in [#​2063](Automattic/harper#2063) - More irregular verbs for 'have went' linter by [@​hippietrail](https://github.com/hippietrail) in [#​1973](Automattic/harper#1973) #### New Contributors - [@​rushter](https://github.com/rushter) made their first contribution in [#​2038](Automattic/harper#2038) - [@​Ingramz](https://github.com/Ingramz) made their first contribution in [#​2052](Automattic/harper#2052) **Full Changelog**: <Automattic/harper@v0.66.0...v0.67.0> ### [`v0.66.0`](https://github.com/Automattic/harper/releases/tag/v0.66.0) [Compare Source](Automattic/harper@v0.65.0...v0.66.0) #### What's Changed - fix: format of checkboxes was broken in feature request template by [@​hippietrail](https://github.com/hippietrail) in [#​1992](Automattic/harper#1992) - fix: org-mode add list item parsing with tab normalization by [@​eloycoto](https://github.com/eloycoto) in [#​1989](Automattic/harper#1989) - feat(chrome-ext): use new CSS Highlights API where possible by [@​elijah-potter](https://github.com/elijah-potter) in [#​1970](Automattic/harper#1970) - feat: add ink support by [@​FreddieGilbraith](https://github.com/FreddieGilbraith) in [#​1894](Automattic/harper#1894) - feat:besides the point→beside the point, don't can→can't by [@​hippietrail](https://github.com/hippietrail) in [#​2021](Automattic/harper#2021) - Add more phrasal verb exceptions by [@​hippietrail](https://github.com/hippietrail) in [#​2002](Automattic/harper#2002) - feat(core): create initial `MissingTo` rule by [@​elijah-potter](https://github.com/elijah-potter) in [#​1990](Automattic/harper#1990) - fix(core): address problems with prepositional phrases by [@​elijah-potter](https://github.com/elijah-potter) in [#​2022](Automattic/harper#2022) - build(deps): bump tree-sitter from 0.25.9 to 0.25.10 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2029](Automattic/harper#2029) - Criteria phenomena by [@​TomasoAlbinoni](https://github.com/TomasoAlbinoni) in [#​2028](Automattic/harper#2028) - build(deps): bump serde from 1.0.226 to 1.0.228 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2032](Automattic/harper#2032) - build(deps): bump thiserror from 2.0.16 to 2.0.17 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2030](Automattic/harper#2030) - chore: missing words, annotations by [@​hippietrail](https://github.com/hippietrail) in [#​1999](Automattic/harper#1999) - feat(core): create tagged linting function by [@​elijah-potter](https://github.com/elijah-potter) in [#​1998](Automattic/harper#1998) - build(deps): bump indexmap from 2.11.1 to 2.11.4 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2031](Automattic/harper#2031) - fix: nominal wants issue [#​2010](Automattic/harper#2010) by [@​hippietrail](https://github.com/hippietrail) in [#​2034](Automattic/harper#2034) - fix(ci): reduce redundancy in CI by [@​elijah-potter](https://github.com/elijah-potter) in [#​2037](Automattic/harper#2037) - feat(core): use a better quote-pairing algorithm by [@​elijah-potter](https://github.com/elijah-potter) in [#​2036](Automattic/harper#2036) #### New Contributors - [@​FreddieGilbraith](https://github.com/FreddieGilbraith) made their first contribution in [#​1894](Automattic/harper#1894) - [@​TomasoAlbinoni](https://github.com/TomasoAlbinoni) made their first contribution in [#​2028](Automattic/harper#2028) **Full Changelog**: <Automattic/harper@v0.65.0...v0.66.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xMzIuNSIsInVwZGF0ZWRJblZlciI6IjQxLjEzNS41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes #2010
Description
I identified this issue thanks to the new "organized lints"! 🎉
Also my first PR from behind the GFW! 🥳
I changed from allocating a
Stringto doing all string comparisons directly on the&[char].The replacement wasn't using
replace_with_match_case.The logic for determining whether the pronoun and verb already matched for case, person, and number wasn't quite right.
How Has This Been Tested?
I added a new unit test using the text from the bug report.
Checklist