Criteria phenomena #2028

TomasoAlbinoni · 2025-09-28T14:41:31Z

Issues

Description

New linter that checks if 'criteria' or 'phenomena' is used as singular.

Demo

How Has This Been Tested?

Using just lint filename

Checklist

I have performed a self-review of my own code
I have added tests to cover my changes

hippietrail

Some very minor nitpicks.

hippietrail · 2025-09-28T19:04:02Z

harper-core/src/linting/lint_group.rs

        insert_expr_rule!(Months, true);
        insert_expr_rule!(MostNumber, true);
        insert_expr_rule!(MultipleSequentialPronouns, true);
+        insert_expr_rule!(CriteriaPhenomena, true);


It's not crucial but try to keep these in alphabetical order of Linter name. We've had a couple of times entries have become duped during merges after changing the order and ordering them makes it effortless to spot.

hippietrail · 2025-09-28T19:11:04Z

harper-core/src/linting/criteria_phenomena.rs

+            }
+        }
+
+        Some(Lint {


It's just a tiny nitpick but if something changes the linter in the future to have other than 3 tokens it would still return Some(Lint) just without any suggestions. I would include returning the lint insdide the if block. You can return None otherwise, or often it's possible to use ? when checking the preconditions to obviate that...

hippietrail · 2025-09-28T19:15:44Z

harper-core/src/linting/criteria_phenomena.rs

+                SequenceExpr::default()
+                    .then(singular_modifiers.clone())
+                    .then(
+                        SequenceExpr::default()


This SequnceExpr shouldn't be needed. You can just chain the the two .then... inside it right after the first one.

TomasoAlbinoni · 2025-09-28T21:46:03Z

Some very minor nitpicks.

@hippietrail Thanks very much for the feedback!

hippietrail

One of my comments that got blocked by the Great Firewall.

hippietrail · 2025-09-29T02:59:47Z

harper-core/src/linting/criteria_phenomena.rs

+        let second_word = matched_tokens[2]
+            .span
+            .get_content(source)
+            .to_string()


I believe this will cause an allocation that can be avoided by using the string comparison methods available directly on the result of get_content(). (This was part of my original review but the Great Firewall caused a problem.)

elijah-potter

This looks great! I can imagine extending this down the road to cover even more plural confusions.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.65.0` -> `v0.67.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.67.0`](https://github.com/Automattic/harper/releases/tag/v0.67.0) [Compare Source](Automattic/harper@v0.66.0...v0.67.0) #### What's Changed - feat(core): Add support for Python docstrings by [@rushter](https://github.com/rushter) in [#2038](Automattic/harper#2038) - feat(web): revise landing page by [@elijah-potter](https://github.com/elijah-potter) in [#2046](Automattic/harper#2046) - fix(web): remove faq link by [@mcecode](https://github.com/mcecode) in [#2047](Automattic/harper#2047) - fix(obsidian): properly manage dictionary by [@elijah-potter](https://github.com/elijah-potter) in [#2050](Automattic/harper#2050) - fix(web): will now work on Hacker News by [@elijah-potter](https://github.com/elijah-potter) in [#2053](Automattic/harper#2053) - docs: remove or update remaining faq page links by [@mcecode](https://github.com/mcecode) in [#2061](Automattic/harper#2061) - build(deps): bump ordered-float from 5.0.0 to 5.1.0 by [@dependabot](https://github.com/dependabot)\[bot] in [#2059](Automattic/harper#2059) - refactor(chrome-ext): drop jquery dependency by [@Ingramz](https://github.com/Ingramz) in [#2052](Automattic/harper#2052) - fix(wasm): remove overlaps in the proper order by [@elijah-potter](https://github.com/elijah-potter) in [#2062](Automattic/harper#2062) - fix(chrome-plugin): errors saving rule state in Firefox by [@elijah-potter](https://github.com/elijah-potter) in [#2064](Automattic/harper#2064) - fix(chrome-ext): disable on comboboxes by [@elijah-potter](https://github.com/elijah-potter) in [#2063](Automattic/harper#2063) - More irregular verbs for 'have went' linter by [@hippietrail](https://github.com/hippietrail) in [#1973](Automattic/harper#1973) #### New Contributors - [@rushter](https://github.com/rushter) made their first contribution in [#2038](Automattic/harper#2038) - [@Ingramz](https://github.com/Ingramz) made their first contribution in [#2052](Automattic/harper#2052) **Full Changelog**: <Automattic/harper@v0.66.0...v0.67.0> ### [`v0.66.0`](https://github.com/Automattic/harper/releases/tag/v0.66.0) [Compare Source](Automattic/harper@v0.65.0...v0.66.0) #### What's Changed - fix: format of checkboxes was broken in feature request template by [@hippietrail](https://github.com/hippietrail) in [#1992](Automattic/harper#1992) - fix: org-mode add list item parsing with tab normalization by [@eloycoto](https://github.com/eloycoto) in [#1989](Automattic/harper#1989) - feat(chrome-ext): use new CSS Highlights API where possible by [@elijah-potter](https://github.com/elijah-potter) in [#1970](Automattic/harper#1970) - feat: add ink support by [@FreddieGilbraith](https://github.com/FreddieGilbraith) in [#1894](Automattic/harper#1894) - feat:besides the point→beside the point, don't can→can't by [@hippietrail](https://github.com/hippietrail) in [#2021](Automattic/harper#2021) - Add more phrasal verb exceptions by [@hippietrail](https://github.com/hippietrail) in [#2002](Automattic/harper#2002) - feat(core): create initial `MissingTo` rule by [@elijah-potter](https://github.com/elijah-potter) in [#1990](Automattic/harper#1990) - fix(core): address problems with prepositional phrases by [@elijah-potter](https://github.com/elijah-potter) in [#2022](Automattic/harper#2022) - build(deps): bump tree-sitter from 0.25.9 to 0.25.10 by [@dependabot](https://github.com/dependabot)\[bot] in [#2029](Automattic/harper#2029) - Criteria phenomena by [@TomasoAlbinoni](https://github.com/TomasoAlbinoni) in [#2028](Automattic/harper#2028) - build(deps): bump serde from 1.0.226 to 1.0.228 by [@dependabot](https://github.com/dependabot)\[bot] in [#2032](Automattic/harper#2032) - build(deps): bump thiserror from 2.0.16 to 2.0.17 by [@dependabot](https://github.com/dependabot)\[bot] in [#2030](Automattic/harper#2030) - chore: missing words, annotations by [@hippietrail](https://github.com/hippietrail) in [#1999](Automattic/harper#1999) - feat(core): create tagged linting function by [@elijah-potter](https://github.com/elijah-potter) in [#1998](Automattic/harper#1998) - build(deps): bump indexmap from 2.11.1 to 2.11.4 by [@dependabot](https://github.com/dependabot)\[bot] in [#2031](Automattic/harper#2031) - fix: nominal wants issue [#2010](Automattic/harper#2010) by [@hippietrail](https://github.com/hippietrail) in [#2034](Automattic/harper#2034) - fix(ci): reduce redundancy in CI by [@elijah-potter](https://github.com/elijah-potter) in [#2037](Automattic/harper#2037) - feat(core): use a better quote-pairing algorithm by [@elijah-potter](https://github.com/elijah-potter) in [#2036](Automattic/harper#2036) #### New Contributors - [@FreddieGilbraith](https://github.com/FreddieGilbraith) made their first contribution in [#1894](Automattic/harper#1894) - [@TomasoAlbinoni](https://github.com/TomasoAlbinoni) made their first contribution in [#2028](Automattic/harper#2028) **Full Changelog**: <Automattic/harper@v0.65.0...v0.66.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

TomasoAlbinoni and others added 3 commits September 26, 2025 21:16

Add rule for criteria/phenomena used as singular

23ff6a7

Merge branch 'Automattic:master' into criteria-phenomena

8fdc11a

just formatted

ae7df47

TomasoAlbinoni marked this pull request as ready for review September 28, 2025 15:35

hippietrail reviewed Sep 28, 2025

View reviewed changes

Move linter to correct alphabetical position, improve linter logic

be71331

hippietrail reviewed Sep 29, 2025

View reviewed changes

Eliminate unnecessary allocation

3c57a96

elijah-potter approved these changes Sep 29, 2025

View reviewed changes

elijah-potter added this pull request to the merge queue Sep 29, 2025

Merged via the queue into Automattic:master with commit 5f4f66d Sep 29, 2025
9 checks passed

BrewTestBot mentioned this pull request Oct 1, 2025

harper 0.66.0 Homebrew/homebrew-core#246519

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Criteria phenomena #2028

Criteria phenomena #2028

Uh oh!

TomasoAlbinoni commented Sep 28, 2025 •

edited

Loading

Uh oh!

hippietrail left a comment

Uh oh!

hippietrail Sep 28, 2025

Uh oh!

hippietrail Sep 28, 2025

Uh oh!

hippietrail Sep 28, 2025 •

edited

Loading

Uh oh!

TomasoAlbinoni commented Sep 28, 2025

Uh oh!

hippietrail left a comment

Uh oh!

hippietrail Sep 29, 2025

Uh oh!

elijah-potter left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Criteria phenomena #2028

Criteria phenomena #2028

Uh oh!

Conversation

TomasoAlbinoni commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Description

Demo

How Has This Been Tested?

Checklist

Uh oh!

hippietrail left a comment

Choose a reason for hiding this comment

Uh oh!

hippietrail Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

hippietrail Sep 28, 2025

Choose a reason for hiding this comment

Uh oh!

hippietrail Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomasoAlbinoni commented Sep 28, 2025

Uh oh!

hippietrail left a comment

Choose a reason for hiding this comment

Uh oh!

hippietrail Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

elijah-potter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TomasoAlbinoni commented Sep 28, 2025 •

edited

Loading

hippietrail Sep 28, 2025 •

edited

Loading