-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add user calculation endpoint and updating pending/revoked logic #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going through this and trying to think about how to do this while keeping the query logic inside UserQueryParams where possible - would it help if we added a general approval_status filter that return results for both platforms and groups with the status? We could make it so that you can't specify both approval_status and the more specific platform_approval_status etc. filters. That way we could probably do most of what we need within the UserQueryParams logic
|
Thanks for the review and the suggestion @marius-mather - |
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor changes to suggest but otherwise this is looking great!
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just needs a comment on how the approval status logic works because it was confusing (to me at least)
marius-mather
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, thanks!
Description
AAI-530: Add endpoint to caluculate users
Changes
UserCountsResponse, count helper, and GETadmin/users/countsin routers/admin.pyChecklist
How to Test Manually (if necessary)
<Describe how reviewers can manually, if necessary, test the changes>