fix(core-webhooks): create copy before deleting property #2863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faustbrian
approved these changes
Aug 5, 2019
Codecov Report
@@ Coverage Diff @@
## develop #2863 +/- ##
========================================
Coverage 65.39% 65.39%
========================================
Files 364 364
Lines 8257 8257
Branches 396 396
========================================
Hits 5400 5400
Misses 2822 2822
Partials 35 35Continue to review full report at Codecov.
|
ghost
deleted the
vasild
added a commit
that referenced
this pull request
Aug 6, 2019
…o-db * ArkEcosystem/core/2.6: refactor(core-transactions): make handler functions asynchronous (#2865) fix: merge fix: delete existing db (#2864) fix: clone webhook before mutating it (#2863) fix: delete existing db fix: clone webhook before mutating it fix(core-state): differentiate between wallets and delegates (#2854) fix(core-state): differentiate between wallets and delegates (#2854) refactor: increase transaction type size (#2861)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2860
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: