Webhooks that emit don't always add the authorization property to the header

[CryptologySAC]

When a Webhooks fires it doesn't always add the authorization property to the outgoing header.

Expected Behavior

The authorization property in the header is essential to confirm the source of the data received on the Webhooks listener and should always be added to the outgoing requests.

Current Behavior

When I register a new (original) webhook the requests it sends does contain the authorization property; when I have multiple (duplicate) webhooks registered on a node only the first registered one has a token property in the webhooks.json file and neither of them includes the token when emitted.

{
  "webhooks": [
    {
      "target": "http://127.0.0.1:4467/",
      "event": "transaction.applied",
      "conditions": [
        {
          "key": "recipientId",
          "value": "AcqtFLrackRcUbDdkkSZ2vSum7WqQ3W7A1",
          "condition": "eq"
        }
      ],
      "enabled": true,
      "id": "6862ec31-15a1-4105-b30b-e2b21a0f2634"
    },
    {
      "target": "http://127.0.0.1:4467/",
      "event": "transaction.applied",
      "conditions": [
        {
          "key": "recipientId",
          "value": "AcqtFLrackRcUbDdkkSZ2vSum7WqQ3W7A1",
          "condition": "eq"
        }
      ],
      "enabled": true,
      "token": "257532edf16b4f00ff8cc02a962df0a8",
      "id": "8c3a6314-69e6-4ea2-a87a-8e119fd48070"
    }
  ]
}

Possible Solution

• make sure every registered webhook has complete data (e.g. contains the token property) and/or limit the registration of duplicate webhooks.
• emit an event for each individual webhook in case of duplicate Webhooks

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

[CryptologySAC]

Seems to also remove the property from the header of every emit after I request the Webhooks by ID /api/webhooks/${id}

[faustbrian]

3145be7

This issue has been closed. If you wish to re-open it please provide additional information.