Skip to content

fix(core-webhooks): create copy before deleting property #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spkjp merged 2 commits into from
Aug 5, 2019
Merged

fix(core-webhooks): create copy before deleting property #2863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bc0245
fix: clone webhook before mutating it
spkjp Aug 5, 2019
fd28998
Merge branch 'develop' into fix/core-webhooks/token
spkjp Aug 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/core-webhooks/src/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ export const startServer = async config => {
path: "/api/webhooks",
handler: () => {
return {
data: database.all(),
data: database.all().map(webhook => {
webhook = { ...webhook };
delete webhook.token;
return webhook;
}),
};
},
});
Expand Down Expand Up @@ -68,7 +72,7 @@ export const startServer = async config => {
return Boom.notFound();
}

const webhook: IWebhook = database.findById(request.params.id);
const webhook: IWebhook = { ...database.findById(request.params.id) };
delete webhook.token;

return utils.respondWithResource(webhook);
Expand Down